The change to AbstractRequestContext is almost entirely code-moves.
Several private methods were made package-protected and makePayload()
was split into smaller methods.
In order to exercise the ProxySerializer as much as possible, all return
values in RequestFactoryTest are serialized locally an
Reviewers: rchandia, cramsdale,
Description:
Add ProxySerializer API to provide EntityProxy persistence primitives.
Issue 5523.
http://code.google.com/p/google-web-toolkit/wiki/RequestFactory_2_1_1
Patch by: bobv
Review by: rchandia, cramsdale
Please review this at http://gwt-code-reviews.appsp
Revision: 9275
Author: b...@google.com
Date: Tue Nov 23 18:08:23 2010
Log: Edited wiki page RequestFactory_2_1_1 through web user interface.
http://code.google.com/p/google-web-toolkit/source/detail?r=9275
Modified:
/wiki/RequestFactory_2_1_1.wiki
===
--- /wi
Sorry, should be fixed now.
http://gwt-code-reviews.appspot.com/1145801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1147801/diff/1/2
File
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
(right):
http://gwt-code-reviews.appspot.com/1147801/diff/1/2#newcode252
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client
http://gwt-code-reviews.appspot.com/1144801/diff/6001/7001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):
http://gwt-code-reviews.appspot.com/1144801/diff/6001/7001#newcode33
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:33: public
String computeBinaryClassName
http://gwt-code-reviews.appspot.com/1147801/diff/1/2
File
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
(right):
http://gwt-code-reviews.appspot.com/1147801/diff/1/2#newcode252
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client
LGTM.
FYI rietveld is unhappy with the patch for some reason: it's giving me
"error: old chunk mismatch" if I try to view the diff there.
On Tue, Nov 23, 2010 at 5:31 PM, wrote:
> Reviewers: conroy,
>
> Message:
> Because DeferredCommand is deprecated.
>
>
>
> Please review this at http://gwt-c
updated patch
http://gwt-code-reviews.appspot.com/1144801/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/TypeUtils.java (right):
http://gwt-code-reviews.appspot.com/1144801/diff/1/3#newcode28
dev/core/src/com/google/gwt/dev/javac/TypeUtils.java:28: public class
TypeUtils {
On 2010/11/23 21
http://gwt-code-reviews.appspot.com/1144801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: conroy,
Message:
When I converted JUnit to use normal serialization to transmit
exceptions, I introduced a problem. In DevMode, exceptions can get into
the client space from the hosting environment, such as
HostedModeException. Because these types are not visible to the client,
they
Reviewers: conroy,
Message:
Been deprecated for a while, time to remove the implementation.
Please review this at http://gwt-code-reviews.appspot.com/1146801/show
Affected files:
M user/src/com/google/gwt/junit/client/GWTTestCase.java
M user/src/com/google/gwt/junit/client/impl/JUnitResul
Reviewers: conroy,
Message:
Because DeferredCommand is deprecated.
Please review this at http://gwt-code-reviews.appspot.com/1145801/show
Affected files:
user/super/com/google/gwt/junit/translatable/com/google/gwt/junit/client/impl/GWTRunner.java
Index:
user/super/com/google/gwt/juni
On 2010/11/23 21:08:03, fredsa wrote:
LGTM
http://gwt-code-reviews.appspot.com/867801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1144801/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/TypeUtils.java (right):
http://gwt-code-reviews.appspot.com/1144801/diff/1/3#newcode28
dev/core/src/com/google/gwt/dev/javac/TypeUtils.java:28: public class
TypeUtils {
Shouldn't this be in com.google
This is a mechanical change - I am working on an alternate
implementation of TypeOracleMediator and this static method is needed in
lots of places, not just in building the type oracle.
http://gwt-code-reviews.appspot.com/1144801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contribu
Reviewers: tobyr, jbrosenberg, scottb,
Description:
Factors out TypeOracleMediator.computeBinaryClassName() into a separate
class file.
This function doesn't really have anything to do with the type oracle
mediator.
Moving it gets rid of most code references to the TypeOracleMediator
class.
This
http://gwt-code-reviews.appspot.com/867801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1140801/diff/6001/7002
File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
(right):
http://gwt-code-reviews.appspot.com/1140801/diff/6001/7002#newcode687
dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:687:
JMethod found = cls.find
LGTM
http://gwt-code-reviews.appspot.com/1140801/diff/6001/7002
File dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java
(right):
http://gwt-code-reviews.appspot.com/1140801/diff/6001/7002#newcode687
dev/core/src/com/google/gwt/core/ext/typeinfo/TypeOracle.java:687:
JMethod found = cl
On Tue, Nov 23, 2010 at 11:18 AM, wrote:
> Comment by vinays.work:
>
> I am seriously disappointed with the Editor framework. What we need is a
> Bean Binding framework much like those that have existed in Swing. You just
> associate the bean property with the widget and the interchange of UI val
On 2010/11/23 17:07:10, fabiomfv wrote:
LGTM if LGT jat&knorton
http://gwt-code-reviews.appspot.com/1116801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1116801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Comment by vinays.work:
I am seriously disappointed with the Editor framework. What we need is a
Bean Binding framework much like those that have existed in Swing. You just
associate the bean property with the widget and the interchange of UI value
with the bean needs to be automatic. JSF h
LGTM
With the theme of fixing translater->translator, could
CheckboxEventTranslater be changed to CheckboxEventTranslator as well?
http://gwt-code-reviews.appspot.com/1143801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006
File user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java
(right):
http://gwt-code-reviews.appspot.com/1082801/diff/101001/102006#newcode54
user/src/com/google/gwt/canvas/dom/client/CanvasPixelArray.java:54: *
Most browser
http://gwt-code-reviews.appspot.com/1082801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ok, lgtm ( :) )
On Mon, Nov 22, 2010 at 1:09 PM, Jason Rosenberg wrote:
> Ray,
>
> Good question, but yeah, that case will be handled too. Leaf types
> don't get visited for arrays at all (thus the root cause of this
> problem). I have added another test case with the Enum[][]
> reference, I
LGTM
http://gwt-code-reviews.appspot.com/1107801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: pdr,
Description:
Fixing JavaDoc warnings in Cell Widgets.
Please review this at http://gwt-code-reviews.appspot.com/1143801/show
Affected files:
M user/src/com/google/gwt/user/cellview/client/AbstractHasData.java
M user/src/com/google/gwt/user/cellview/client/CellBasedWidgetImp
LGTM.
This is another great change - thanks!
http://gwt-code-reviews.appspot.com/1139801/diff/1/2
File dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm.java
(right):
http://gwt-code-reviews.appspot.com/1139801/diff/1/2#newcode789
dev/core/src/com/google/gwt/soyc/MakeTopLevelHtmlForPerm
http://gwt-code-reviews.appspot.com/1140801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1107801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005
File user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java
(right):
http://gwt-code-reviews.appspot.com/1107801/diff/3001/4005#newcode43
user/src/com/google/gwt/user/client/rpc/ServiceDefTarget.java:43:
RpcToken getRpcToken();
On
34 matches
Mail list logo
