Revision: 9924
Author: skybr...@google.com
Date: Thu Mar 31 18:07:02 2011
Log: tweaked Showcase to make it more testable
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9924
Modified:
/trunk/samples/showcase/src/com/google/gwt/sample/showcase
Revision: 9923
Author: j...@google.com
Date: Thu Mar 31 14:56:42 2011
Log: Add support for {#} to mean the right-most plural argument. Some
translation systems, such as those which represent plural messages
using ICU's plural syntax, lose the argument number and depending
on the proces
Huh, I must be doing something wrong then in my test implementations because
layouts etc aren't being switched even though images are being swapped when
picking the ar locale. I'll have to investigate deeper into showcase.
Thanks.
On Thu, Mar 31, 2011 at 4:49 PM, Ray Ryan wrote:
> The LayoutPane
On Thu, Mar 31, 2011 at 7:42 PM, Scott Blum wrote:
> On Thu, Mar 31, 2011 at 7:38 PM, Eric Ayers wrote:
>>
>> It was kind of disruptive to pass the suppressErrors setting around
>> through method parameters. I assume that's what you're talking about.
>
> Yeah.
>
>>
>> The good thing about loggin
On Thu, Mar 31, 2011 at 7:38 PM, Eric Ayers wrote:
> It was kind of disruptive to pass the suppressErrors setting around
> through method parameters. I assume that's what you're talking about.
>
Yeah.
> The good thing about logging inside of CompilationStateBuilder is that
> there is a concio
On Thu, Mar 31, 2011 at 6:35 PM, wrote:
>
> http://gwt-code-reviews.appspot.com/1385810/diff/13011/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
> File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):
>
> http://gwt-code-reviews.appspot.com/1385810/diff/13011/dev/core/src/com/goog
LGTM
On Thu, Mar 31, 2011 at 3:40 PM, wrote:
> http://gwt-code-reviews.appspot.com/1394802/
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1394802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1394802/diff/1/reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/TestCreateTableInnerHtml.java
File
reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/TestCreateTableInnerHtml.java
(right):
http://gwt-code-r
http://gwt-code-reviews.appspot.com/1385810/diff/13011/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java
File dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java (right):
http://gwt-code-reviews.appspot.com/1385810/diff/13011/dev/core/src/com/google/gwt/dev/cfg/ModuleDef.java#newcode323
dev/core
Revision: 9922
Author: jlaba...@google.com
Date: Thu Mar 31 15:17:46 2011
Log: Adding Bart Guijt to CLA Signers list. Manual CLA signed and on
file.
http://code.google.com/p/google-web-toolkit/source/detail?r=9922
Modified:
/CLA-SIGNERS
===
-
I found some add'l problems while addressing a couple of Scott's nits.
I wasn't handling writing errors in -strict mode and found that when
running JUnit dev mode tests, one of my changes added even more spam
than before!
JavaToJavaScriptCompiler error reporting is now going through
CompilationP
The LayoutPanels' already swap properly in RTL locales, don't they?
http://gwt.google.com/samples/Showcase/Showcase.html?locale=ar_YE
http://gwt.google.com/samples/Showcase/Showcase.html?locale=en
On Thu, Mar 31, 2011 at 2:33 PM, Jeff Larsen wrote:
> In some instances, it would be nice to have
http://gwt-code-reviews.appspot.com/1394802/diff/1/reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/TestCreateTableInnerHtml.java
File
reference/Microbenchmarks/src/com/google/gwt/reference/microbenchmark/client/TestCreateTableInnerHtml.java
(right):
http://gwt-code-r
In some instances, it would be nice to have LayoutPanel swap left and right.
I was thinking of something like adding a
private boolean bidi = false;
public void setWidgetLeftWidth(Widget child, double left, Unit leftUnit,
double width,
Unit widthUnit) {
assertIsChild(child);
if
As we discussed, looks good if you can document just what "#" resolves
to, why one would use it, and avoid the "inner-most" term.
http://gwt-code-reviews.appspot.com/1385809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
http://gwt-code-reviews.appspot.com/1396803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: fabbott,
Description:
Adds a no-op emulation of TestSuite, to prevent error spam (or outright
failure under -strict mode) in web mode tests that accidentally pick
the things up in their class path.
Please review this at http://gwt-code-reviews.appspot.com/1399803/
Affected files:
Or do I mean that the stack is long? So many metaphors to muddle, so little
time.
On Thu, Mar 31, 2011 at 12:57 PM, Ray Ryan wrote:
> pong. The queue is deep…
>
>
> On Thu, Mar 31, 2011 at 11:42 AM, wrote:
>
>> ping
>>
>>
>> http://gwt-code-reviews.appspot.com/1394802/
>>
>
>
--
http://groups
pong. The queue is deep…
On Thu, Mar 31, 2011 at 11:42 AM, wrote:
> ping
>
>
> http://gwt-code-reviews.appspot.com/1394802/
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Comment by ms.fus...@gmail.com:
Vollara Wants You Come and Join in Too
For more information:
http://code.google.com/p/google-web-toolkit/wiki/IssueReportSample
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
ping
http://gwt-code-reviews.appspot.com/1394802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9921
Author: sco...@google.com
Date: Thu Mar 31 08:40:20 2011
Log: Remove newly-output PersistentUnitCache file if nothing was
written to it.
In the case where you re-run a compile/startup without changing any code,
we produce an empty cache file each time. This change
On 2011/03/31 18:35:21, schenney wrote:
LGTM
http://gwt-code-reviews.appspot.com/1386805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1386805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM
I see how this will defer the cleanup process longer which would be a
good thing if files aren't really changing.
http://gwt-code-reviews.appspot.com/1396804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: zundel,
Message:
In the case where you re-run a compile/startup without changing any
code, we produce an empty cache file each time. This change removes the
file on exit if we never wrote anything to it.
Please review this at http://gwt-code-reviews.appspot.com/1396804/
Affected f
Reviewers: pdr,
Description:
Add the beginnings of new HTML5 drag and drop events
Please review this at http://gwt-code-reviews.appspot.com/1398802/
Affected files:
A user/src/com/google/gwt/event/dom/client/DragEnterClickHandler.java
A user/src/com/google/gwt/event/dom/client/DragEnterEve
Revision: 9920
Author: rchan...@google.com
Date: Thu Mar 31 07:44:28 2011
Log: Cherry picking r9919 into releases/2.3 for public issue 6189
http://code.google.com/p/google-web-toolkit/source/detail?r=9920
Modified:
/releases/2.3/user/src/com/google/gwt/user/tools/WebAppCreator.java
Submitted at r9919
http://gwt-code-reviews.appspot.com/1399801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9919
Author: rchan...@google.com
Date: Thu Mar 31 03:22:04 2011
Log: Reroll of r9908 (rolled back at r9911): Fixes issue 6189.
WebAppCreator was not scanning war/WEB-INF/lib to fill up .classpath
Added support for windows path separator to testCreatorOnlyEclipseWithJars()
Rev
Why bindery package is nested in a web package? Are these APIs not
available for non web applications?
Regards.
- Andrés
On 31 mar, 01:19, rj...@google.com wrote:
> Ready for review. John, can you keep me honest on the treatment of
> com.google.gwt.event.shared, and the choices made in the new ev
32 matches
Mail list logo
