On Mon, Apr 11, 2011 at 17:54, wrote:
>
> Note that the CSS spec talks about using '\(', not '\028'. I however
> have absolutely no idea how well this is supported by browsers.
>
> I think I read somewhere that this doesn't work in IE (which seems to
interpret \ literally in URLs because windows
On 2011/04/11 23:18:13, xtof wrote:
If we're both in agreement on that, I think we should change the doc
of the
SafeUri contract to be a bit more specific about that. I.e., instead
of
18 /**
19 * An object that implements this interface encapsulates a URI
that is
20 * guaranteed t
Revision: 9975
Author: rchan...@google.com
Date: Mon Apr 11 14:26:39 2011
Log: Cherry picking r9973 into releases/2.3 for isuees 4878 and 6196
http://code.google.com/p/google-web-toolkit/source/detail?r=9975
Modified:
/releases/2.3/user/src/com/google/gwt/user/tools/templates/maven/
Reviewers: zundel,
Description:
Clean up the CrossSiteIFrameLoadingStrategy class, removing some dead
code,
adding comments to clarify what is going on, and making it throw an
error
which is more explicit about what triggered the error
Please review this at http://gwt-code-reviews.appspot.com/1
Revision: 9974
Author: rchan...@google.com
Date: Mon Apr 11 13:59:08 2011
Log: Cherry picking r9967 into releases/2.3
http://code.google.com/p/google-web-toolkit/source/detail?r=9974
Modified:
/releases/2.3/samples/expenses/pom.xml
/releases/2.3/user/src/com/google/gwt/user/tools/te
On 2011/04/11 23:17:07, zundel wrote:
I'm thinking about using ByteArrayOutputStream and serializing 2
special object with readObject() implemented to throw the exception I
want to test.
SGTM!
http://gwt-code-reviews.appspot.com/1412801/
--
http://groups.google.com/group/Google-Web-Toolkit-Co
LGTM!
http://gwt-code-reviews.appspot.com/1384801/diff/8001/user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java
File
user/src/com/google/gwt/safehtml/rebind/SafeHtmlTemplatesImplMethodCreator.java
(right):
http://gwt-code-reviews.appspot.com/1384801/diff/8001/user/sr
On Sun, Apr 10, 2011 at 17:02, wrote:
> On 2011/04/10 18:32:38, xtof wrote:
>
>> I think this is pretty much ready, except for one thing I just thought
>>
> of.
>
>> Sorry, I should have thought of that earlier :/
>>
>
> In ClippedImageImpl, we're using a SafeUri in the context of a url()
>>
> s
I'm thinking about using ByteArrayOutputStream and serializing 2
special object with readObject() implemented to throw the exception I
want to test.
On Mon, Apr 11, 2011 at 5:30 PM, wrote:
>
> http://gwt-code-reviews.appspot.com/1412801/diff/1/dev/core/test/com/google/gwt/dev/javac/PersistentUni
Revision: 9973
Author: rchan...@google.com
Date: Mon Apr 11 13:05:14 2011
Log: Fixed pom.xml produced by WebAppCreator. Issue 4878 and Issue
6196.
Review at http://gwt-code-reviews.appspot.com/1407804
Review by: drfibona...@google.com
http://code.google.com/p/google-web-toolkit/sou
http://gwt-code-reviews.appspot.com/1407804/diff/1/user/src/com/google/gwt/user/tools/templates/maven/pom.xmlsrc
File user/src/com/google/gwt/user/tools/templates/maven/pom.xmlsrc
(right):
http://gwt-code-reviews.appspot.com/1407804/diff/1/user/src/com/google/gwt/user/tools/templates/maven/pom.x
http://gwt-code-reviews.appspot.com/1407804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9972
Author: unn...@google.com
Date: Mon Apr 11 11:56:17 2011
Log: make it possible to just use devmode on a particular module while
allowing the
others to run in prod mode
Review at http://gwt-code-reviews.appspot.com/1408802
Review by: fabio...@google.com
http://code.go
http://gwt-code-reviews.appspot.com/1412801/diff/1/dev/core/test/com/google/gwt/dev/javac/PersistentUnitCacheTest.java
File dev/core/test/com/google/gwt/dev/javac/PersistentUnitCacheTest.java
(right):
http://gwt-code-reviews.appspot.com/1412801/diff/1/dev/core/test/com/google/gwt/dev/javac/Persi
Revision: 9971
Author: jlaba...@google.com
Date: Mon Apr 11 09:09:49 2011
Log: Reverting r9970 due to build break.
Review at http://gwt-code-reviews.appspot.com/1408804
Review by: fabb...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9971
Deleted:
/trunk/use
It's always a pleasure to work on GWT: the code is quite clean and easy to
read!
On a related note (to this patch), I was thinking about using CSS3
transitions for animations in widgets, when supported. The only issue is
that there would only be an event fired at the end (ontransitionend). Is i
Reviewers: fabbott,
Description:
Reverting r9970 due to build break.
Please review this at http://gwt-code-reviews.appspot.com/1408804/
Affected files:
M user/src/com/google/gwt/animation/Animation.gwt.xml
M user/src/com/google/gwt/animation/client/Animation.java
D user/src/com/google/gw
committed as r9970
Thanks for another patch!
http://gwt-code-reviews.appspot.com/1355805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 9970
Author: jlaba...@google.com
Date: Mon Apr 11 07:56:01 2011
Log: Adds {moz,webkit}RequestAnimationFrame support to animations.
Refactor Animation with different implementations, adding
mozRequestAnimationFrame and webkitRequestAnimationFrame support in
addition to
the
LGTM
On Mon, Apr 11, 2011 at 11:44 AM, wrote:
>
>
> http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java
> File user/src/com/google/gwt/user/client/ui/DeckPanel.java (right):
>
>
> http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/
http://gwt-code-reviews.appspot.com/1407804/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1412801/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
(right):
http://gwt-code-reviews.appspot.com/1412801/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCa
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java
File user/src/com/google/gwt/user/client/ui/DeckPanel.java (right):
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java#newcode108
u
The symptom of this problem is that after updating GWT, you get the
following exceptions similar to the following:
[WARN] Error reading cache file:
/tmp/me/gwt-unitCache/gwt-unitCache-012F28614915
java.io.InvalidClassException: com.google.gwt.dev.javac.Dependencies;
local class incompatible:
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java
File user/src/com/google/gwt/user/client/ui/DeckPanel.java (right):
http://gwt-code-reviews.appspot.com/1355805/diff/6003/user/src/com/google/gwt/user/client/ui/DeckPanel.java#newcode108
u
Reviewers: tobyr, jbrosenberg,
Description:
Addresses ClassNotFoundException problems when the data structures
serialized in
the unit cache log files no longer matches due to changes in GWT.
Please review this at http://gwt-code-reviews.appspot.com/1412801/
Affected files:
M dev/core/src/com
LGTM
http://gwt-code-reviews.appspot.com/1408802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
27 matches
Mail list logo