I agree there are more opportunities for ordinalization here, as
suggested by Scott (e.g. allow references to $VALUES, or to static
fields/methods on enum instances. I can pursue those further in a
follow-on release.
http://gwt-code-reviews.appspot.com/1428808/diff/1/dev/core/src/com/google/gwt
http://gwt-code-reviews.appspot.com/1428808/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1431801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1431801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hi Thomas -
We considered the more comprehensive fixes (updating SAC, as well as fully
updating the entire tree to better understand CSS3) and decided that we
don't have the resources to do so at this time. So right now, we're looking
to do the bare minimum fix that would allow people to use syn
Rietveld is down atm (giving 500 errors) so i'll comment here:
Le mercredi 4 mai 2011 02:21:56 UTC+2, unnurg a écrit :
>
> Index: user/src/com/google/gwt/resources/css/GenerateCssAst.java
> ===
> --- user/src/com/google/gwt/resources
Reviewers: cromwellian,
Description:
Update the flute jar to accept double colon notation in css selectors,
rename
it to version 2, and use it throughout gwt. Also update the AST
generation code
to output double colons for any pseudo class/element that was is not
supported
with the single colon n
Revision: 10133
Author: rj...@google.com
Date: Tue May 3 12:27:48 2011
Log: Tweak javadoc on LazyDomElement
http://code.google.com/p/google-web-toolkit/source/detail?r=10133
Modified:
/trunk/user/src/com/google/gwt/uibinder/client/LazyDomElement.java
===
Reviewers: jlabanca,
Description:
1. Assert, at runtime, that GWT is running in Standards Mode (i.e. with
an appropriate DOCTYPE declaration), e.g
2. Provide a new configuration property to indicate the required browser
rendering mode, which can be used to
suppress the above Standards Mode requi
Review will continue in http://gwt-code-reviews.appspot.com/1428811
This Issue is too hard to follow.
http://gwt-code-reviews.appspot.com/1422815/diff/1/samples/mobilewebapp/src/dev/com/google/gwt/sample/mobilewebapp/linker/AppCacheLinker.java
File
samples/mobilewebapp/src/dev/com/google/gwt/sa
Reviewers: pdr, tobyr, cramsdale,
Description:
Adds HTML5 App Cache support to MobileWebApp sample.
Uses a custom linker to figure out which files were generated by GWTC.
Please review this at http://gwt-code-reviews.appspot.com/1428811/
Affected files:
A dev/core/src/com/google/gwt/core/lin
Submitted as of r10132
http://gwt-code-reviews.appspot.com/1430802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10131
Author: r...@google.com
Date: Tue May 3 10:35:38 2011
Log: Add a convenience base class for value type locators
Review at http://gwt-code-reviews.appspot.com/1428809
http://code.google.com/p/google-web-toolkit/source/detail?r=10131
Added:
/trunk/user/src/com/googl
LGTM
http://gwt-code-reviews.appspot.com/1430802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Moved MobileWebApp src to src/main in preparation for an HTML5 App Cache
linker
Please review this at http://gwt-code-reviews.appspot.com/1430802/
Affected files:
D samples/mobilewebapp/src/META-INF/jdoconfig.xml
D samples/mobilewebapp/src/META-INF/persistenc
http://gwt-code-reviews.appspot.com/1428808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
File dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer.java
(right):
http://gwt-code-reviews.appspot.com/1428808/diff/1/dev/core/src/com/google/gwt/dev/jjs/impl/EnumOrdinalizer
I mean only super-sourced. Does Object come through as
'com/google/gwt/emul/java/lang/Object.java' or merely
'java/lang/Object.java'?
On Tue, May 3, 2011 at 2:56 PM, wrote:
> On 2011/05/03 18:45:15, scottb wrote:
>
>> LGTM. Like Toby said, this is much better.
>>
>
> Can you confirm that re-r
On 2011/05/03 18:45:15, scottb wrote:
LGTM. Like Toby said, this is much better.
Can you confirm that re-rooted resources retain their original
(non-rerooted)
path location?
What do you mean by re-rooted resources? super sourced resources? One
thing I looked at was that generated resourc
LGTM. Like Toby said, this is much better.
Can you confirm that re-rooted resources retain their original
(non-rerooted) path location?
http://gwt-code-reviews.appspot.com/1428805/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10130
Author: zun...@google.com
Date: Tue May 3 08:35:13 2011
Log: Discards the jar file name in the resource location. It isn't
necessary, and
will cause detritus to build up in the cache if a resource changes from
being
in one jar to another or moves in/out of a .jar
Revision: 10129
Author: her...@google.com
Date: Tue May 3 08:15:07 2011
Log: Promoting LazyDomElement to be used externally. LazyDomElement
can be
used to boost rendering time. Today, html elements marked with
"ui:field" need to call getElementById() by the time the template is
crea
Running ant clean dist-dev test, this appears to break the i18n suite under
html unit.
Testcase: testMessageDateTime took 0.15 sec
FAILED
Remote test failed at 172.31.131.172 / Mozilla/5.0 (Windows; U; Windows NT
5.1; en-US; rv:1.9.0.19) Gecko/2010031422 Firefox/3.0.19
expected=It is Feb 15, 2010
LGTM
On Tue, May 3, 2011 at 9:54 AM, Ray Ryan wrote:
>
>
> On Tue, May 3, 2011 at 9:49 AM, wrote:
>
>>
>>
>> http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java
>> File user/src/com/google/gwt/uibinder/client/LazyDomElement.java
>> (rig
On Tue, May 3, 2011 at 9:49 AM, wrote:
>
>
> http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java
> File user/src/com/google/gwt/uibinder/client/LazyDomElement.java
> (right):
>
>
> http://gwt-code-reviews.appspot.com/1427809/diff/1/user/s
http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java
File user/src/com/google/gwt/uibinder/client/LazyDomElement.java
(right):
http://gwt-code-reviews.appspot.com/1427809/diff/1/user/src/com/google/gwt/uibinder/client/LazyDomElement.java#
Reviewers: rjrjr,
Description:
Fix error in usage of newly-creted helper method in AttachableHTMLPanel,
correct double-calling of wrapElement in exceptional case, and fix the
documentation.
Please review this at http://gwt-code-reviews.appspot.com/1427812/
Affected files:
M user/src/com/goog
LGTM
Thanks, will submit.
On Tue, May 3, 2011 at 2:40 AM, wrote:
> Reviewers: rjrjr, bobv,
>
> Description:
> Force locale to en_US for "user" unit tests
>
> Force locale to en_US for "user" unit tests, otherwise validation tests
> fail (use hard-coded checks on locale-dependent messages)
>
> P
LGTM with one nit fixed. Thanks for the tests.
http://gwt-code-reviews.appspot.com/1427809/diff/1010/user/src/com/google/gwt/uibinder/rebind/model/OwnerField.java
File user/src/com/google/gwt/uibinder/rebind/model/OwnerField.java
(right):
http://gwt-code-reviews.appspot.com/1427809/diff/1010/us
http://gwt-code-reviews.appspot.com/1427809/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2011/05/03 16:11:37, xtof wrote:
http://gwt-code-reviews.appspot.com/1380806/diff/28033/user/src/com/google/gwt/safehtml/shared/SafeUri.java
File user/src/com/google/gwt/safehtml/shared/SafeUri.java (right):
http://gwt-code-reviews.appspot.com/1380806/diff/28033/user/src/com/google/gwt/saf
http://gwt-code-reviews.appspot.com/1380806/diff/28033/user/src/com/google/gwt/safehtml/shared/SafeUri.java
File user/src/com/google/gwt/safehtml/shared/SafeUri.java (right):
http://gwt-code-reviews.appspot.com/1380806/diff/28033/user/src/com/google/gwt/safehtml/shared/SafeUri.java#newcode41
use
http://gwt-code-reviews.appspot.com/1371801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Yes, I thought it was less confusing to start from what was present in
http://gwt-code-reviews.appspot.com/1426803 and then make changes. Makes it
easier to see differences and such.
On Mon, May 2, 2011 at 7:03 PM, Ray Ryan wrote:
> This still appears to have all the problems of
> http://gwt-cod
Thanks!
On Mon, May 2, 2011 at 6:19 PM, wrote:
> Hey there Rodrigo. Unnur is on point for this review, but you might find
> it interesting.
>
>
> http://gwt-code-reviews.appspot.com/1421811/
>
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr, bobv,
Description:
Force locale to en_US for "user" unit tests
Force locale to en_US for "user" unit tests, otherwise validation tests
fail (use hard-coded checks on locale-dependent messages)
Please review this at http://gwt-code-reviews.appspot.com/1430801/
Affected files:
http://gwt-code-reviews.appspot.com/1401802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
36 matches
Mail list logo
