On Wednesday, May 4, 2011 4:02:36 PM UTC+2, Ray Ryan wrote:
This is probably html unit honoring the locale and changing its behavior
from what the tests expect.
What I don't understand is that the tests are actually exercising
DateTimeFormat, which is completely emulated and controlled,
On 2011/05/03 03:05:57, jlabanca wrote:
Lots of nits, but looks pretty good overall. I haven't tried it out
yet, but
it'll be a big improvement over truncating excess tabs.
Test cases would also be much appreciated.
http://gwt-code-reviews.appspot.com/1403801/diff/1/user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java
File user/src/com/google/gwt/user/client/ui/TabLayoutPanel.java (right):
http://gwt-code-reviews.appspot.com/1427807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: hermes,
Description:
Give the UiBinder safehtml warning once per compile.
Review by: her...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1434801/
Affected files:
M user/src/com/google/gwt/uibinder/rebind/UiBinderGenerator.java
Index:
http://gwt-code-reviews.appspot.com/1434801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1427807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10143
Author: gwt.mirror...@gmail.com
Date: Thu May 5 11:56:28 2011
Log: Add runtime-locale support for Localizable subtypes.
This is a prerequisitive for later work moving things from being generated
at compile-time to being mostly pre-generated during the CLDR import
Revision: 10144
Author: rj...@google.com
Date: Thu May 5 08:02:23 2011
Log: Normalize test for ie
http://code.google.com/p/google-web-toolkit/source/detail?r=10144
Modified:
/trunk/user/test/com/google/gwt/uibinder/test/client/SafeHtmlAsComponentsTest.java
LGTM
http://gwt-code-reviews.appspot.com/1427807/diff/10002/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):
Revision: 10145
Author: unn...@google.com
Date: Thu May 5 08:11:08 2011
Log: Update the flute jar to accept double colon notation in css
selectors, rename
it to version 2, and use it throughout gwt.
Review at http://gwt-code-reviews.appspot.com/1431801
Review by:
Revision: 10146
Author: j...@google.com
Date: Thu May 5 08:31:56 2011
Log: Chrome 11 mangles more Unicode characters, so we quote them.
Review by: sbruba...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10146
Modified:
Reviewers: zundel,
Message:
This is causing PersistentUnitCache to never re-use generated types.
The deserialized ContentId hashCodes don't match the in-memory ContentId
hashCodes because getClass().hashCode() isn't stable across VM
instances.
Please review this at
Revision: 10147
Author: rj...@google.com
Date: Thu May 5 09:42:56 2011
Log: Give the UiBinder safehtml warning once per compile.
Review at http://gwt-code-reviews.appspot.com/1434801
Review by: her...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10147
http://gwt-code-reviews.appspot.com/1427807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jat,
Description:
Works around a Sun javac bug which presents as:
user/src/com/google/gwt/uibinder/client/LazyDomElement.java:68: type
parameters of T cannot be determined; no unique maximal instance exists
for type variable T with upper bounds
LGTM
Thanks for looking into this. I noticed them not being re-used on
startup but I thought that had something to do with a need to coordinate
with the code enabled by -XenableGeneratorResultCaching and hadn't
looked into it yet.
On 2011/05/05 19:27:28, scottb wrote:
This is causing
Reviewers: rjrjr,
Description:
AttachableHTMLPanel.logicalAdd() should receive an Attachable instead of
a Widget.
Please review this at http://gwt-code-reviews.appspot.com/1434802/
Affected files:
M user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
Index:
Revision: 10148
Author: rj...@google.com
Date: Thu May 5 10:27:21 2011
Log: Works around a Sun javac bug which presents as:
user/src/com/google/gwt/uibinder/client/LazyDomElement.java:68: type
parameters of T cannot be determined; no unique maximal instance exists for
type
Reviewers: jbrosenberg,
Message:
I've abandoned the overrides work for now, run into too many walls, but
I did want to get in some work I did, including a speedup to
MethodCallTightener.
Please review this at http://gwt-code-reviews.appspot.com/1436801/
Affected files:
M
Reviewers: rjrjr,
Description:
Make AttachableComposite delegate setStyleName to the wrapped Widget.
Please review this at http://gwt-code-reviews.appspot.com/1433802/
Affected files:
M user/src/com/google/gwt/user/client/ui/AttachableComposite.java
Index:
http://gwt-code-reviews.appspot.com/1433801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ready for another look.
OrientationMonitor is replaced with OrientationHelper. John, I think
I've stumbled onto a pretty nice widget plugin pattern there. I was able
to delete the superclass for the shells without adding much boilerplate
or copy/paste. What do you think?
Notice that I've snuck
LGTM
http://gwt-code-reviews.appspot.com/1433802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10149
Author: sco...@google.com
Date: Thu May 5 10:51:52 2011
Log: StringKey hashCode inconsistent across VMs.
This is causing PersistentUnitCache to never re-use generated types. The
deserialized ContentId hashCodes don't match the in-memory ContentId
hashCodes
http://gwt-code-reviews.appspot.com/1434802/diff/1/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
File user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
(right):
Reviewers: cramsdale, rjrjr,
Description:
Eclipse configuration for MobileWebApp.
Relies on AppEngine and GPE
README.txt instructions updated to help setting up Eclipse in this case
Please review this at http://gwt-code-reviews.appspot.com/1437801/
Affected files:
A
http://gwt-code-reviews.appspot.com/1434802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks, Ray. Another look?
http://gwt-code-reviews.appspot.com/1434802/diff/1/user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
File user/src/com/google/gwt/user/client/ui/AttachableHTMLPanel.java
(right):
Reviewers: rchandia,
Description:
Mark all validaiton classes as Experimental
Please review this at http://gwt-code-reviews.appspot.com/1432803/
Affected files:
M
user/src/com/google/gwt/validation/client/AbstractGwtValidatorFactory.java
M
Rietveld is choking on this.
The non-eclipse instructions in the README.txt are wrong, aren't they? ant
war can't work because
of the missing appengine jars. Shouldn't we be saying that the sample
is configured to assume you're using GPE?
On Thu, May 5, 2011 at 2:59 PM, rchan...@google.com
LGTM
http://gwt-code-reviews.appspot.com/1434802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Rodrigo, it looks like John is on vacation for the rest of the week. Can you
finish this review?
On Thu, May 5, 2011 at 2:24 PM, rj...@google.com wrote:
Ready for another look.
OrientationMonitor is replaced with OrientationHelper. John, I think
I've stumbled onto a pretty nice widget plugin
Revision: 10150
Author: unn...@google.com
Date: Thu May 5 15:41:39 2011
Log: Adding .jar that should have been included in r10145
http://code.google.com/p/google-web-toolkit/source/detail?r=10150
Added:
/tools/lib/w3c/flute/flute-1.3-gg2.jar
===
http://gwt-code-reviews.appspot.com/1433801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1433801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10152
Author: gwt.mirror...@gmail.com
Date: Thu May 5 12:19:19 2011
Log: Make AttachableComposite delegate setStyleName to the wrapped
Widget.
Review at http://gwt-code-reviews.appspot.com/1433802
Lack of this is making templates that set the style of
Revision: 10153
Author: rdcas...@google.com
Date: Thu May 5 12:43:07 2011
Log: AttachableHTMLPanel.logicalAdd() should receive an Attachable
instead of a Widget.
Review at http://gwt-code-reviews.appspot.com/1434802
Review by: rj...@google.com
Reviewers: cromwellian, zundel, jbrosenberg,
Message:
I know this feels a little hacky, but I tracked down most of the sources
of Pruner jitter that's causing it to run more than once.
1) Instance fields needed to be treated like method and put into limbo
until their enclosing type is
Actually, don't review this yet, I meant to just update the description
rather than send an email out.
http://gwt-code-reviews.appspot.com/1436802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I have a method that takes a DataResource as a parameter and I want to
force all incoming DataResources to have the @DoNotEmbed annotation,
just like ResourcePrototype (Which all Resources, such as
DataResource, extend) forces the @Source annotation.
Can anyone help me understand how to do this?
41 matches
Mail list logo
