Reviewers: rjrjr,
Description:
Experimental attempt to add EventBus support to Widgets
Modify the MobileWebApp sample to use the new feature
Please review this at http://gwt-code-reviews.appspot.com/1447804/
Affected files:
M
samples/mobilewebapp/src/main/com/google/gwt/sample/mobilewebapp
Revision: 10181
Author: gwt.mirror...@gmail.com
Date: Thu May 12 17:18:09 2011
Log: Fix checkstyle 'info' warnings
Review at http://gwt-code-reviews.appspot.com/1446803
Review by: rj...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10181
Modified:
/trunk/dev
LGTM
On Thu, May 12, 2011 at 4:25 PM, wrote:
> Reviewers: rjrjr,
>
> Description:
> Fix checkstyle 'info' warnings
>
>
> Please review this at http://gwt-code-reviews.appspot.com/1446803/
>
> Affected files:
> M dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
> M dev/core/src
Reviewers: rjrjr,
Description:
Fix checkstyle 'info' warnings
Please review this at http://gwt-code-reviews.appspot.com/1446803/
Affected files:
M dev/core/src/com/google/gwt/core/linker/SimpleAppCacheLinker.java
M dev/core/src/com/google/gwt/dev/javac/CompilationProblemReporter.java
M d
SGTM. At some point I'll have to deal with versioning for the embedded GWT
ASTs, but I can burn that bridge when I come to it.
On Thu, May 12, 2011 at 6:48 PM, wrote:
> I know the paint is still drying on the last patch I submitted for the
> Persistent Unit Cache, but no real problems have been
http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java
File user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java
(right):
http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.ja
I know the paint is still drying on the last patch I submitted for the
Persistent Unit Cache, but no real problems have been reported in...
weeks! I think its ready to be on by default.
http://gwt-code-reviews.appspot.com/1448801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributor
Reviewers: tobyr, scottb, jbrosenberg,
Description:
Enables on the persistent unit cache by default.
Please review this at http://gwt-code-reviews.appspot.com/1448801/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/UnitCacheFactory.java
Index: dev/core/src/com/google/gwt/dev/javac
http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java
File user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.java
(right):
http://gwt-code-reviews.appspot.com/1441804/diff/1/user/test/com/google/gwt/user/client/rpc/LoggingRPCTest.ja
Reviewers: unnurg,
Description:
Adding additional testing for GWT RPC. Some custom serialized objects
were previously untested, at least explicitly. Testing put in
place now provides coverage to test future changes.
Please review this at http://gwt-code-reviews.appspot.com/1441804/
Affected fi
Revision: 10180
Author: zun...@google.com
Date: Thu May 12 10:40:46 2011
Log: Rescues cached entries from jar files that are the same, save for
the timestamp.
Also updates the key value used for the cache to include the prefix for
RerootedResource
instances.
Review at http://gwt-c
Revision: 10179
Author: sco...@google.com
Date: Thu May 12 10:09:08 2011
Log: Misc gwtc cleanups.
http://gwt-code-reviews.appspot.com/1446802/
Review by: zun...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=10179
Modified:
/trunk/dev/core/src/com/google/gw
LGTM w/nits, no need to re-review.
http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1441803/diff/3010/dev/core
LGTM
http://gwt-code-reviews.appspot.com/1446802/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1441803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Hmmm - that link doesn't work for me - did this issue get reverted?
On Wed, May 11, 2011 at 1:02 PM, wrote:
> Reviewers: unnurg,
>
> Description:
> Removing the recently added RPC test for LogRecord, as it seems to
> cause more problems than it is worth.
>
>
> Please review this at http://gwt-co
I had to drag Alex into this. I thought I'd move the process along by
mass formatting from eclipse UI on the package or project level, but
that also skips our GWT specific tweaks.
On Thu, May 12, 2011 at 12:24 PM, wrote:
>
> http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/goog
http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java
File
user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java
(right):
http://gwt-code-reviews.appspot.com
http://gwt-code-reviews.appspot.com/1442805/diff/1/user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java
File
user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java
(right):
http://gwt-code-reviews.appspot.com
Reviewers: rjrjr, scottb,
Description:
Autoformats user/super and user/test-super
Please review this at http://gwt-code-reviews.appspot.com/1442805/
Affected files:
M
user/super/com/google/gwt/benchmarks/translatable/com/google/gwt/benchmarks/client/Benchmark.java
M
user/super/com/goog
http://gwt-code-reviews.appspot.com/1441803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
21 matches
Mail list logo