[gwt-contrib] [google-web-toolkit] r10195 committed - Fix some warnings.

2011-05-19 Thread codesite-noreply
Revision: 10195 Author: rj...@google.com Date: Thu May 19 03:45:45 2011 Log: Fix some warnings. http://code.google.com/p/google-web-toolkit/source/detail?r=10195 Added: /trunk/user/src/com/google/gwt/cell/client/ImageResourceRenderer.java Modified: /trunk/user/src/com/google/gwt/cel

[gwt-contrib] Re: Adds a ui:safehtml tag to UiBinder (issue1422812)

2011-05-19 Thread sbrubaker
http://gwt-code-reviews.appspot.com/1422812/diff/1/user/src/com/google/gwt/uibinder/elementparsers/ComputedAttributeInterpreter.java File user/src/com/google/gwt/uibinder/elementparsers/ComputedAttributeInterpreter.java (right): http://gwt-code-reviews.appspot.com/1422812/diff/1/user/src/com/goo

[gwt-contrib] Re: Adds a ui:safehtml tag to UiBinder (issue1422812)

2011-05-19 Thread sbrubaker
http://gwt-code-reviews.appspot.com/1422812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Updating CellTable doc. (issue1442808)

2011-05-19 Thread jlabanca
Reviewers: rchandia, Description: Updating CellTable doc. Please review this at http://gwt-code-reviews.appspot.com/1442808/ Affected files: M user/javadoc/com/google/gwt/examples/cellview/CellTableFieldUpdaterExample.java A user/javadoc/com/google/gwt/examples/cellview/CellTableFieldU

[gwt-contrib] Re: Updating CellTable doc. (issue1442808)

2011-05-19 Thread rchandia
LGTM On 2011/05/19 19:17:01, jlabanca wrote: http://gwt-code-reviews.appspot.com/1442808/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Facilitate implementations of EventBus in other packages (issue1443804)

2011-05-19 Thread stephen . haberman
Reviewers: rjrjr, Description: Adds two protected static methods to EventBus that expose otherwise inaccessible methods on Event (setSource and dispatch) to subclasses of EventBus. This is not a huge deal to me, but, in general, it would be nice to move my EventBus implementation out of a c.g pa

[gwt-contrib] [google-web-toolkit] r10197 committed - Updating CellTable doc....

2011-05-19 Thread codesite-noreply
Revision: 10197 Author: jlaba...@google.com Date: Thu May 19 09:54:26 2011 Log: Updating CellTable doc. Review at http://gwt-code-reviews.appspot.com/1442808 Review by: rchan...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10197 Added: /trunk/user/javadoc

[gwt-contrib] Better home for ImageResourceRenderer (issue1446807)

2011-05-19 Thread rjrjr
Reviewers: robertvawter, jlabanca, Description: Better home for ImageResourceRenderer Please review this at http://gwt-code-reviews.appspot.com/1446807/ Affected files: M user/src/com/google/gwt/cell/client/ImageResourceCell.java D user/src/com/google/gwt/cell/client/ImageResourceRenderer.

[gwt-contrib] Re: Better home for ImageResourceRenderer (issue1446807)

2011-05-19 Thread rjrjr
Bob, are you okay with this in gwt/resources/client? http://gwt-code-reviews.appspot.com/1446807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10198 committed - Improving the user experience and fixing some bugs....

2011-05-19 Thread codesite-noreply
Revision: 10198 Author: brianp...@google.com Date: Thu May 19 11:23:57 2011 Log: Improving the user experience and fixing some bugs. Review by: jlaba...@google.com http://code.google.com/p/google-web-toolkit/source/detail?r=10198 Modified: /trunk/user/src/com/google/gwt/touch/client/

[gwt-contrib] Re: Better home for ImageResourceRenderer (issue1446807)

2011-05-19 Thread jlabanca
http://gwt-code-reviews.appspot.com/1446807/diff/1/user/src/com/google/gwt/resources/client/ImageResourceRenderer.java File user/src/com/google/gwt/resources/client/ImageResourceRenderer.java (right): http://gwt-code-reviews.appspot.com/1446807/diff/1/user/src/com/google/gwt/resources/client/Ima

[gwt-contrib] Re: Better home for ImageResourceRenderer (issue1446807)

2011-05-19 Thread Ray Ryan
I was wondering if we should move the code from abstract image prototype here, make it depend on the renderer. Deferred binding and all. What do you think? On May 19, 2011 9:41 PM, wrote: > > http://gwt-code-reviews.appspot.com/1446807/diff/1/user/src/com/google/gwt/resources/client/ImageResourceR