[gwt-contrib] Re: Adds ability to query the generator context whether a rebind rule exists for a given type (issue1450806)

2011-05-27 Thread scottb
LGTM http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/dev/javac/rebind/RebindRuleResolver.java File dev/core/src/com/google/gwt/dev/javac/rebind/RebindRuleResolver.java (right): http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/dev/java

[gwt-contrib] Re: Adds ability to query the generator context whether a rebind rule exists for a given type (issue1450806)

2011-05-27 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/core/ext/GeneratorContext.java File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right): http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/core/ext/GeneratorContext.java#new

[gwt-contrib] Re: Adds ability to query the generator context whether a rebind rule exists for a given type (issue1450806)

2011-05-27 Thread jbrosenberg
http://gwt-code-reviews.appspot.com/1450806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on CellBackedWIdgets in google-web-toolkit

2011-05-27 Thread codesite-noreply
Comment by nix...@gmail.com: set.Look&Feel(soGood) For more information: http://code.google.com/p/google-web-toolkit/wiki/CellBackedWIdgets -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Comment on LightweightCollections in google-web-toolkit

2011-05-27 Thread codesite-noreply
Comment by spoon.re...@gmail.com: The containsKey(), get(), and remove() methods for Map and MutableMap should take type Object and not K (same as the Java Map interface). The reason is that it is possible for objects of different classes to be .equals() (e.g. all implementations of java.ut

[gwt-contrib] Re: Upgrading DynaTableRf and MobileWebApp to use DataGrid. The apps look identical, except that scr... (issue1452803)

2011-05-27 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1452803/diff/1/samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/DataGridPatch.css File samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/DataGridPatch.css (right): http://gwt-code-reviews.appspot.com/1452803

[gwt-contrib] Re: Fix warnings in samples/expenses (issue1447810)

2011-05-27 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1447810/diff/1/samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java File samples/expenses/src/main/java/com/google/gwt/sample/expenses/client/ExpenseReportDetails.java (left): http://gwt-code-reviews.appspot.com/

[gwt-contrib] [google-web-toolkit] r10241 committed - bump gae version

2011-05-27 Thread codesite-noreply
Revision: 10241 Author: rj...@google.com Date: Fri May 27 07:47:34 2011 Log: bump gae version http://code.google.com/p/google-web-toolkit/source/detail?r=10241 Modified: /trunk/samples/expenses/pom.xml === --- /trunk/samples/expenses/pom.xml F

[gwt-contrib] Fix warnings in samples/expenses (issue1447810)

2011-05-27 Thread rjrjr
Reviewers: jlabanca, Description: Fix warnings in samples/expenses Please review this at http://gwt-code-reviews.appspot.com/1447810/ Affected files: M samples/expenses/pom.xml M samples/expenses/src/main/java/com/google/gwt/mobile/client/TouchHandler.java M samples/expenses/src/main

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread Scott Blum
The compiler internals could be coded to use binary names. Obviously, generators would do something sensible. For example, I know that rebind rules in gwt.xml are tracked by source name. Well, those could get looked up in TypeOracle and translated to the appropriate binary name and tracked that

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread John Tamplin
On Fri, May 27, 2011 at 12:53 PM, Scott Blum wrote: > On Fri, May 27, 2011 at 10:12 AM, John Tamplin wrote: > >> I don't think that solves the problem -- let's say we store Foo/Bar$Baz >> internally and convert it to a source name where needed. How do we know >> whether the class name is Bar$Ba

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread Scott Blum
On Fri, May 27, 2011 at 10:12 AM, John Tamplin wrote: > I don't think that solves the problem -- let's say we store Foo/Bar$Baz > internally and convert it to a source name where needed. How do we know > whether the class name is Bar$Baz or Baz inside of Bar? The problem is > simply if you allo

[gwt-contrib] Re: Adding a couple of useful methods to AbstractCellTable. getColumnWidth() can be used to access ... (issue1453801)

2011-05-27 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/1453801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add RequestContext.find() to support chained requests. (issue1448806)

2011-05-27 Thread Ray Ryan
LGTM On Fri, May 27, 2011 at 7:38 AM, wrote: > The base interface for RequestFactory service endpoints. >> Add disclaimer explaining that this interface (and the others) are >> > normally > >> implemented by generated code, and are subject to incompatible >> > updates? > > Done. Also added a F

[gwt-contrib] Added -XdisableSoycHtml command line flag for disabling HTML compile report generation. This wil... (issue1450807)

2011-05-27 Thread dconnelly
Reviewers: zundel, Description: Added -XdisableSoycHtml command line flag for disabling HTML compile report generation. This will not affect SOYC XML output. Please review this at http://gwt-code-reviews.appspot.com/1450807/ Affected files: M dev/core/src/com/google/gwt/dev/PrecompileTaskArg

[gwt-contrib] Updates to dashboard interface so we're passing wall-clock time millis instead of normalized nan... (issue1449807)

2011-05-27 Thread jhumphries
Reviewers: tobyr, Description: Updates to dashboard interface so we're passing wall-clock time millis instead of normalized nanos. This is required to tie an event back to actual date and time it occurred. Please review this at http://gwt-code-reviews.appspot.com/1449807/ Affected files: M

[gwt-contrib] [google-web-toolkit] r10239 committed - Add RequestContext.find() to support chained requests....

2011-05-27 Thread codesite-noreply
Revision: 10239 Author: gwt.mirror...@gmail.com Date: Fri May 27 05:11:13 2011 Log: Add RequestContext.find() to support chained requests. Patch by: bobv Review by: rjrjr Review at http://gwt-code-reviews.appspot.com/1448806 http://code.google.com/p/google-web-toolkit/source/detail?r=

[gwt-contrib] [google-web-toolkit] r10238 committed - Add BatchedRequestScope utility class to aggregate all requests made w...

2011-05-27 Thread codesite-noreply
Revision: 10238 Author: b...@google.com Date: Fri May 27 04:59:21 2011 Log: Add BatchedRequestScope utility class to aggregate all requests made within a single tick of the event loop. Add FanoutReceiver utility class. Remove redundant tests from RequestFactoryGwtJreSuite. Patch by:

Re: [gwt-contrib] Re: Creating a default Locator for RequestFactoryServlet

2011-05-27 Thread BobV
On Thu, May 26, 2011 at 2:23 PM, Thomas Broyer wrote: > How about simply using a ServiceLayerDecorator that overrides > resolveLocator, delegating to super.resolveLocator and, if it returns null > then return the "default locator" instead? +1 The ServiceLayer design is intended to cut down on th

[gwt-contrib] [google-web-toolkit] r10237 committed - Revive samples/expenses from its 2.3 breakage. Also now generates...

2011-05-27 Thread codesite-noreply
Revision: 10237 Author: rj...@google.com Date: Fri May 27 03:54:00 2011 Log: Revive samples/expenses from its 2.3 breakage. Also now generates sample data on demand. Review at http://gwt-code-reviews.appspot.com/1447809 Review by: jlaba...@google.com http://code.google.com/p/google-we

[gwt-contrib] Re: Add RequestContext.find() to support chained requests. (issue1448806)

2011-05-27 Thread bobv
The base interface for RequestFactory service endpoints. Add disclaimer explaining that this interface (and the others) are normally implemented by generated code, and are subject to incompatible updates? Done. Also added a FakeRequestContext base type in a testing subpackage. And should lo

[gwt-contrib] Adding a couple of useful methods to AbstractCellTable. getColumnWidth() can be used to access ... (issue1453801)

2011-05-27 Thread jlabanca
Reviewers: jlabanca, Description: Adding a couple of useful methods to AbstractCellTable. getColumnWidth() can be used to access the width of a column set using setColumnWidth(). flush() will immediately flush pending changes into the view. Please review this at http://gwt-code-reviews.appspot

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

2011-05-27 Thread jlabanca
http://gwt-code-reviews.appspot.com/1446812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread John Tamplin
On Fri, May 27, 2011 at 10:03 AM, Scott Blum wrote: > What John said. Blame Java for the fact that with some lookup oracle, it's > impossible to distinguish the cases. We've always assumed that users would > not use '$' in class names in places where it matters. > > That being said, let's assum

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

2011-05-27 Thread t . broyer
http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/test/com/google/gwt/animation/AnimationTest.gwt.xml File user/test/com/google/gwt/animation/AnimationTest.gwt.xml (right): http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/test/com/google/gwt/animation/AnimationTest.gwt.xml#new

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread Scott Blum
What John said. Blame Java for the fact that with some lookup oracle, it's impossible to distinguish the cases. We've always assumed that users would not use '$' in class names in places where it matters. That being said, let's assume that a user isn't allowed to have both A.B and A$B like Toby

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread John Tamplin
On Fri, May 27, 2011 at 4:45 AM, Grzegorz Kossakowski < grzegorz.kossakow...@gmail.com> wrote: > 2011/5/26 Eric Ayers : > > Unfortunately, I tried removing the replace('$',".") and it failed > > miserably. Looking at it in the debugger, those really are binary names. > > e.g.: > > com.google.gwt.

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

2011-05-27 Thread jlabanca
http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/src/com/google/gwt/animation/client/AnimationSchedulerImplMozilla.java File user/src/com/google/gwt/animation/client/AnimationSchedulerImplMozilla.java (right): http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/src/com/google/gw

[gwt-contrib] [google-web-toolkit] r10234 committed - Removes CompileModule.java, retaining the unit test that depends on it...

2011-05-27 Thread codesite-noreply
Revision: 10234 Author: zun...@google.com Date: Thu May 26 14:28:35 2011 Log: Removes CompileModule.java, retaining the unit test that depends on it. Review at http://gwt-code-reviews.appspot.com/1449806 http://code.google.com/p/google-web-toolkit/source/detail?r=10234 Added: /tr

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

2011-05-27 Thread jlabanca
http://gwt-code-reviews.appspot.com/1446812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10232 committed - AutoboxUtils cleanup...

2011-05-27 Thread codesite-noreply
Revision: 10232 Author: sco...@google.com Date: Thu May 26 09:20:48 2011 Log: AutoboxUtils cleanup http://gwt-code-reviews.appspot.com/1443808/ http://code.google.com/p/google-web-toolkit/source/detail?r=10232 Modified: /trunk/dev/core/src/com/google/gwt/dev/javac/testing/impl/Jav

[gwt-contrib] Re: Adds ability to query the generator context whether a rebind rule exists for a given type (issue1450806)

2011-05-27 Thread scottb
LGTM w/ nit & question. http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/core/ext/GeneratorContext.java File dev/core/src/com/google/gwt/core/ext/GeneratorContext.java (right): http://gwt-code-reviews.appspot.com/1450806/diff/1/dev/core/src/com/google/gwt/core/ext/

[gwt-contrib] [google-web-toolkit] r10230 committed - A mechanical refactoring of the Precompile options as prep for further...

2011-05-27 Thread codesite-noreply
Revision: 10230 Author: zun...@google.com Date: Thu May 26 07:33:13 2011 Log: A mechanical refactoring of the Precompile options as prep for further cleanup. Added @Override annotations to satisfy the IDE warnings with Java 1.6 enabled. Review at http://gwt-code-reviews.appspot.co

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

2011-05-27 Thread t . broyer
http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/src/com/google/gwt/animation/client/AnimationSchedulerImplMozilla.java File user/src/com/google/gwt/animation/client/AnimationSchedulerImplMozilla.java (right): http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/src/com/google/gw

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

2011-05-27 Thread jlabanca
Thanks for the detailed review! @fabbott - This change is ready for your final review. http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/src/com/google/gwt/animation/client/AnimationSchedulerImpl.java File user/src/com/google/gwt/animation/client/AnimationSchedulerImpl.java (right):

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

2011-05-27 Thread jlabanca
http://gwt-code-reviews.appspot.com/1446812/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Resubmitting r9970 again (again) - updating Animation to use the native requestAnimationFrame, w... (issue1446812)

2011-05-27 Thread t . broyer
I'll let fabbott continue the review, unless you have remarks on my comments. http://gwt-code-reviews.appspot.com/1446812/diff/3002/user/src/com/google/gwt/animation/client/AnimationSchedulerImpl.java File user/src/com/google/gwt/animation/client/AnimationSchedulerImpl.java (right): http://gwt-

[gwt-contrib] [google-web-toolkit] r10235 committed - Added a bit of documentation on JType

2011-05-27 Thread codesite-noreply
Revision: 10235 Author: zun...@google.com Date: Thu May 26 15:44:32 2011 Log: Added a bit of documentation on JType http://code.google.com/p/google-web-toolkit/source/detail?r=10235 Modified: /trunk/dev/core/src/com/google/gwt/dev/jjs/ast/JType.java =

Re: [gwt-contrib] Dollar sign and binary types

2011-05-27 Thread Grzegorz Kossakowski
2011/5/26 Eric Ayers : > Unfortunately, I tried removing the replace('$',".") and it failed > miserably.  Looking at it in the debugger, those really are binary names. > e.g.: > com.google.gwt.core.client.impl.AsyncFragmentLoader$LoadingStrategy Thanks guys for you answers. I moved on with my work

[gwt-contrib] UnifyAst (issue1451804)

2011-05-27 Thread scottb
Reviewers: zundel, jbrosenberg, Description: Unify the AST produced by GwtAstBuilder. This isn't ready to switch on yet, but I can pass all our tests now, so it seemed like a good checkpoint. Please review this at http://gwt-code-reviews.appspot.com/1451804/ Affected files: M dev/core/src/co