Reviewers: rchandia,
Description:
Add test for builtin constraints
[JSR 303 TCK Result] 138 of 257 (53.70%) Pass with 11 Failures and 7
Errors.
Please review this at http://gwt-code-reviews.appspot.com/1458801/
Affected files:
A
user/test-super/org/hibernate/jsr303/tck/super/org/hibernate/
After consulting with Toby, I'm going to rework this patch, to try to
only use the strong hash as a fallback, if no timestamp info is
available. Try to take advantage of CompilationUnit.getLastModified()
http://gwt-code-reviews.appspot.com/1446818/
--
http://groups.google.com/group/Google-Web-T
http://gwt-code-reviews.appspot.com/1449817/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ready for review.
I apologize for the size of this patch, but very little of it makes
sense in isolation.
http://gwt-code-reviews.appspot.com/1449817/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jlabanca, rchandia, rice, jaimeyap,
Description:
Adds hooks to Widget reduce MVP boilerplate and enshrines the app-wide
EventBus.
Also simplifies the custom event set used in the sample app,
demonstrating how a
single custom ActionEvent could cover most cases. And backs away from
the
s
lgtm
http://gwt-code-reviews.appspot.com/1450815/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
(right):
http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCa
http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
(right):
http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCa
Reviewers: zundel,
http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java
(right):
http://gwt-code-reviews.appspot.com/1450816/diff/1/dev/core/src/com/google/gwt/dev/ja
Revision: 10329
Author: sco...@google.com
Date: Mon Jun 13 13:06:50 2011
Log: Allow binary-only references for compile-time constants.
Like we do for binary-only annotations, this change allows binary-only
references for compile-time constants. We don't actually need source in
the
LGTM
On Jun 13, 2011 6:04 PM, wrote:
>
>
http://gwt-code-reviews.appspot.com/1447825/diff/1/dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java
> File
>
dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java
> (right):
>
>
http://gwt-code-re
Revision: 10328
Author: sco...@google.com
Date: Mon Jun 13 12:05:05 2011
Log: Fix enum switch construction in GwtAstBuilder.
The existing code breaks on switch(Integer), it tries to tack an ordinal()
call on the end of the unbox.
http://gwt-code-reviews.appspot.com/1450815/
Review
http://gwt-code-reviews.appspot.com/1447825/diff/1/dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java
File
dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java
(right):
http://gwt-code-reviews.appspot.com/1447825/diff/1/dev/core/src/com
LGTM
http://gwt-code-reviews.appspot.com/1446818/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1447825/diff/1/dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java
File
dev/core/src/com/google/gwt/dev/javac/BinaryTypeReferenceRestrictionsChecker.java
(right):
http://gwt-code-reviews.appspot.com/1447825/diff/1/dev/core/src/com
lgtm
http://gwt-code-reviews.appspot.com/1450815/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1453813/diff/1/user/src/com/google/web/bindery/requestfactory/server/Resolver.java
File user/src/com/google/web/bindery/requestfactory/server/Resolver.java
(right):
http://gwt-code-reviews.appspot.com/1453813/diff/1/user/src/com/google/web/bindery/requestfacto
Reviewers: zundel, jbrosenberg,
Description:
The existing code breaks on switch(Integer), it tries to tack an
ordinal() call on the end of the unbox.
Please review this at http://gwt-code-reviews.appspot.com/1450815/
Affected files:
M dev/core/src/com/google/gwt/dev/jjs/impl/GwtAstBuilder.jav
I didn't look thoroughly at the changes but I like the overall changes
(wait 'til all invocations are processed to resolve properties +
splitting property resolving and client peer construction), and as long
as the tests are green… ;-)
http://gwt-code-reviews.appspot.com/1453813/diff/1/user/src/
On 2011/06/13 18:33:24, zundel wrote:
chages vs. http://gwt-code-reviews.appspot.com/1453809/ include just
a few unit tests.
http://gwt-code-reviews.appspot.com/1447824/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr, tbroyer,
Message:
Review requested.
The path-processing code and creating client peers for domain objects
are really orthogonal concerns, so I've split that code up. With this
approach, re-resolving the properties on a proxy is no longer a special
case.
I re-used the tests fr
Revision: 10327
Author: gwt.mirror...@gmail.com
Date: Mon Jun 13 12:47:05 2011
Log: Add JSO inspection support.
IDEs can use this class to implement JSO inspection capabilities in their
debug view.
Review at http://gwt-code-reviews.appspot.com/1454807
http://code.google.com/p/goog
Reviewers: zundel,
Description:
Like we do for binary-only annotations, this change allows binary-only
references for compile-time constants. We don't actually need source in
the GWT compiler, JDT embeds the constant value in the unit we do
compile.
Please review this at http://gwt-code-reviews
http://gwt-code-reviews.appspot.com/1447821/diff/3001/dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
File dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
(right):
http://gwt-code-reviews.appspot.com/1447821/diff/3001/dev/core/src/com/google/gwt/dev/jjs/impl/Fragm
http://gwt-code-reviews.appspot.com/1447824/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1447824/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: jbrosenberg,
Description:
Fix handling of unlabeled break and continue in gflow.
This fixes issues:
http://code.google.com/p/google-web-toolkit/issues/detail?id=6272
http://code.google.com/p/google-web-toolkit/issues/detail?id=6429
(was issue 1453809)
Please review this at http:/
Revision: 10326
Author: zun...@google.com
Date: Mon Jun 13 07:52:03 2011
Log: Decreased the log level on a message relating to "purging" the
cache.
In this case, no data is lost, its just a normal cleanup job.
Review at http://gwt-code-reviews.appspot.com/1447823
Review by: fabb...
LGTM
http://gwt-code-reviews.appspot.com/1447823/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1447823/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10325
Author: ncha...@google.com
Date: Mon Jun 13 07:06:54 2011
Log: Add more TCK tests
[JSR 303 TCK Result] 125 of 257 (48.64%) Pass with 8 Failures and 9 Errors.
Review at http://gwt-code-reviews.appspot.com/1451817
Review by: rchan...@google.com
http://code.google.com/p/
http://gwt-code-reviews.appspot.com/1447823/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: fabbott,
Description:
Decreased the log level on a message relating to "purging" the cache.
In this case, no data is lost, its just a normal cleanup job.
Please review this at http://gwt-code-reviews.appspot.com/1447823/
Affected files:
M dev/core/src/com/google/gwt/dev/javac/Pers
Committed as r10324
http://gwt-code-reviews.appspot.com/1449814/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10324
Author: jlaba...@google.com
Date: Mon Jun 13 05:36:35 2011
Log: Rewrite SafeUriHostedModeUtils#isValid without regexp to
workaround what looks
like a bug in the Sun/Oracle JVM (error not reproduced with OpenJDK).
http://gwt-code-reviews.appspot.com/1449814/
Author:
http://gwt-code-reviews.appspot.com/1453812/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: rjrjr,
Description:
Re-roll issue 1442804: SafeHtmlRenderer code gen for UiBinder
Please review this at http://gwt-code-reviews.appspot.com/1453812/
Affected files:
A user/src/com/google/gwt/text/shared/UiRenderer.java
M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
M user
On 2011/06/12 04:50:18, Nick Chalko wrote:
LGTM
http://gwt-code-reviews.appspot.com/1451817/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Revision: 10323
Author: gwt.mirror...@gmail.com
Date: Mon Jun 13 03:14:47 2011
Log: Adds setTagName to PotentialElement, so that PotentialElement
instances can be passed to the as() method of Element subclasses (it's
nicer than blindly calling .cast(), I think). Let me know if this
39 matches
Mail list logo
