[gwt-contrib] Issue 6338

Hi, is it a big deal to include a fix for issue 6338 (http://code.google.com/p/google-web-toolkit/issues/detail?id=6338 , complete list with duplicates: http://code.google.com/p/google-web-toolkit/issues/list?can=2&q=new+html+page+wizard&colspec=ID+Type+Status+Owner+Milestone+Summary+Stars&cell

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java File user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.ja

[gwt-contrib] [google-web-toolkit] r10419 committed - Remove JSNI paths from RPC deserialization. AKA: Make RPC screaming fa...

Revision: 10419 Author: gwt.mirror...@gmail.com Date: Wed Jul 6 06:50:15 2011 Log: Remove JSNI paths from RPC deserialization. AKA: Make RPC screaming fast in DevMode. Review at http://gwt-code-reviews.appspot.com/1470802 http://code.google.com/p/google-web-toolkit/source/detail?r

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/07/06 06:22:38, stephenh wrote: > According to the current code structure, if we want to make the > variable non-static, we may need to pass the propertyOracle parameter to many > methods I downloaded the patch and was able to kill the "flaky" static variable by changing various me

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

Thanks for the review, John. I have some questions for you below. http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java File user/src/com/google/gwt/uibinder/rebind/FieldWriterType.java (right): http://gwt-code-reviews.appspot.com/147280

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/RenderableStamper

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/RenderableStamper

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

That would be great. Could you please upload the patch? Thanks! Sure--I can't upload a new patchset to this issue because I'm not the owner. Is it possible to add me? Or would you prefer for me to create a new issue? http://gwt-code-reviews.appspot.com/1380807/ -- http://groups.google.com/g

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/Composite.java File user/src/com/google/gwt/user/client/ui/Composite.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/Composite.java#newcode111 user/sr

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

On 2011/07/06 13:51:57, zhuyi wrote: On 2011/07/06 06:22:38, stephenh wrote: > > According to the current code structure, if we want to make the > > variable non-static, we may need to pass the propertyOracle parameter to many > > methods > > I downloaded the patch and was able to kill the "fla

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/Composite.java File user/src/com/google/gwt/user/client/ui/Composite.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/Composite.java#newcode111 user/sr

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

Hey Scott, not sure, did you mean to link to a different issue for the backend issue? The link above points back to this fix for the "front-end" issue. http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

LGTM http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/1/user/src/com/google/gwt/user/client/ui/RenderableS

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

LGTM http://gwt-code-reviews.appspot.com/1472801/diff/4004/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/4004/user/src/com/google/gwt/user/client/ui/Rende

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

Sorry, the back-end issue is here: http://gwt-code-reviews.appspot.com/1469804/ http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Fixing IsRenderable API step 2: pass in a stamper instead of the actual ID. (issue1472801)

http://gwt-code-reviews.appspot.com/1472801/diff/4004/user/src/com/google/gwt/user/client/ui/RenderableStamper.java File user/src/com/google/gwt/user/client/ui/RenderableStamper.java (right): http://gwt-code-reviews.appspot.com/1472801/diff/4004/user/src/com/google/gwt/user/client/ui/RenderableS

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

So, the tests in the back-end issue are valid, but the GwtAstBuilder patch is superceded. Could you roll the tests into issue 1470803? On Wed, Jul 6, 2011 at 10:54 AM, wrote: > Sorry, the back-end issue is here: > http://gwt-code-reviews.**appspot.com/1469804/

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

On Wed, Jul 6, 2011 at 12:07 PM, Eric Ayers wrote: > So, the tests in the back-end issue are valid, but the GwtAstBuilder patch > is superceded. Could you roll the tests into issue 1470803? Lemme clarify. The tests in the back-end are valid tests, which fail both with GwtAstBuilder and withou

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java (right): http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java (right): http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.

[gwt-contrib] Re: Simplify the use of TckCompileTestCase by always using the module named (issue1467811)

http://gwt-code-reviews.appspot.com/1467811/diff/1/user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java File user/test/org/hibernate/jsr303/tck/util/TckGeneratorTestUtils.java (right): http://gwt-code-reviews.appspot.com/1467811/diff/1/user/test/org/hibernate/jsr303/tck/util/TckGen

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

LGTM http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Updating npapi plugin to remove gwtId from Jso objects (idenity fix), (issue1469803)

supporting older chrome versions seems like a blocker issue to committing this to me. http://gwt-code-reviews.appspot.com/1469803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Enhancement to JsDuplicateFunctionRemover to remove duplicate virtual methods as well. That is, ... (issue1454806)

How about some tests? http://gwt-code-reviews.appspot.com/1454806/diff/5001/dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java File dev/core/src/com/google/gwt/dev/js/JsDuplicateFunctionRemover.java (right): http://gwt-code-reviews.appspot.com/1454806/diff/5001/dev/core/src/com/

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java (right): http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

LGTM http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: UnifyAst correctly handles polymorphic overrides with mixed default/public access. (issue1470803)

LGTM http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors