[gwt-contrib] Re: Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

2011-08-25 Thread cromwellian
lgtm http://gwt-code-reviews.appspot.com/1532803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

2011-08-25 Thread Ray Ryan
How's that? On Thu Aug 25 17:04:18 GMT-700 2011, > > http://gwt-code-reviews.appspot.com/1532803/diff/1/user/src/com/google/web/bindery/event/shared/UmbrellaException.java

[gwt-contrib] Re: Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

2011-08-25 Thread rjrjr
http://gwt-code-reviews.appspot.com/1532803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

2011-08-25 Thread cromwellian
http://gwt-code-reviews.appspot.com/1532803/diff/1/user/src/com/google/web/bindery/event/shared/UmbrellaException.java File user/src/com/google/web/bindery/event/shared/UmbrellaException.java (right): http://gwt-code-reviews.appspot.com/1532803/diff/1/user/src/com/google/web/bindery/event/shared

[gwt-contrib] [google-web-toolkit] r10580 committed - Public (emmanu...@google.com):...

2011-08-25 Thread codesite-noreply
Revision: 10580 Author: rj...@google.com Date: Thu Aug 25 12:59:55 2011 Log: Public (emmanu...@google.com): Fix exception exception reporting. Now consistent with all other usages of UncaughtExceptionHandler: com/google/gwt/core/client/impl/Impl.java:214 com/google/gwt/core/client/impl

[gwt-contrib] Make UmbrellaException a bit more convenient to read, and test it. (issue1532803)

2011-08-25 Thread rjrjr
Reviewers: cromwellian, Description: Make UmbrellaException a bit more convenient to read, and test it. Please review this at http://gwt-code-reviews.appspot.com/1532803/ Affected files: M user/src/com/google/web/bindery/event/shared/UmbrellaException.java A user/test/com/google/web/binder

[gwt-contrib] [google-web-toolkit] r10579 committed - Another attempt to placate IE. Think I rant the tests right this time.

2011-08-25 Thread codesite-noreply
Revision: 10579 Author: rj...@google.com Date: Thu Aug 25 12:26:31 2011 Log: Another attempt to placate IE. Think I rant the tests right this time. http://code.google.com/p/google-web-toolkit/source/detail?r=10579 Modified: /trunk/user/test/com/google/gwt/uibinder/test/client/La

[gwt-contrib] [google-web-toolkit] r10578 committed - Save the factory and options in the ValidatorContext...

2011-08-25 Thread codesite-noreply
Revision: 10578 Author: ncha...@google.com Date: Thu Aug 25 12:18:37 2011 Log: Save the factory and options in the ValidatorContext Add test for GwtValidatorContext. Review at http://gwt-code-reviews.appspot.com/1523806 Review by: rchan...@google.com http://code.google.com/p/google-web

Re: [gwt-contrib] maven source jars

2011-08-25 Thread Thomas Broyer
How about a new "dist-maven" ant target that would create a "maven bundle" (folder with the JARs and POMs laid out just like in a Maven repository)? You would then run "ant -Dgwt.version=2.4.0 dist dist-maven" [1] instead of just "ant dist" to build a release, and the generated maven bundle would

[gwt-contrib] [google-web-toolkit] r10577 committed - Address RunStyle TODO...

2011-08-25 Thread codesite-noreply
Revision: 10577 Author: stephen.haber...@gmail.com Date: Thu Aug 25 11:38:49 2011 Log: Address RunStyle TODO Review at: http://gwt-code-reviews.appspot.com/1529805/ http://code.google.com/p/google-web-toolkit/source/detail?r=10577 Modified: /trunk/user/src/com/google/gwt/junit/JUnit

[gwt-contrib] Public (emmanu...@google.com): (issue1529806)

2011-08-25 Thread rjrjr
Reviewers: rjrjr, Description: Public (emmanu...@google.com): Fix exception exception reporting. Now consistent with all other usages of UncaughtExceptionHandler: com/google/gwt/core/client/impl/Impl.java:214 com/google/gwt/core/client/impl/AsyncFragmentLoader.java:578 com/google/gwt/storage/cli

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

2011-08-25 Thread stephen . haberman
General question... can you confirm that these fields are optimized out if Boolean class is referenced but TYPE field is not? I confirmed that using Boolean.TRUE/FALSE in an app, but not Boolean.TYPE, does drop the boolean.class literal. http://gwt-code-reviews.appspot.com/1528806/ -- http:/

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

2011-08-25 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1528806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] [google-web-toolkit] r10575 committed - Add missing Linux 32 bit xulrunner libraries for Gecko6

2011-08-25 Thread codesite-noreply
Revision: 10575 Author: acle...@google.com Date: Thu Aug 25 12:50:11 2011 Log: Add missing Linux 32 bit xulrunner libraries for Gecko6 http://code.google.com/p/google-web-toolkit/source/detail?r=10575 Added: /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86-gcc3/lib/libmozalloc.so /plug

[gwt-contrib] [google-web-toolkit] r10574 committed - Adds missing xulrunner library to Geck6

2011-08-25 Thread codesite-noreply
Revision: 10574 Author: acle...@google.com Date: Thu Aug 25 12:37:41 2011 Log: Adds missing xulrunner library to Geck6 http://code.google.com/p/google-web-toolkit/source/detail?r=10574 Added: /plugin-sdks/gecko-sdks/gecko-6.0.0/Linux_x86_64-gcc3/lib/libmozalloc.so /plugin-sdks/gecko

[gwt-contrib] [google-web-toolkit] r10573 committed - Add missing libxpcomglue_s.a for Geck6 Darwin Xulrunner

2011-08-25 Thread codesite-noreply
Revision: 10573 Author: acle...@google.com Date: Thu Aug 25 12:10:19 2011 Log: Add missing libxpcomglue_s.a for Geck6 Darwin Xulrunner http://code.google.com/p/google-web-toolkit/source/detail?r=10573 Added: /plugin-sdks/gecko-sdks/gecko-6.0.0/Darwin-gcc3/lib/libxpcomglue_s.a ==

[gwt-contrib] Re: Add Integer.TYPE, etc. (issue1528806)

2011-08-25 Thread stephen . haberman
http://gwt-code-reviews.appspot.com/1528806/diff/1/user/super/com/google/gwt/emul/java/lang/Boolean.java File user/super/com/google/gwt/emul/java/lang/Boolean.java (right): http://gwt-code-reviews.appspot.com/1528806/diff/1/user/super/com/google/gwt/emul/java/lang/Boolean.java#newcode30 user/sup

[gwt-contrib] Re: Adding some extra capabilities to CountingEventBus so that we can reduce the boilerplate involve... (issue1526803)

2011-08-25 Thread skybrian
LGTM http://gwt-code-reviews.appspot.com/1526803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

Re: [gwt-contrib] maven source jars

2011-08-25 Thread Ray Ryan
Stephen, if you're game to do the research and the work, we're certainly happy to have it done. Thanks either way. On Wed Aug 24 12:39:51 GMT-700 2011, Stephen Haberman wrote: > > > Hm, perhaps a few. I saw instructions on patching emma; nothing else > > is leaping out at me. > > Okay, there are

[gwt-contrib] [google-web-toolkit] r10572 committed - Adding Richard Kolkovich to the CLA Signers list. CLA signed and on fi...

2011-08-25 Thread codesite-noreply
Revision: 10572 Author: gwt.mirror...@gmail.com Date: Thu Aug 25 08:22:19 2011 Log: Adding Richard Kolkovich to the CLA Signers list. CLA signed and on file. http://code.google.com/p/google-web-toolkit/source/detail?r=10572 Modified: /CLA-SIGNERS ==

[gwt-contrib] Re: Save the factory and options in the ValidatorContext (issue1523806)

2011-08-25 Thread rchandia
On 2011/08/24 19:03:45, Nick Chalko wrote: LGTM http://gwt-code-reviews.appspot.com/1523806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors