Re: [gwt-contrib] Announce: GwtQuery 1.1.0

2011-10-27 Thread Ray Cromwell
Awesome job Manuel, taking this project from a proof of concept to a rock solid library! -Ray On Wed, Oct 26, 2011 at 10:38 AM, Manuel Carrasco Moñino wrote: > The GQuery team is proud to announce the version 1.1.0 of the library. > > We have been working hard in order to fix many issues and to

Re: [gwt-contrib] Re: Make form event getTypes public. (issue1582803)

2011-10-27 Thread Stephen Haberman
> Sadly, Ray has left! :-( > You can definitely still assign reviews to whomever you think is most > appropriate, but add me to the review if you're not getting a > response, and I'll make sure it gets some attention. That's great, thanks, Rajeev. I have a few that have been pending; might sen

[gwt-contrib] Reroll of r10726 (issue1578809)

2011-10-27 Thread rchandia
Reviewers: rdayal, Description: Reroll of r10726 *** Original change description *** Change default of UiBinder.useLazyWidgetBuilders to true, in preparation for deleting the old code. Review by: rda...@google.com Please review this at http://gwt-code-reviews.appspot.com/1578809/ Affected fi

[gwt-contrib] Fixing a bug in HasDataPresenter where it does not pass the complete list of modified rows if a ... (issue1583805)

2011-10-27 Thread jlabanca
Reviewers: devint, Description: Fixing a bug in HasDataPresenter where it does not pass the complete list of modified rows if a pending state is detecting while we are resolving the current state. We were leaving off rows that were modified, as well as the keyboard selected rows. By passing all

[gwt-contrib] Re: Mofifying HasDataPresenter to be more resilient to state changes while it is resolving state cha... (issue1583804)

2011-10-27 Thread jlabanca
committed as r10728 http://gwt-code-reviews.appspot.com/1583804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Mofifying HasDataPresenter to be more resilient to state changes while it is resolving state cha... (issue1583804)

2011-10-27 Thread jlabanca
Reviewers: dcavalcanti_google.com, Description: Mofifying HasDataPresenter to be more resilient to state changes while it is resolving state changes. For example, if user code triggers a SelectionChangeEvent while selection is being resolved, we can handle that. Review by: dcavalca...@google.co

Re: [gwt-contrib] Re: Make form event getTypes public. (issue1582803)

2011-10-27 Thread Rajeev Dayal
On Thu, Oct 27, 2011 at 3:15 PM, wrote: > > LGTM >> > > Thanks. > > > (as a side note, I always wondered why these events are not in >> > com.google.gwt.event.dom; I believe we could add them there and have the > existing ones extend the new ones) > > Good point, I didn't think about that. I'll

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

2011-10-27 Thread stephen . haberman
LGTM Thanks. (as a side note, I always wondered why these events are not in com.google.gwt.event.dom; I believe we could add them there and have the existing ones extend the new ones) Good point, I didn't think about that. I'll keep that in mind but leave it for another CL for now. Oh, a

[gwt-contrib] Re: Rollback of r10726. It still causes brackage (issue1577805)

2011-10-27 Thread rchandia
Submitting TBR http://gwt-code-reviews.appspot.com/1577805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Rollback of r10726. It still causes brackage (issue1577805)

2011-10-27 Thread rchandia
Reviewers: rdayal, Description: Rollback of r10726. It still causes brackage *** Original change description *** Change default of UiBinder.useLazyWidgetBuilders to true, in preparation for deleting the old code. Please review this at http://gwt-code-reviews.appspot.com/1577805/ Affected fil

[gwt-contrib] Re: r10697 is back! It was falsely accused last time. Fingers crossed: (issue1578806)

2011-10-27 Thread rchandia
Submitted as r10726 http://gwt-code-reviews.appspot.com/1578806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Make form event getTypes public. (issue1582803)

2011-10-27 Thread t . broyer
LGTM (as a side note, I always wondered why these events are not in com.google.gwt.event.dom; I believe we could add them there and have the existing ones extend the new ones) Oh, and BTW, rjrjr is no longer a Googler; I wonder who to assign this CL to; jgw? jlabanca? fredsa? http://gwt-code-r

[gwt-contrib] Ignore qualified refs with generics (issue1578808)

2011-10-27 Thread stephen . haberman
Reviewers: scottb, http://gwt-code-reviews.appspot.com/1578808/diff/1/dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java File dev/core/src/com/google/gwt/dev/javac/CompilationStateBuilder.java (right): http://gwt-code-reviews.appspot.com/1578808/diff/1/dev/core/src/com/google/gw