Closure compiler does a number of these kind of transformations. Like:
String(x)
to:
'' + x
On Tue, Jan 3, 2012 at 6:21 PM, wrote:
>
> I think it will be nice to add a future JS optimization that collapses
> something like String(x) + expr or x + String(y), into x + y. Maybe
> Closure alrea
I think it will be nice to add a future JS optimization that collapses
something like String(x) + expr or x + String(y), into x + y. Maybe
Closure already has this, I'll have to check.
On 2012/01/03 21:55:36, jat wrote:
See my comments on the referenced bug, but basically I am not sure I
agree
See my comments on the referenced bug, but basically I am not sure I
agree with the change being made.
That said, the cost to projects that don't care is pretty small, so I
could be convinced.
http://gwt-code-reviews.appspot.com/1623803/
--
http://groups.google.com/group/Google-Web-Toolkit-Cont
http://gwt-code-reviews.appspot.com/1620803/diff/1/plugins/common/HostChannel.cpp
File plugins/common/HostChannel.cpp (right):
http://gwt-code-reviews.appspot.com/1620803/diff/1/plugins/common/HostChannel.cpp#newcode322
plugins/common/HostChannel.cpp:322: bool
HostChannel::readValue(gwt::Value&
LGTM
http://gwt-code-reviews.appspot.com/1588803/diff/11001/src/com/google/gwt/user/server/rpc/RPCServletUtils.java
File src/com/google/gwt/user/server/rpc/RPCServletUtils.java (right):
http://gwt-code-reviews.appspot.com/1588803/diff/11001/src/com/google/gwt/user/server/rpc/RPCServletUtils.jav
Reviewers: cromwellian, scottb, jgw, knorton, jaimeyap,
Description:
Fixes issue 4301: ensures all strings "generated" by GWT are JS string
values.
Note that, in prod mode, even an assertSame(s, s.toString()) failed!
Please review this at http://gwt-code-reviews.appspot.com/1623803/
Affected f
