LGTM (provided you address the comments below)
http://gwt-code-reviews.appspot.com/1735804/diff/1/user/src/com/google/gwt/resources/css/GenerateCssAst.java
File user/src/com/google/gwt/resources/css/GenerateCssAst.java (right):
LGTM
http://gwt-code-reviews.appspot.com/1727803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thinking about it, the 'separator' in WithTokenizers makes it mandatory
to provide a 'value' for the annotation, even if you're only using
PlaceTokenizers from a factory (would @WithTokenizers(value={},
separator=/) even work?)
The configuration-property wouldn't have that drawback.
Also,
Reviewers: Nick Chalko,
Description:
Changed comments within code generator to better mirror the actual
output code.
Review by: ncha...@google.com
Please review this at http://gwt-code-reviews.appspot.com/1729804/
Affected files:
M
My app is 60 lines of code and compiles in 120 seconds: a lot of uibinder,
a lot of classes in rpc, gin… so a lots of generators.
--
Sent with Sparrow (http://www.sparrowmailapp.com/?sig)
Il giorno venerdì 8 giugno 2012, alle ore 22:38, Ray Cromwell ha scritto:
I just checked
Reviewers: Nick Chalko,
Description:
Fixed testValidIsNotHonoredValidateProperty by allowing shallow property
validation (not honoring the @Valid annotation) in the bean-specific
validateProperty methods.
Fixes issues: 5804
Please review this at http://gwt-code-reviews.appspot.com/1727806/
How long does a regular compile take? We've identified an issue with
the RPC and ClientBundle generators running every time. We may have to
add an option to Recompile without re-running generators option
until we fix the caching.
-Ray
On Fri, Jun 8, 2012 at 1:41 PM, Stefano Ciccarelli
BTW, can you send me the speedtracer.html file in your
/tmp/*codeserver/* directory?
On Fri, Jun 8, 2012 at 1:41 PM, Stefano Ciccarelli
sciccare...@gmail.com wrote:
My app is 60 lines of code and compiles in 120 seconds: a lot of
uibinder, a lot of classes in rpc, gin… so a lots of
Reviewers: ,
Description:
Style does not currently support the max-height and max-width CSS 2
properties.
Please review this at http://gwt-code-reviews.appspot.com/1736804/
Affected files:
user/src/com/google/gwt/dom/builder/client/DomStylesBuilder.java
Reviewers: jlabanca, tbroyer_gmail.com,
Please review this at http://gwt-code-reviews.appspot.com/1725808/
Affected files:
M user/src/com/google/gwt/dom/client/DOMImplMozilla.java
M user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
Index:
John, your name was around in some of the these files, but feel free to
nominate someone else to review.
http://gwt-code-reviews.appspot.com/1725808/diff/1/user/src/com/google/gwt/dom/client/DOMImplStandardBase.java
File user/src/com/google/gwt/dom/client/DOMImplStandardBase.java (left):
http://gwt-code-reviews.appspot.com/1725808/diff/1/user/src/com/google/gwt/dom/client/DOMImplMozilla.java
File user/src/com/google/gwt/dom/client/DOMImplMozilla.java (left):
http://gwt-code-reviews.appspot.com/1725808/diff/1/user/src/com/google/gwt/dom/client/DOMImplMozilla.java#oldcode71
Hey,
So, is ant test supposed to run to completion on a reasonable
dev machine? I don't know that I've ever had it work, and so don't
generally run it.
But I was feeling guilty tonight, so tried again, went away for awhile,
and came back to my RAM (12gb) and CPUs both pegged. And lots of these
On Sat, Jun 9, 2012 at 10:26 PM, Stephen Haberman
stephen.haber...@gmail.com wrote:
So, is ant test supposed to run to completion on a reasonable
dev machine? I don't know that I've ever had it work, and so don't
generally run it.
I don't run it that often (we have a distributed test farm
14 matches
Mail list logo
