[gwt-contrib] Serialize Final Fields (issue1760803)

2012-06-27 Thread stephen . haberman
Reviewers: rdayal, scottb, Please review this at http://gwt-code-reviews.appspot.com/1760803/ Affected files: M user/src/com/google/gwt/rpc/rebind/RpcProxyCreator.java M user/src/com/google/gwt/rpc/server/HostedModeClientOracle.java M user/src/com/google/gwt/user/RemoteService.gwt.xml

[gwt-contrib] Re: Serialization of Final Fields in RPC (issue1380807)

2012-06-27 Thread stephen . haberman
On 2012/06/11 22:56:06, scottb wrote: Rajeev and I went through and made some rough comments Damn invalid XSRF token. You don't get as nice of a comment this time. Since I can't write to this issue, I made a new issue here, with patchset 1 being Yi's work that you reviewed, rebased against

[gwt-contrib] Re: Serialize Final Fields (issue1760803)

2012-06-27 Thread stephen . haberman
On 2012/06/27 16:19:30, stephenh wrote: Per comments on the original issue: http://gwt-code-reviews.appspot.com/1380807/ Patchset 1 here is Yi's work, Patchset 2 is my changes to address Rajeev's/Scott's feedback. http://gwt-code-reviews.appspot.com/1760803/ --

[gwt-contrib] GWT 2.5 RC1 Is Here!

2012-06-27 Thread rdayal
Hey all, We're excited to announce the GWT 2.5 Release Candidate! Read about it on the GWT Blog http://googlewebtoolkit.blogspot.com/2012/06/gwt-2.html, and download it here http://developers.google.com/web-toolkit/download (bottom of the page). The RC has been uploaded to Maven Central with

[gwt-contrib] The comment for Style.clearFloat() is wrong (issue1762803)

2012-06-27 Thread tuckerpmt
Reviewers: , Description: Issue 7457 Please review this at http://gwt-code-reviews.appspot.com/1762803/ Affected files: user/src/com/google/gwt/dom/client/Style.java Index: user/src/com/google/gwt/dom/client/Style.java === ---

[gwt-contrib] Constraint Violations generated with custom paths now work correctly. (issue1763803)

2012-06-27 Thread idol
Reviewers: Nick Chalko, Description: Constraint Violations generated with custom paths now work correctly. [JSR 303 TCK Result] 161 of 205 (78.54%) Pass with 36 Failures and 7 Errors. Fixes issues: 6907 Please review this at http://gwt-code-reviews.appspot.com/1763803/ Affected files: M

[gwt-contrib] Re: Constraint Violations generated with custom paths now work correctly. (issue1763803)

2012-06-27 Thread nchalko
lgtm http://gwt-code-reviews.appspot.com/1763803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Reorganized the GWT test suite structure for the nested constraint composition tests to fix errors. (issue1765803)

2012-06-27 Thread idol
Reviewers: Nick Chalko, Description: Reorganized the GWT test suite structure for the nested constraint composition tests to fix errors. Previously the nested constraint composition tests would not work in a production (compiled JS) environment when included in a GWT test suite that also