I think I prefer the other option about changing SuggestBox.
https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):
My preferred option, with one small adjustment to make it a non-breaking
change.
https://codereview.appspot.com/6492092/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):
BTW: you should create code reviews at
http://gwt-code-reviews.appspot.com/ instead.
There is a also a TODO to support SafeHtml here. I'm not entirely sure
what that means in this case (Doesn't TextBox already ensure the string
is uninterpreted? Does changing to a ValueBoxBase mean you might
On 2012/09/10 12:03:20, jtamplin wrote:
BTW: you should create code reviews at
http://gwt-code-reviews.appspot.com/
instead.
There is a also a TODO to support SafeHtml here. I'm not entirely
sure what
that means in this case (Doesn't TextBox already ensure the string is
uninterpreted?
LGTM
https://codereview.appspot.com/6492092/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java#newcode878
LGTM
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java#newcode878
LGTM. I'll commit this soon.
https://codereview.appspot.com/6492092/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: unnurg,
Description:
CellTree disappeared when clicking in the widget but outside tree nodes.
Issue 6359
Please review this at https://gwt-code-reviews.appspot.com/1827803/
Affected files:
M user/src/com/google/gwt/user/cellview/client/CellTree.java
Index:
Reviewers: atincheva,
Message:
Note: I only applied the suggested fix (after checking the WAI-ARIA
spec), I haven't tried it with a screenreader (actually, it's so
straightforward I haven't tried it at all).
Description:
Add aria-hidden state to layout panel rulers.
Issue 7646
Please review
Adding Brian as reviewer, as discussed with Unnur.
https://gwt-code-reviews.appspot.com/1820807/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On 2012/09/09 05:06:43, jtamplin wrote:
LGTM
LGTM+1. Thomas you are a machine.
https://gwt-code-reviews.appspot.com/1825803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I don't know this code, but since pushViolations() and
iterableFromConstraintViolations() are both public methods, under the
principle of being conservative about what you send and liberal about
what you receive, it seems like iterableFromConstraintViolations()
should return an empty iterable
Can you also add skybrian to the CL? I'll do the review, but I suspect
he'll go ahead and patch/submit your branches in one swoop.
https://gwt-code-reviews.appspot.com/1827803/diff/1/user/src/com/google/gwt/user/cellview/client/CellTree.java
File
Brian: Unnur thinks you'd review that patch faster than her ;-)
https://gwt-code-reviews.appspot.com/1827803/diff/1/user/src/com/google/gwt/user/cellview/client/CellTree.java
File user/src/com/google/gwt/user/cellview/client/CellTree.java (right):
On 2012/09/10 23:15:08, tbroyer wrote:
Brian: Unnur thinks you'd review that patch faster than her ;-)
https://gwt-code-reviews.appspot.com/1827803/diff/1/user/src/com/google/gwt/user/cellview/client/CellTree.java
File user/src/com/google/gwt/user/cellview/client/CellTree.java
(right):
16 matches
Mail list logo