[gwt-contrib] Introduce SuggestBoxBaseT extends ValueBoxBaseString (issue 6494102)

2012-09-10 Thread t . broyer
I think I prefer the other option about changing SuggestBox. https://codereview.appspot.com/6494102/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBox.java File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):

[gwt-contrib] Breaking Change: Use ValueBoxBaseString instead of TextBox in SuggestBox (issue 6492092)

2012-09-10 Thread t . broyer
My preferred option, with one small adjustment to make it a non-breaking change. https://codereview.appspot.com/6492092/diff/1/user/src/com/google/gwt/user/client/ui/SuggestBox.java File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):

[gwt-contrib] Re: Breaking Change: Use ValueBoxBaseString instead of TextBox in SuggestBox (issue 6492092)

2012-09-10 Thread jat
BTW: you should create code reviews at http://gwt-code-reviews.appspot.com/ instead. There is a also a TODO to support SafeHtml here. I'm not entirely sure what that means in this case (Doesn't TextBox already ensure the string is uninterpreted? Does changing to a ValueBoxBase mean you might

[gwt-contrib] Re: Breaking Change: Use ValueBoxBaseString instead of TextBox in SuggestBox (issue 6492092)

2012-09-10 Thread t . broyer
On 2012/09/10 12:03:20, jtamplin wrote: BTW: you should create code reviews at http://gwt-code-reviews.appspot.com/ instead. There is a also a TODO to support SafeHtml here. I'm not entirely sure what that means in this case (Doesn't TextBox already ensure the string is uninterpreted?

[gwt-contrib] Re: Breaking Change: Use ValueBoxBaseString instead of TextBox in SuggestBox (issue 6492092)

2012-09-10 Thread jat
LGTM https://codereview.appspot.com/6492092/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Breaking Change: Use ValueBoxBaseString instead of TextBox in SuggestBox (issue 6492092)

2012-09-10 Thread jat
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right): https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java#newcode878

[gwt-contrib] Re: Breaking Change: Use ValueBoxBaseString instead of TextBox in SuggestBox (issue 6492092)

2012-09-10 Thread t . broyer
LGTM https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right): https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java#newcode878

[gwt-contrib] Re: Breaking Change: Use ValueBoxBaseString instead of TextBox in SuggestBox (issue 6492092)

2012-09-10 Thread skybrian
LGTM. I'll commit this soon. https://codereview.appspot.com/6492092/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] CellTree disappeared when clicking in the widget but outside tree nodes. (issue1827803)

2012-09-10 Thread t . broyer
Reviewers: unnurg, Description: CellTree disappeared when clicking in the widget but outside tree nodes. Issue 6359 Please review this at https://gwt-code-reviews.appspot.com/1827803/ Affected files: M user/src/com/google/gwt/user/cellview/client/CellTree.java Index:

[gwt-contrib] Add aria-hidden state to layout panel rulers. (issue1820807)

2012-09-10 Thread t . broyer
Reviewers: atincheva, Message: Note: I only applied the suggested fix (after checking the WAI-ARIA spec), I haven't tried it with a screenreader (actually, it's so straightforward I haven't tried it at all). Description: Add aria-hidden state to layout panel rulers. Issue 7646 Please review

[gwt-contrib] Re: Add aria-hidden state to layout panel rulers. (issue1820807)

2012-09-10 Thread t . broyer
Adding Brian as reviewer, as discussed with Unnur. https://gwt-code-reviews.appspot.com/1820807/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Long.parseLong raised exception for MIN_VALUE (issue1825803)

2012-09-10 Thread cromwellian
On 2012/09/09 05:06:43, jtamplin wrote: LGTM LGTM+1. Thomas you are a machine. https://gwt-code-reviews.appspot.com/1825803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: EditorDriver#setConstraintViolations used to thrown NPE if arg was null. (issue1826803)

2012-09-10 Thread skybrian
I don't know this code, but since pushViolations() and iterableFromConstraintViolations() are both public methods, under the principle of being conservative about what you send and liberal about what you receive, it seems like iterableFromConstraintViolations() should return an empty iterable

[gwt-contrib] Re: CellTree disappeared when clicking in the widget but outside tree nodes. (issue1827803)

2012-09-10 Thread unnurg
Can you also add skybrian to the CL? I'll do the review, but I suspect he'll go ahead and patch/submit your branches in one swoop. https://gwt-code-reviews.appspot.com/1827803/diff/1/user/src/com/google/gwt/user/cellview/client/CellTree.java File

[gwt-contrib] Re: CellTree disappeared when clicking in the widget but outside tree nodes. (issue1827803)

2012-09-10 Thread t . broyer
Brian: Unnur thinks you'd review that patch faster than her ;-) https://gwt-code-reviews.appspot.com/1827803/diff/1/user/src/com/google/gwt/user/cellview/client/CellTree.java File user/src/com/google/gwt/user/cellview/client/CellTree.java (right):

[gwt-contrib] Re: CellTree disappeared when clicking in the widget but outside tree nodes. (issue1827803)

2012-09-10 Thread unnurg
On 2012/09/10 23:15:08, tbroyer wrote: Brian: Unnur thinks you'd review that patch faster than her ;-) https://gwt-code-reviews.appspot.com/1827803/diff/1/user/src/com/google/gwt/user/cellview/client/CellTree.java File user/src/com/google/gwt/user/cellview/client/CellTree.java (right):