[gwt-contrib] Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Maik Riechert
Hi all, As htmlunit isn't suited for all testing scenarios (in particular layout specific ones), I'd like to use PhantomJS as an alternative (production mode only). It is a headless webkit engine and can be easily controlled with JS files, meaning that the new RunStyle would fork a shell

Re: [gwt-contrib] Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Matthew Dempsky
You can write your own RunStyle class and then run the JUnit shell with -runStyle your.fully.qualified.PhantomJSRunStyle. On Mon, Jan 14, 2013 at 11:59 AM, Maik Riechert neothemach...@googlemail.com wrote: Hi all, As htmlunit isn't suited for all testing scenarios (in particular layout

[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread goktug
On 2013/01/13 19:28:16, tbroyer wrote: Ping; would be great to have it in 2.5.1! (IIRC, we initially talked about including it in 2.5.0 and finally decided to postpone it to the next release) This looks like a breaking change but it is hard for me to guess how likely it is going to break

Re: [gwt-contrib] Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Maik Riechert
Ah, great! Someone should document that, at least I didn't find it anywhere. Am 14.01.2013 21:12, schrieb Matthew Dempsky: You can write your own RunStyle class and then run the JUnit shell with -runStyle your.fully.qualified.PhantomJSRunStyle. On Mon, Jan 14, 2013 at 11:59 AM, Maik Riechert

Re: [gwt-contrib] Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Matthew Dempsky
Technically, it's documented in JUnitShell's -help information for -runStyle: return Selects the runstyle to use for this test. The name is + a suffix of com.google.gwt.junit.RunStyle or is a fully + qualified class name, and may be followed with a colon and

[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread skybrian
I'm not all that familiar with the editor framework but perhaps there's a cleaner way to do this? (See comments.) http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java File

[gwt-contrib] Change in gwt[master]: Takes enum constants into account in types' serialization si...

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Takes enum constants into account in types' serialization signature in RPC .. Patch Set 2: (1 comment)

[gwt-contrib] Change in gwt[master]: Fixes IE's http status code mangling from 204 to 1223

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Fixes IE's http status code mangling from 204 to 1223 .. Patch Set 6: FYI, we had to revert this change because we had some internal unit tests that

[gwt-contrib] Change in gwt[master]: Takes enum constants into account in types' serialization si...

2013-01-14 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Takes enum constants into account in types' serialization signature in RPC .. Patch Set 2: (1 comment)

[gwt-contrib] Change in gwt[master]: Takes enum constants into account in types' serialization si...

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Takes enum constants into account in types' serialization signature in RPC .. Patch Set 2: Code-Review+1 -- To view, visit

[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread t . broyer
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java File user/src/com/google/gwt/editor/client/adapters/EditorSource.java (right):

[gwt-contrib] Change in gwt[master]: use java.net.HttpCookie instead of Crockfords json.org

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: use java.net.HttpCookie instead of Crockfords json.org .. Patch Set 2: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1600 To

[gwt-contrib] Change in gwt[master]: Fix compiler error for class extending an inner class.

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Fix compiler error for class extending an inner class. .. Patch Set 3: (1 comment) File

[gwt-contrib] Change in gwt[master]: Remove mysterious Hack for Google I/O comment.

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has abandoned this change. Change subject: Remove mysterious Hack for Google I/O comment. .. Abandoned Submitted. -- To view, visit https://gwt-review.googlesource.com/1710 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Takes enum constants into account in types' serialization si...

2013-01-14 Thread Brian Slesinsky
Brian Slesinsky has abandoned this change. Change subject: Takes enum constants into account in types' serialization signature in RPC .. Abandoned Internally submitted. -- To view, visit

[gwt-contrib] Change in gwt[master]: increased zIndex of compile dialog to avoid it being hidden

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: increased zIndex of compile dialog to avoid it being hidden .. Patch Set 1: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1530 To

[gwt-contrib] Change in gwt[master]: Fixes compiler error for class extending an inner class.

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Fixes compiler error for class extending an inner class. .. Patch Set 5: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1690 To

[gwt-contrib] Re: Developing a new remote RunStyle for PhantomJS

2013-01-14 Thread Thomas Broyer
Note that, while probably not applicable to Travis CI, there's GhostDriver (WebDriver for PhantomJS) which should allow you to use the Selenium RunStyle to drive PhantomJS. On Monday, January 14, 2013 8:59:14 PM UTC+1, Maik Riechert wrote: Hi all, As htmlunit isn't suited for all testing

[gwt-contrib] Re: Devmode broken with elemental (#7481) (issue1801804)

2013-01-14 Thread mdempsky
http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java File core/src/com/google/gwt/dev/shell/DispatchClassInfo.java (right):

[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity .. Patch Set 3: Code-Review+1 (1 comment) File

[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity .. Patch Set 3: (1 comment) File

[gwt-contrib] Change in gwt[master]: AbstractMap.remove() is incorrect, accessing entry after del...

2013-01-14 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: AbstractMap.remove() is incorrect, accessing entry after deletion fixes issue 7856 .. Patch Set 1: Code-Review+1 -- To view, visit

[gwt-contrib] Re: Devmode broken with elemental (#7481) (issue1801804)

2013-01-14 Thread jat
http://gwt-code-reviews.appspot.com/1801804/diff/1/core/src/com/google/gwt/dev/shell/DispatchClassInfo.java File core/src/com/google/gwt/dev/shell/DispatchClassInfo.java (right):

[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread t . broyer
http://gwt-code-reviews.appspot.com/1587803/diff/1/user/src/com/google/gwt/editor/client/adapters/EditorSource.java File user/src/com/google/gwt/editor/client/adapters/EditorSource.java (right):

[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity

2013-01-14 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity .. Patch Set 3: (1 comment) File

[gwt-contrib] Re: Fix issue 6959. (issue1587803)

2013-01-14 Thread skybrian
http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java File user/src/com/google/gwt/editor/client/adapters/EditorSource.java (right):