[gwt-contrib] Change in gwt[master]: Issue 7834 - fix BigDecimal compareTo

2013-01-28 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Issue 7834 - fix BigDecimal compareTo .. Patch Set 2: Code-Review+1 SGTM (not sure I understood all the changes though; someone else please have an in-depth

[gwt-contrib] Re: DateBox (DatePicker) still allows user to choose disabled dates with mouse click (issue1885803)

2013-01-28 Thread t . broyer
According to http://code.google.com/p/google-web-toolkit/issues/detail?id=7919 it worked the way you describe in GWT 2.4 so let's go ahead and fix this. Apparently the regression was introduced in https://code.google.com/p/google-web-toolkit/source/detail?r=11174 Daniel: how's 2.5.1 going? is it

[gwt-contrib] Change in gwt[master]: Proxy IDs have to be the same for a given proxy in the respo...

2013-01-28 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: Proxy IDs have to be the same for a given proxy in the response payload. .. Patch Set 2: Code-Review+1 I don't completely grok this, but the tests and

[gwt-contrib] Change in gwt[master]: fixes ISSUE 7752 added constructor for java.util.logging.Lev...

2013-01-28 Thread Matthew Dempsky
Matthew Dempsky has posted comments on this change. Change subject: fixes ISSUE 7752 added constructor for java.util.logging.Level gwt emulation to be compatible with JRE .. Patch Set 4: What would happen even those fields

[gwt-contrib] Re: incremental dev mode

2013-01-28 Thread Joshb
Stephen, I came up with the same idea. We are working on a rather large GWT project, and the speed of dev mode is atrocious (30-45 second refresh on an i7 with 32GB ram). I understand why GWT compiles the way it does for production mode, but it seems it seems incredibly inefficient to have

[gwt-contrib] Change in gwt[master]: Inline javascript:'' within NamedFrame's internal SafeHtmlTe...

2013-01-28 Thread Matthew Dempsky
Matthew Dempsky has abandoned this change. Change subject: Inline javascript:'' within NamedFrame's internal SafeHtmlTemplate .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1800 To

[gwt-contrib] Re: Issue 7112 (issue1649803)

2013-01-28 Thread mdempsky
On 2013/01/12 15:35:19, tbroyer wrote: We're in dev-time code so we can use Guava (the re-packaged one) and it's Objects.equal(a, b) which takes care of nulls. I don't think that's true. This code still needs to be translatable to JavaScript to support running tests in production mode, and

[gwt-contrib] Re: Issue 7112 (issue1649803)

2013-01-28 Thread t . broyer
On 2013/01/28 21:06:02, mdempsky wrote: On 2013/01/12 15:35:19, tbroyer wrote: We're in dev-time code so we can use Guava (the re-packaged one) and it's Objects.equal(a, b) which takes care of nulls. I don't think that's true. This code still needs to be translatable to JavaScript to

Re: [gwt-contrib] source maps in chrome

2013-01-28 Thread Gaspard van Ko
Hi, I have the same problem using chrome 25.0.1364.45 beta and gwt 2.5.0. Do we have to use the trunk of gwt for it to work? On Friday, January 25, 2013 3:43:40 AM UTC+1, Brian Slesinsky wrote: I've tried it recently with Chrome 25. You've checked the source maps on checkbox and reloaded the

[gwt-contrib] GWT.RunAsync and JAVA switch

2013-01-28 Thread Cédric Barbet
Hello, The two code structure ensure that the javascript generated by GWT will be properly splitted ? GWT.runAsync(new RunAsyncCallback() { @Override public void onFailure(Throwable reason) { ... } @Override public void onSuccess() { switch(value){ case 0: ... ;break; case 1: ... ;break; }

[gwt-contrib] Change in gwt[master]: Proxy IDs have to be the same for a given proxy in the respo...

2013-01-28 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Proxy IDs have to be the same for a given proxy in the response payload. .. Patch Set 2: The problem is that we have 2 ways of identifying an object: using

Re: [gwt-contrib] GWT.RunAsync and JAVA switch

2013-01-28 Thread Roberto Lublinerman
Hi Cédric, I am not sure I understood your question, but in the first example case 0 and case 1 will be part of the same code fragment (will not be split), whereas in the second example case 0 and case 1 code may be split. Roberto Lublinerman | Software Engineer | rlu...@google.com |

[gwt-contrib] Change in gwt[master]: Updates ICU4J from 4.4.2 to 50.1.1

2013-01-28 Thread Brian Slesinsky
Hello Andrew Bachmann, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/1700 to look at the new patch set (#3). Change subject: Updates ICU4J from 4.4.2 to 50.1.1 .. Updates ICU4J

[gwt-contrib] Change in gwt[master]: Issue 7834 - fix BigDecimal compareTo

2013-01-28 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Issue 7834 - fix BigDecimal compareTo .. Patch Set 2: (3 comments) Could you simplify this code? I don't see the bug either.

Re: [gwt-contrib] source maps in chrome

2013-01-28 Thread Thomas Broyer
On Monday, January 28, 2013 9:54:29 AM UTC+1, Gaspard van Ko wrote: Hi, I have the same problem using chrome 25.0.1364.45 beta and gwt 2.5.0. Do we have to use the trunk of gwt for it to work? Yes. -- -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received

[gwt-contrib] Change in gwt[master]: Updates ICU4J from 4.4.2 to 50.1.1

2013-01-28 Thread Andrew Bachmann
Andrew Bachmann has posted comments on this change. Change subject: Updates ICU4J from 4.4.2 to 50.1.1 .. Patch Set 3: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/1700 To unsubscribe, visit