[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy
Hello Colin Alworth, Thomas Broyer, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3070 to look at the new patch set (#5). Change subject: Add hasClassName method in com.google.gwt.dom.client.Element

[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy
Andrey Korzhevskiy has abandoned this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Abandoned broken style -- To view, visit https://gwt-review.googlesource.com/3070 To unsubscribe,

[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy
Andrey Korzhevskiy has restored this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Restored -- To view, visit https://gwt-review.googlesource.com/3070 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy
Andrey Korzhevskiy has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 5: Uploaded patch set 5: sorted methods according gwt code style. -- To view,

[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 5: Please don't change the order. It looks like it is previously agreed upon not to

[gwt-contrib] Re: Removing support for old browsers

2013-05-31 Thread Thomas Broyer
On Thursday, May 30, 2013 8:19:37 PM UTC+2, Jens wrote: How would soft permutations work if you have browser version specific JS hacks/workarounds implemented during JJS compilation? If you have a workaround for IE6 and a different one for IE7 and you can't mix both, then you are

[gwt-contrib] Change in gwt[master]: Update how columns are hidden in CellTable.

2013-05-31 Thread Jens Nehlmeier
Jens Nehlmeier has posted comments on this change. Change subject: Update how columns are hidden in CellTable. .. Patch Set 2: (1 comment) File

[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Andrey Korzhevskiy
Hello Colin Alworth, Thomas Broyer, Goktug Gokdogan, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3070 to look at the new patch set (#6). Change subject: Add hasClassName method in com.google.gwt.dom.client.Element

[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...

2013-05-31 Thread Patrick Tucker
Patrick Tucker has posted comments on this change. Change subject: Removes delegation of event from TextBox event handler inside SuggestBox. .. Patch Set 1: Code-Review+1 Cool thanks for transferring this one over! -- To

[gwt-contrib] Re: GWT Coding Style Update

2013-05-31 Thread Thomas Broyer
On Friday, May 31, 2013 3:22:21 AM UTC+2, Goktug Gokdogan wrote: Hi folks. We currently have a coding style guide for GWT-SDK here: https://developers.google.com/web-toolkit/makinggwtbetter#codestyle The guide has some enforcements like static/non-static + alphabetical ordering.

[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...

2013-05-31 Thread Thomas Broyer
Thomas Broyer has posted comments on this change. Change subject: Removes delegation of event from TextBox event handler inside SuggestBox. .. Patch Set 1: Code-Review+2 Should we add a test for it? (dispatch an event on

Re: [gwt-contrib] GWT Coding Style Update

2013-05-31 Thread Stephen Haberman
What problems has it caused? I like the coding style as is, although it is a learning curve for contributors. I believe I have the basics down now, but am never quite sure. I think it would be nice if getting them setup in both Eclipse and IntelliJ was dead simple, instead of the current

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

2013-05-31 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 1: After thinking about this overnight, here's my take on this. (Keep in

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

2013-05-31 Thread Jens Nehlmeier
Jens Nehlmeier has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 1: Actually what I like about the current state in this CL is that it's

[gwt-contrib] Change in gwt[master]: Update how columns are hidden in CellTable.

2013-05-31 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Update how columns are hidden in CellTable. .. Patch Set 2: Code-Review+2 Seems okay. If we really need 0% we can do it later. -- To view, visit

[gwt-contrib] Change in gwt[master]: Update how columns are hidden in CellTable.

2013-05-31 Thread Goktug Gokdogan
Hello Leeroy Jenkins, Brian Slesinsky, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3130 to look at the new patch set (#3). Change subject: Update how columns are hidden in CellTable.

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

2013-05-31 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 1: I don't have a strong opinion either way, but I'll point out that class

[gwt-contrib] Change in gwt[master]: Update how columns are hidden in CellTable.

2013-05-31 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Update how columns are hidden in CellTable. .. Patch Set 3: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3130 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Update how columns are hidden in CellTable.

2013-05-31 Thread Jens Nehlmeier
Jens Nehlmeier has posted comments on this change. Change subject: Update how columns are hidden in CellTable. .. Patch Set 3: Code-Review+1 -- To view, visit https://gwt-review.googlesource.com/3130 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Update how columns are hidden in CellTable.

2013-05-31 Thread Goktug Gokdogan
Goktug Gokdogan has submitted this change and it was merged. Change subject: Update how columns are hidden in CellTable. .. Update how columns are hidden in CellTable. Hide columns that shouldn't be visible by setting display

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

2013-05-31 Thread Stephen Haberman
Stephen Haberman has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 1: FWIW I like Jen's 4th line as well (i.e. this CL). -- To view, visit

[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...

2013-05-31 Thread Goktug Gokdogan
Hello Leeroy Jenkins, Thomas Broyer, Patrick Tucker, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3141 to look at the new patch set (#2). Change subject: Removes delegation of event from TextBox event handler inside SuggestBox.

[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

2013-05-31 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 6: Code-Review+2 Colin, I'm going +2 this change. If it is going to be a big

[gwt-contrib] Change in gwt[master]: Adds onEnsureDebugId delegation to Composite.

2013-05-31 Thread Goktug Gokdogan
Goktug Gokdogan has uploaded a new change for review. https://gwt-review.googlesource.com/3160 Change subject: Adds onEnsureDebugId delegation to Composite. .. Adds onEnsureDebugId delegation to Composite. Bugs: issue 3812

[gwt-contrib] Change in gwt[master]: Adds onEnsureDebugId delegation to Composite.

2013-05-31 Thread Daniel Kurka
Daniel Kurka has submitted this change and it was merged. Change subject: Adds onEnsureDebugId delegation to Composite. .. Adds onEnsureDebugId delegation to Composite. Bugs: issue 3812 Change-Id:

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

2013-05-31 Thread Brian Slesinsky
Brian Slesinsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: Feasible? I'd guess yes. Up to the implementer to decide how they

[gwt-contrib] Change in gwt[master]: Adds onEnsureDebugId delegation to Composite.

2013-05-31 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds onEnsureDebugId delegation to Composite. .. Patch Set 1: I was waiting for global presubmit results. It would have been better if you haven't

[gwt-contrib] Change in gwt[master]: Revert Adds onEnsureDebugId delegation to Composite.

2013-05-31 Thread Daniel Kurka
Daniel Kurka has reverted this change. Change subject: Revert Adds onEnsureDebugId delegation to Composite. .. Patch Set 1: Reverted This patchset was reverted in change: Id162c4e9b553a5981f09d26a3d1112dbf085825e -- To

[gwt-contrib] Change in gwt[master]: Adds onEnsureDebugId delegation to Composite.

2013-05-31 Thread Goktug Gokdogan
Goktug Gokdogan has posted comments on this change. Change subject: Adds onEnsureDebugId delegation to Composite. .. Patch Set 1: Thanks -- To view, visit https://gwt-review.googlesource.com/3160 To unsubscribe, visit