Jens Nehlmeier has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
......................................................................
Patch Set 1:
Actually what I like about the current state in this CL is that it's
consistent. Regardless of events or elements, if you need subpixel
precision you choose getSubPixel<method name>().
button.getElement().toSubPixelElement().getOffsetHeight();
button.getElement().withSubPixelPrecision().getOffsetHeight();
button.getSubPixelElement().getOffsetHeight();
button.getElement().getSubPixelOffsetHeight();
Just by reading it I would prefer the 4th solution => the current CL
implementation. Its as short as possible and does not have any redundant
words in it.
--
To view, visit https://gwt-review.googlesource.com/3090
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27e98f0ad3c1c236b2d85d24f197719fa4cd352a
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos <[email protected]>
Gerrit-Reviewer: Artur Signell <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
