[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Thomas Broyer has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 ...

[gwt-contrib] Change in gwt[master]: Add HasPaths interface.

Thomas Broyer has posted comments on this change. Change subject: Add HasPaths interface. .. Patch Set 1: Code-Review-1 I've had that patch sitting in my Git repo for mor ethan a year (the copyright for HasPaths read 2011 be

[gwt-contrib] Change in gwt[master]: Add HasPaths interface.

Thomas Broyer has uploaded a new change for review. https://gwt-review.googlesource.com/3185 Change subject: Add HasPaths interface. .. Add HasPaths interface. Bug: issue 6227 Change-Id: I2f259552d945bf22592c4395e3c7b2ad45b

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

Thomas Broyer has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 3: (3 comments) File user/super/com/google/gwt/emul/java/util/Array

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

John A. Tamplin has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

John A. Tamplin has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Thomas Broyer has posted comments on this change. Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Patch Set 4: (2 comments) Fil

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

John A. Tamplin has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 1: (1 comment) File us

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Thomas Broyer has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 ...

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Thomas Broyer has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 ...

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

Stephen Haberman has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 1: (2 comments) File

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

Ray Cromwell has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 3: (1 comment) File user/super/com/google/gwt/emul/java/util/Objects

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

John A. Tamplin has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 3: Code-Review-1 (1 comment) Need tests as well. File user/super

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

Andrey Korzhevskiy has uploaded a new patch set (#3). Change subject: Emulate java.util.Objects .. Emulate java.util.Objects Fixes issue 8173 Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 --- M user/super/com/google/gwt

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

Andrey Korzhevskiy has uploaded a new patch set (#2). Change subject: Emulate java.util.Objects .. Emulate java.util.Objects Fixes issue 8173 Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 --- M user/super/com/google/gwt

[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects

Andrey Korzhevskiy has uploaded a new change for review. https://gwt-review.googlesource.com/3184 Change subject: Emulate java.util.Objects .. Emulate java.util.Objects Fixes issue 8173 Change-Id: I15a10e7c52eb39baac2c22b9

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Daniel Kurka has posted comments on this change. Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Patch Set 4: Code-Review+1 LGTM -- To view, visit https://gwt-review.googlesource.c

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Andrey Korzhevskiy has posted comments on this change. Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Patch Set 4: patch set 4: i made Character.compare use Integer.signum -- To v

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Hello Daniel Kurka, John A. Tamplin, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3183 to look at the new patch set (#4). Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Daniel Kurka has posted comments on this change. Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Patch Set 3: Code-Review+1 Lets leave this open for another 1-2 days to give the oth

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Hello John A. Tamplin, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3183 to look at the new patch set (#3). Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) ...

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Daniel Kurka has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

John A. Tamplin has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Daniel Kurka has posted comments on this change. Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Patch Set 2: (1 comment) File

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

John A. Tamplin has posted comments on this change. Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Patch Set 2: Code-Review+1 (1 comment) .

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Daniel Kurka has posted comments on this change. Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Patch Set 2: (1 comment) File

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Andrey Korzhevskiy has uploaded a new patch set (#2). Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) Fixes iss

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Daniel Kurka has posted comments on this change. Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Patch Set 1: (5 comments) File

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Daniel Kurka has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3180 to look at the new patch set (#9). Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -

[gwt-contrib] Change in gwt[master]: Emulate Boolean.compare(boolean,boolean), Character.compare(...

Andrey Korzhevskiy has uploaded a new change for review. https://gwt-review.googlesource.com/3183 Change subject: Emulate Boolean.compare(boolean,boolean), Character.compare(char,char) .. Emulate Boolean.compare(boolean,b

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

John A. Tamplin has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Andrey Korzhevskiy has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 ..

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Daniel Kurka has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Hello John A. Tamplin, Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3180 to look at the new patch set (#8). Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Daniel Kurka has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

John A. Tamplin has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 .

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Andrey Korzhevskiy has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 ..

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Hello Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3180 to look at the new patch set (#7). Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Flo

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Daniel Kurka has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Daniel Kurka has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Hello Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3180 to look at the new patch set (#6). Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Flo

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Thomas Broyer has posted comments on this change. Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Float.compare (Double already exists) fixes issue 7998 ...

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Hello Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3180 to look at the new patch set (#5). Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Flo

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Hello Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3180 to look at the new patch set (#4). Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Flo

[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...

Hello Thomas Broyer, Leeroy Jenkins, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3180 to look at the new patch set (#3). Change subject: adding compare for several number types -Byte.compare -Short.compare -Integer.compare -Long.compare -Flo

[gwt-contrib] Change in gwt[master]: Adding Integer.compare to emulation

John A. Tamplin has posted comments on this change. Change subject: Adding Integer.compare to emulation .. Patch Set 2: -Code-Review I also agree about adding similar functionality in the other wrapper types. I am nervous abo

[gwt-contrib] Change in gwt[master]: Adding Integer.compare to emulation

Thomas Broyer has posted comments on this change. Change subject: Adding Integer.compare to emulation .. Patch Set 2: I'm not sure why this didn't get picked up when I reviewed the first patch set. Did you click "add comme

[gwt-contrib] Change in gwt[master]: Adding Integer.compare to emulation

John A. Tamplin has posted comments on this change. Change subject: Adding Integer.compare to emulation .. Patch Set 1: (1 comment) I'm not sure why this didn't get picked up when I reviewed the first patch set. .

[gwt-contrib] Change in gwt[master]: Set KeyboardSelectedRow with relative index in AbstractHasDa...

Thomas Broyer has posted comments on this change. Change subject: Set KeyboardSelectedRow with relative index in AbstractHasData focus event preview .. Patch Set 2: Let's try rebasing it. -- To view, visit https://gwt-revi

[gwt-contrib] Change in gwt[master]: Set KeyboardSelectedRow with relative index in AbstractHasDa...

Thomas Broyer has created a new patch set by issuing a rebase in Gerrit (#3). Change subject: Set KeyboardSelectedRow with relative index in AbstractHasData focus event preview .. Set KeyboardSelectedRow with relative index

[gwt-contrib] Change in gwt[master]: Set KeyboardSelectedRow with relative index in AbstractHasDa...

Roberto Lublinerman has posted comments on this change. Change subject: Set KeyboardSelectedRow with relative index in AbstractHasData focus event preview .. Patch Set 2: @Matthew, for some reason Jenkins didnt get this pat

[gwt-contrib] Change in gwt[master]: Cut circular dependency between c.g.g.core.linker and c.g.g....

Roberto Lublinerman has posted comments on this change. Change subject: Cut circular dependency between c.g.g.core.linker and c.g.g.dev.js .. Patch Set 1: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/

[gwt-contrib] Change in gwt[master]: Adding Integer.compare to emulation

Thomas Broyer has posted comments on this change. Change subject: Adding Integer.compare to emulation .. Patch Set 2: Code-Review-1 (1 comment) How about Short.compare() and similar? .