Manuel Carrasco Moñino has posted comments on this change.
Change subject: Fix binary vs. internal variable names, remove unused Name
code.
..
Patch Set 1:
(2 comments)
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3661
Change subject: Utility to store multiple HandlerRegistrations
..
Utility to store multiple HandlerRegistrations
fixes issue 8246
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#2).
Change subject: Utility to store multiple HandlerRegistrations
..
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 1:
(3 comments)
Maybe ResettableEventBus should be retrofitted to use this class.
Thomas Broyer has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 2:
(1 comment)
File
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 2:
(1 comment)
File
Daniel Kurka has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 1:
(3 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3661
to look at the new patch set (#3).
Change subject: Utility to store multiple HandlerRegistrations
..
Daniel Kurka has posted comments on this change.
Change subject: Log warning when wrongly using RootPanel
..
Patch Set 1:
(2 comments)
I think we should go with adding a comment to add (since all other adds
calls this one
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/3662
Change subject: Move arrow key functions from Tree to KeyCodes
..
Move arrow key functions from Tree to KeyCodes
remove handling
Jens Nehlmeier has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 3:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Log warning when wrongly using RootPanel
..
Patch Set 1: Code-Review-1
(2 comments)
I can't count the number of times I had to point to “the Using a
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 1:
(4 comments)
File
Hello Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#2).
Change subject: Move arrow key functions from Tree to KeyCodes
..
Move
Matthew Dempsky has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 2:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 2:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 2: Code-Review+1
(1 comment)
File
Hello Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#3).
Change subject: Move arrow key functions from Tree to KeyCodes
Daniel Kurka has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 3:
(1 comment)
File
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#4).
Change subject: Move arrow key functions from Tree to KeyCodes
Matthew Dempsky has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 4: Code-Review+1
--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit
Goktug Gokdogan has posted comments on this change.
Change subject: Utility to store multiple HandlerRegistrations
..
Patch Set 3:
(3 comments)
File
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 3:
(1 comment)
File
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 4: Code-Review+2
--
To view, visit https://gwt-review.googlesource.com/3662
To unsubscribe, visit
Goktug Gokdogan has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 4: Code-Review+1
(3 comments)
Looks good to me API wise.
Daniel Kurka has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 4:
(2 comments)
File
Hello Matthew Dempsky, Thomas Broyer, Leeroy Jenkins, Goktug Gokdogan,
I'd like you to reexamine a change. Please visit
https://gwt-review.googlesource.com/3662
to look at the new patch set (#5).
Change subject: Move arrow key functions from Tree to KeyCodes
Thomas Broyer has posted comments on this change.
Change subject: Move arrow key functions from Tree to KeyCodes
..
Patch Set 5: Code-Review+1
(3 comments)
Nits only (I'd still add an experimental note to maybeSwap; this
Ray Cromwell has uploaded a new change for review.
https://gwt-review.googlesource.com/3670
Change subject: Makes some private implementation classes of
StackTraceCreator public to enable custom implementations. Useful for other
Javascript VMs, as well as integration with non-GWT code,
Ray Cromwell has posted comments on this change.
Change subject: Fixes Exception wrapping/unwrapping in compiler
..
Patch Set 3:
Is there a bug/issue somewhere for this? What is the overall goal it is
trying to accomplish?
30 matches
Mail list logo
