[gwt-contrib] Re: Add "multiple" attribute to InputElement / FileUpload widget to enable the HTML5 multiple attribute. (issue1786803)

2012-07-24 Thread heinberg
I tried running the tests, but they appeared to hang. I also realized that I actually need to get access to the FileList and Files of the HTML5 File API. So maybe it pays to abandon this, as you suggested, and instead access the Element myself. What do you think? If I do indeed abandon this, shou

[gwt-contrib] Re: Add "multiple" attribute to InputElement / FileUpload widget to enable the HTML5 multiple attribute. (issue1786803)

2012-07-21 Thread heinberg
Sweet, thanks! Do you know how I can exclude the tests from running under IE9 and earlier? http://gwt-code-reviews.appspot.com/1786803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add "multiple" attribute to InputElement / FileUpload widget to enable the HTML5 multiple attribute. (issue1786803)

2012-07-21 Thread Jonathan Heinberg
Hi Brian, I tried in IE9, and it didn't cause issues - it just showed the single file upload. Also, IE10 will support file - http://msdn.microsoft.com/en-us/library/ie/hh673542(v=vs.85).aspx. Do you think we could include it? This is also part of a public bug: http://code.google.com/p/google-web-t

[gwt-contrib] Re: Add "multiple" attribute to InputElement / FileUpload widget to enable the HTML5 multiple attribute. (issue1786803)

2012-07-21 Thread heinberg
I can try IE9 at home. I think this will just default to the single case, which will often work for developers. If that does work, are we OK checking this in, or is it a showstopper? I was considering Elemental, but we have a bunch of code that already uses FileUpload, especially with the event

[gwt-contrib] Add "multiple" attribute to InputElement / FileUpload widget to enable the HTML5 multiple attribute. (issue1786803)

2012-07-21 Thread heinberg
Reviewers: skybrian, Description: Add "multiple" attribute to InputElement / FileUpload widget to enable the HTML5 multiple attribute. Review by: skybr...@google.com Please review this at http://gwt-code-reviews.appspot.com/1786803/ Affected files: M user/src/com/google/gwt/dom/client/InputE

[gwt-contrib] Re: Add "multiple" attribute to InputElement / FileUpload widget to enable the HTML5 multiple attribute. (issue1786803)

2012-07-21 Thread heinberg
http://gwt-code-reviews.appspot.com/1786803/diff/1/user/test/com/google/gwt/dom/DOMSuite.java File user/test/com/google/gwt/dom/DOMSuite.java (right): http://gwt-code-reviews.appspot.com/1786803/diff/1/user/test/com/google/gwt/dom/DOMSuite.java#newcode47 user/test/com/google/gwt/dom/DOMSuite.jav

[gwt-contrib] Re: Add "multiple" attribute to InputElement / FileUpload widget to enable the HTML5 multiple attribute. (issue1786803)

2012-07-21 Thread heinberg
On 2012/07/20 20:45:01, skybrian wrote: On 2012/07/20 20:32:46, heinberg wrote: > Sweet, thanks! Do you know how I can exclude the tests from running under IE9 > and earlier? Not offhand, but we don't need to exclude them unless they break. These tests only check that the att