[gwt-contrib] ClientBundle inheritence issues

2009-07-02 Thread nwolf
Reviewers: robertvawter_google.com, Description: http://b/issue?id=1958188 Please review this at http://gwt-code-reviews.appspot.com/48805 Affected files: rg/CssResourceGenerator.java Index: rg/CssResourceGenerator.java ===

[gwt-contrib] Cleaning up the FastTree deprecations

2009-05-29 Thread nwolf
Reviewers: jlabanca, Description: Getting rid of some deprecations so that the FastTree demo will actually run. Please review this at http://gwt-code-reviews.appspot.com/33832 Affected files: src-demo/com/google/gwt/gen2/demo/fasttree/FastTreeDemo.gwt.xml

[gwt-contrib] Re: Cleaning up the FastTree deprecations

2009-05-29 Thread nwolf
http://gwt-code-reviews.appspot.com/33832/diff/1/6 File src-demo/com/google/gwt/gen2/demo/fasttree/FastTreeDemo.gwt.xml (right): http://gwt-code-reviews.appspot.com/33832/diff/1/6#newcode5 Line 5: inherits name='com.google.gwt.user.theme.standard.Standard'/ On 2009/05/29 18:17:47, jlabanca

[gwt-contrib] Moving FastTree into trunk

2009-05-29 Thread nwolf
Reviewers: jlabanca, Description: This is the first stab at moving FastTree into trunk (from incubator) and merging some commonalities with Tree into a new base class called TreeBase.java Please review this at http://gwt-code-reviews.appspot.com/33836 Affected files: build.xml

[gwt-contrib] FastTree Focus Issue

2009-04-06 Thread nwolf
Reviewers: jlabanca, minz, Description: There was a focus issue with the fasttree when the size of the tree was larger than the viewport, this was especially manifested with very large trees. Please review this at http://gwt-code-reviews.appspot.com/18801 Affected files:

[gwt-contrib] Removing processElementClicked from gen2.FastTree

2009-03-27 Thread nwolf
Reviewers: jlabanca, Description: http://code.google.com/p/google-web-toolkit-incubator/issues/detail?id=232 Please review this at http://gwt-code-reviews.appspot.com/14802 Affected files: client/FastTree.java Index: client/FastTree.java

[gwt-contrib] Filed against Issue 1518032 in bugganizer

2009-02-27 Thread nwolf
Reviewers: ecc, Description: java.lang.IndexOutOfBoundsException: No child at index -1 when findDeepestOpenChild(FastTree.java:792) is called. Please review this at http://gwt-code-reviews.appspot.com/8803 Affected files: src/com/google/gwt/gen2/complexpanel/client/FastTree.java

[gwt-contrib] Respecting onBeforeSelect.cancel

2009-02-20 Thread nwolf
Reviewers: ecc, Description: When beforeSelect is fired check that if cancel is called the tree item doesn't get selected. Please review this at http://gwt-code-reviews.appspot.com/5801 Affected files: src-demo/com/google/gwt/gen2/demo/fasttree/client/FastTreeDemo.java

[gwt-contrib] Respecting onBeforeSelect.cancel

2009-02-20 Thread nwolf
Reviewers: ecc, Description: When beforeSelect is fired check that if cancel is called the tree item doesn't get selected. Please review this at http://gwt-code-reviews.appspot.com/6801 Affected files: src-demo/com/google/gwt/gen2/demo/fasttree/client/FastTreeDemo.java

[gwt-contrib] Patching demo code for becomeLeaf method in gen2 fastTree

2009-02-13 Thread nwolf
Reviewers: ecc, Description: Created a DynamicTree in the fastTreeDemo for the gen2 FastTree that provides buttons to make a node a leaf and then to add new nodes to the leaf node to make it have children again. Deprecated the HasFastTreeItems interface. Added a public getTreeRoot() method to

[gwt-contrib] Re: Patching demo code for becomeLeaf method in gen2 fastTree

2009-02-13 Thread nwolf
I'm lovin' this tool. http://gwt-code-reviews.appspot.com/4806/diff/1/5 File src-demo/com/google/gwt/gen2/demo/fasttree/FastTreeDemo.gwt.xml (left): http://gwt-code-reviews.appspot.com/4806/diff/1/5#oldcode2 Line 2: On 2009/02/13 21:01:40, ecc wrote: looks like a line was lost. do you want