Re: [gwt-contrib] code review policy

I've been assuming I can give +2 for the parts of the code I am most familiar with. On Jun 9, 2013 11:12 PM, "Stephen Haberman" wrote: > Hey, > > I wasn't quite sure, so figured I would ask: what's our policy on who > can give +2s? Is it any committer? > > I assume so, but perhaps out of traditio

[gwt-contrib] code review policy

Hey, I wasn't quite sure, so figured I would ask: what's our policy on who can give +2s? Is it any committer? I assume so, but perhaps out of tradition, I've been assuming Googlers would give +2s. Well, and even if we are/have moved past the Google-only phase of GWT, for now/awhile they will sti

[gwt-contrib] code review for FastStringMap

Hey, Not a big deal, but can someone +2 this code review: https://gwt-review.googlesource.com/#/c/3280/ (Or -1 if it can't happen.) - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT

[gwt-contrib] Code Review Request: Fix flaxy MessageTransport test

Reviewers: mmendez, Description: Add a delay to make sure the stream is closed before executing the request. Please review this at http://gwt-code-reviews.appspot.com/111808 Affected files: M dev/core/test/com/google/gwt/dev/shell/remoteui/MessageTransportTest.java Index: dev/core/test/

[gwt-contrib] Code Review Request: Send startup URLs over the wire to GPE

Reviewers: jat, mmendez, Description: Send startup URLs over the wire to GPE. The initialization code has now been moved from RemoteUI.initialize to RemoteUI.setStartupURLs. Please review this at http://gwt-code-reviews.appspot.com/111807 Affected files: M dev/core/src/com/google/gwt/dev/DevM

[gwt-contrib] Code Review Request: Add better handling of failure to connect to remote UI

Reviewers: mmendez, jat, Description: Add better handling of failure to connect to remote UI. Instead of printing out the exception, we print out a user-friendly error message. Please review this at http://gwt-code-reviews.appspot.com/111802 Affected files: M dev/core/src/com/google/gwt/dev/D

[gwt-contrib] Code Review Request: Add Info Message To Indicate When a Module Load is Complete

Reviewers: jat, mmendez, Description: Adds an info message to indicate when a module has loaded successfully. As I was writing the code, I noticed that the SwingUI actually has the "loading module xxx" message in the call to getModuleLogger(). Technically, this logging information should be in OO

[gwt-contrib] Code Review Request: Tweaks to enable restart server functionality

Reviewers: kplatfoot, mmendez, Message: Tweaks to get restart server up and running. We now always indicate that we support the RESTART_SERVER capability (checking it was problematic, because it had not been registered at the time of capability exchange). Fixed an issue in MessageTransport where

[gwt-contrib] Code Review Request: Drop Request/Response Logging Levels down to TRACE

Reviewers: jat, mmendez, Description: Drop Request/Response Logging Levels down to TRACE. Please review this at http://gwt-code-reviews.appspot.com/103812 Affected files: M dev/core/src/com/google/gwt/dev/shell/jetty/JettyLauncher.java Index: dev/core/src/com/google/gwt/dev/shell/jetty/Jett

[gwt-contrib] Code Review Request: Updated hosted.html to be pretty

Hi John (and "Hi, contrib group!"), I've been fighting to find just the right incantation to make the missing plugin flow go smoothly. I think it's pretty close now. http://gwt-code-reviews.appspot.com/102815 -- Bruce -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Code Review Request: Add start() method to MessageTransport

Reviewers: mmendez, Description: Adds a start() method to MessageTransport. The message transport threads are no longer started in the constructor; they are only started once the start() method is called. Please review this at http://gwt-code-reviews.appspot.com/102813 Affected files: M dev/c

[gwt-contrib] Code Review Request: Fix DevMode Server Hang on Unclean Shutdown of Remote UI

Reviewers: mmendez, jat, Description: Fixes a problem where the DevMode server was hanging when the remote UI was shut down in an unclean fashion. We now set a keepalive on the Remote UI socket, and when an exception occurs, a callback (passed in to the MessageTransport constructor) is invoked wh

[gwt-contrib] Code Review Request: Make Server and Main TreeLoggers log to Console when using RemoteUI

Reviewers: mmendez, jat, Description: When using the -remoteUI switch, the Main and Server loggers now log their output using a Console-Based TreeLogger (instead of sending these messages over the wire). Also made a change to OOPHMSessionHandler to allow the module logger to be used to log any er

[gwt-contrib] Code Review Request: Make Server and Main TreeLoggers log to Console when using RemoteUI

Reviewers: mmendez, jat, Description: When using the -remoteUI switch, the Main and Server loggers now log their output using a Console-Based TreeLogger (instead of sending these messages over the wire). Also made a change to OOPHMSessionHandler to allow the module logger to be used to log any er

[gwt-contrib] Code Review Request: Addition of clientId and initialization message for the RemoteUI

Reviewers: mmendez, jat, Description: Modified the remote UI protocol to send an initialization message with the client id. The client id is passed in as an argument on the command line. The purpose of this "dance" is to give us a way to associate a running launch configuration with an incoming r

[gwt-contrib] Code Review Request: Using the rebased protobuf library

Reviewers: mmendez, Description: Modifications to the GWT source to support the rebased protobuf library. Most of the changes were related to licensing information. The major code change was the replacement of all references to com.google.protobuf within RemoteMessageProto.java to com.google.gwt

[gwt-contrib] Code Review Request: Merge remote-ui-communication down into trunk

Reviewers: mmendez, Description: Merges the remote-ui-communication branch down into trunk. The command that I used for the merge was: svn merge -r6376:6431 --ignore-ancestry https://google-web-toolkit.googlecode.com/svn/branches/remote-ui-communication r6376 was where the branch was created.

[gwt-contrib] Code Review Request: Removal of the "do-not-commit-to-trunk" libs

Reviewers: mmendez, Message: Committed as r6428. Description: Removing this directory from the branch in preparation for a merge to trunk. Issue #83803 places these jars in the tools directory proper. I'll be committing this CL as as a tbr to mmendez. Please review this at http://gwt-code-rev

[gwt-contrib] Code Review Request: Addition of the non-jarjared protobuf lib to tools

Reviewers: mmendez, Description: Addition of the non-protobuf lib to the tools directory. This jar will change for the RC, as we'll be jarjaring it. I'll be committing this with a TBR to mmendez shortly. Please review this at http://gwt-code-reviews.appspot.com/83803 Affected files: lib/pro

[gwt-contrib] Code Review Request: Implementation of the RemoteUI [Updated]

Reviewers: mmendez, Description: Implementation of remote UI, including a Tree Logger that logs messages over the network. Adds an arg handler to GWT for the -remoteUI argument. The "Restart Web Server" functionality is untested, as we did not implement the DevModeServiceClient on the plugin sid

[gwt-contrib] Code Review Request: Implementation of RemoteUI

Reviewers: mmendez, Description: This patch depends on rietveld issue #80805. Modified remotemessage.proto: -Defined the SERVER log type; got rid of the BROWSER log type (BROWSER was the same as module) -Moved the ViewerRequest and DevModeRequest enums to be top-level, so that they could be used

[gwt-contrib] Code Review Request: Addition of the DevModeService Server

Reviewers: mmendez, Description: Added DevModeServiceServer. Implements request handling for DevModeService. Needed to add a skeleton RemoteUI class as well; it still needs to be filled in. The implementation of DevModeServiceServer made me realize that I was missing capability exchange message

[gwt-contrib] Code Review Request: Addition of the Message Transport API

Reviewers: mmendez, Description: Added DevModeServiceServer. Implements request handling for DevModeService requests. Needed to add a skeleton RemoteUI class as well; it still needs to be filled in. The implementation of DevModeServiceServer made me realize that I was missing capability exchang

[gwt-contrib] Code Review Request: Addition of the Message Transport API

Reviewers: mmendez, Description: This patch adds the message transport API that users can use to communicate with the Development Mode Server. Note that all aspects of this have not been tested as yet (this code is slightly different than the code that you tested). I'll run it through a full tes

[gwt-contrib] Code review: import CheckForUpdatesIE6 into unified distro

Hi John, Can you please review this? Start with a clean, updated trunk and do: svn cp https://google-web-toolkit.googlecode.com/svn/trunk/j...@6365 jni svn cp https://google-web-toolkit.googlecode.com/svn/trunk/dev/windows/src/com/google/gwt/dev/shell/i...@6365dev/core/src/com/google/gwt/dev/sh

[gwt-contrib] code review: tempdir isolation for

Eric, this trivial patch should ensure that Ant's crud can't be fouled up by our testing. Can you review, please? Index: common.ant.xml === --- common.ant.xml (revision 5572) +++ common.ant.xml (working copy) @@ -178,7 +

[gwt-contrib] "code" review

Joel, a javadoc tweak for your TBR: http://code.google.com/p/google-web-toolkit/source/detail?r=5237 rjrjr --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Code review: SerializabilityUtil race condition

Hi Bob, Please review the attached patch to fix the SerializabilityUtil race condition. I don't want to commit this until we actually have a failed build that verifies the problem (per the TBR you did over the weekend), but I'd like to have the fix queued up and ready to go as soon as it does pop

[gwt-contrib] code review requested - add JSONP suport

The attached patch for trunk adds JSONP support, for use with cross-site data retrieval, such as GData APIs. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~-

[gwt-contrib] code review requested - allow OpenJDK to compile GWT

OpenJDK has some issues inferring generic types in some cases. There was some attempt to address it , but it turned out to be a partial fix and there was some concern that the older javac was improperly allowing some of these constructs. External user

[gwt-contrib] code review requested - add skeleton of runtime locales test

This just does a couple of tests that need to be fleshed out, but basically just proves that your suggestion of putting a hacked junit.html into a public path of a particular test module works for setting the runtime locale. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~-

[gwt-contrib] code review requested -- remove PlatformSpecific (one less OOPHM overlay class)

The attached patch, relative to trunk r5025, removes PlatformSpecific by moving the pieces of functionality into CheckForUpdates or SwtHostedModeBase -- this gets one fewer class we have to maintain an OOPHM overlay class for. This is split out from the previous patch. -- John A. Tamplin Softwar

[gwt-contrib] code review requested -- add local host name/address to whitelist

The attached patch, relative to trunk r5016, adds the name and address of the local host machine to the whitelist automatically. In addition, it cleans up some cases which were incompletely validated and builds one regex rather than requiring iteration. -- John A. Tamplin Software Engineer (GWT)

[gwt-contrib] code review: You can't GWT.create DateConstants any more

Hey, Bob. A quick and simple one for incubator. rjrjr --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- FixOldCalendarModel-incubator@1559.diff Description: Binary data

[gwt-contrib] Code Review: Add name of class when throwing ClassNotFound exception from JettyLauncher

Scott, Could you review this tiny patch? This just adds some helpful information to a ClassNotFoundException. I found this because I'm reconfiguring my Eclipse environment, using GWT Trunk for the first time in a while. On my first try, I left some stale crumbs in my web.xml config. In this c

[gwt-contrib] code review requested for 1.6 -- add LocaleInfo methods for forward compatibility with trunk

Support for runtime locales was recently added to trunk, which requires user code to not call GWT.create on NumberConstants/DateTimeConstants in order to get the additional functionality. The existence of these interfaces is arguably an internal implementation detail, but some code uses them -- su

[gwt-contrib] Code Review: ValueSpinner, inject style only once

Hi, I noticed that the ValueSpinner has code in the constructor which injects the style (default or user provided). This means it gets injected everytime a ValueSpinner is created. This patch changes this so that the default style only gets injected once. Also it changes from KeyboardListener to

[gwt-contrib] Code Review: Updated SliderBar to use the new event handling

Hi, I added methods to use the new event handling to the Slider Bar. Also I changed to order of the two public interfaces to make CheckStyle happy. Thanks, Uwe --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~

[gwt-contrib] code review requested - merge OOPHM hosted.html

The attached patch, relative to trunk r4600, merges the functionality of OOPHM's hosted.html into the main one so you don't have to switch the deployed hosted.html in -noserver mode depending on whether you are running legacy hosted mode or OOPHM. in addition to applying this patch, do: svn rm dev

[gwt-contrib] Code Review for 1.6: Restore HasChangeEventHandlers to TextBoxBase

Reviewers: jgw, Description: This change restores TextBoxBase's implementation of HasChangeEventHandlers We recently removed TextBox's implementation of HasChangeEventHandlers, reasoning that it was redundant with its implementation of HasValueChange. As I struggle to integrate this change with

[gwt-contrib] Code review: update 1.6 branch-info.txt

Reviewers: jgw, Description: Updates 1.6 branch-info.txt to reflect today's merge (490:4497,4498:4511). () to be updated when merge lands. Note that --accept=postpone has been dropped. svn says there is no such thing. Please review this at http://gwt-code-reviews.appspot.com/2011 Affected

[gwt-contrib] Code review: merge 1.6 to trunk

Reviewers: jgw, Description: svn merge -r4490:4497 https://google-web-toolkit.googlecode.com/svn/releases/1.6 . svn merge -r4498:4511 https://google-web-toolkit.googlecode.com/svn/releases/1.6 . Note that we skip 4498 which was previously cherry picked (tmp dir fix), and 4499 (the merge of the c

[gwt-contrib] Code Review for 1.6: Removes unused HasHandlers#isEventHandled

Reviewers: jgw, ecc, Description: This patch gets rid of the unused isEventHandled call on the new HasHandlers interface. It is meant to be applied to the releases/1.6 branch. Please review this at http://gwt-code-reviews.appspot.com/2209 Affected files: user/src/com/google/gwt/event/shared/

[gwt-contrib] Code Review Request - Updated style themes

Emily - Please do a code on the following change: http://code.google.com/p/google-web-toolkit/source/detail?r=4487 This change replaces the use of AlphaImageLoader in the GWT style themes with references to the new single-bit (hard edged) versions of the background images. IE7 still uses the mul

[gwt-contrib] Code Review Request: Add createApplication method to WebAppCreator that accepts an Eclipse Project Name as an Argument

Hi Scott, I'd like to you do a code review. To apply this patch, navigate to the the root of the GWT 1.6 releases branch, and perform the following steps: svn update -r4449 patch -p0 < updatedWebAppCreatorWithProjectNameParam-r4449.patch Description: In the migration from ApplicationCreator to

[gwt-contrib] code review requested for 1.6 - refactor hosted mode classes to ease future merges into trunk

The attached patch, relative to 1.6 at r4407 (but see below), adds another layer between HostedModeBase and its subclasses which encapsulates the SWT dependencies from HostedModeBase into a new SwtHostedModeBase. The problem is that HostedModeBase currently pulls in SWT in its clinit, which causes

[gwt-contrib] code review requested for 1.6 - hosted mode speedups

The attached patch, relative to releases/1.6 at r4381, improves hosted mode performance by caching frequently referenced data. The cost is a few hundred kilobytes of memory for a large GWT application and provides refresh speedups of approximately 14% (with similar time savings for hosted mode sta

[gwt-contrib] Code review request, Creating gen2 versions of Time and Date Spinner to use the new 1.6 datepicker and event system

Dear Daniel, I hope you are having a great holiday. I've added a gen2 version of TimePicker and DatePickerPicker in a new com.google.gwt.gen2.picker package. It now depends upon the gwt 1.6 date picker and event system. If you could review my changes and make any more you deem appropriate, th

[gwt-contrib] code review requested - fixup permutation IDs

The attached patch, relative to 1.6 r4353, renumbers the permutation IDs at the end of the precompile phase to be consecutive and in order. This is important because in CompilePerms, the arguments to -perms are indices into this array, while the output of the compiles are permutation-ID.js files.

[gwt-contrib] Code review, renaming logging property for gen2 widgets.

John, could you review the following change? GWT has a fatal error if you try to redefine the same property twice. This means that gen2 logging and libideas.logging cannot live side by side, it also spells trouble for any project using gwt-log or other solutions. This code change renames the logg

[gwt-contrib] Code review for Issue 3194:Need to deprecate SourcesXXXEvents interfaces so we can remove them later

Reviewers: jlabanca, Description: Issue details at:http://code.google.com/p/google-web-toolkit/issues/detail?id=3194&q=owner:ecc&sort=priority Please review this at http://gwt-code-reviews.appspot.com/607 Affected files: user/src/com/google/gwt/user/client/ui/FiresDisclosureEvents.java us

[gwt-contrib] Code review, adding gwt-externals to gwt incubator

Amit, could you review this change? Adding gwt-externals directory to gwt-incubator trunk in order to support the use of gwt's build-tools directory. Change at: http://code.google.com/p/google-web-toolkit-incubator/source/detail?r=1302 Thanks, Emily -- "There are only 10 types

[gwt-contrib] Code Review Request - Windows distro build file error

Freeland - Please do a code review on this patch that fixes the windows distro build file. Description: = does not support the , at least on my machine. This looks like a typo, Fix: === Changed to , which is consistent with the rest of the file. Testing: == Building using "ant" n

[gwt-contrib] Code Review: Removing spurious warning in BrowerManagerServer

Hi Scott, John observed that the messages coming out of Browser ManagerServer draw too much attention to the bad status value returned when the browser exits. In fact, non-zero exits are the normal way all the browsers we test return, so there is no use alarming them. Note: Even if we do decide

[gwt-contrib] Code review request for blocking mouse leave/enter events in some cases

Reviewers: jlabanca, Description: Code review request for gwt issue (3189) Fixes the default Widget code to not trigger mouse enter/leave events when the user did not actually leave or enter the widget. http://code.google.com/p/google-web-toolkit/issues/detail?id=3189 Please review this at htt

[gwt-contrib] Code review: Allow setValue(null) on TextBoxBase, be clearer null-is-bad on CheckBox

Reviewers: ajr, Description: This is intended for 1.6. We decided that setValue(null) is okay for emptying things, but I neglected to inform TextBoxBase of this fact. This gets in the way of the 1_6_datepicker merge, where the test that null is okay was written (I know, I know). At the same time

[gwt-contrib] code review request: Making all the gwt Has*Handlers interfaces extend HasHandlers

Ray, Can you review this change? Some of the firing code becomes easier to create if, by policy, all the gwt has handlers classes extend HasHandlers. Change: http://code.google.com/p/google-web-toolkit/source/detail?r=4249 -- "There are only 10 types of people in the world: Those who understa

[gwt-contrib] Code review: LazyPanelExample tweaks

Per your review feedback, lowered cuteness and explained setVisible(false) call. rjrjr --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- less-silly-LazyPanelExample-1.6-r4222

[gwt-contrib] Code Review requested on DateBox

Hey, John. This is not small, I'm afraid, but it's not outrageous either. It's already committed to the 1_6_date_picker branch, and can be reviewed there. http://code.google.com/p/google-web-toolkit/source/detail?r=4165 >From the change log: Makes DateBox implement ValueChange, and makes it, lik

[gwt-contrib] Code review on date picker branch to date

General comments It seems like there is a lot of overlap between DatePicker and CalendarView. Should the methods in DatePicker that are redundant with CalendarView methods be stricken, given DatePicker#getCalendarView? Or, should getCalendarView perhaps go away, or become protected or package--is

[gwt-contrib] code review: tweaks to JsHandlerRegistry.

Freeland, Could you review the following patch? It bumps the number of handlers that can be stored without creating a new list from 5 to 10 and it replaces a createObject() call with the somewhat more efficient createArray() call. -- "There are only 10 types of people in the world:

[gwt-contrib] Code Review: Merging releases/1.5 into releases/1.6 to pick up reference/dispatch

...ping... On Tue, Nov 18, 2008 at 12:31 AM, Ray Ryan <[EMAIL PROTECTED]> wrote: > This is step two of three of committing your event dispatch benchmark. Step > one was checking the 1.5 version into releases/1.5/reference/dispatch. Now > I'm merging that into releases/1.6. The third and final ste

[gwt-contrib] Code Review: Issue 206 in gwt-google-apis - allow 3rd party extensions to be wrapped

Hello Uwe, and Daniel and Miguel, Could you please review this update to the Maps API at: http://galgwt-reviews.appspot.com/803 It should be the last one before the release of the "final" 1.0 for Maps. -Eric. -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://code.google.com/webtoolkit/

[gwt-contrib] Code review: patch to allow logging RPC requests

Hi all. Attached is a patch that allows intercepting an RPCRequest object on any servlet before the actual method is called with it and also adds a toString method to that class - this allows nice things like logging the full request being made. Please consider it for inclusion in the trunk. T

[gwt-contrib] Code Review:

Hi Uwe, I'd like for you to review the attached patch to the gwt-maps API. The LatLngBounds.newInstance() method was missing a pair of parenthesis inside the native method body. M maps/test/com/google/gwt/maps/client/geom/LatLngBoundsTest.java M maps/src/com/google/gwt/maps/client/geom

[gwt-contrib] code review requested, issue 2257

On Tue, Oct 28, 2008 at 6:07 AM, stuckagain <[EMAIL PROTECTED]> wrote: > Now that I am migrating to 1.5, I noticed this bug for example: (one > that I reported some time ago): > http://code.google.com/p/google-web-toolkit/issues/detail?id=2257&can=4 > > It is marked as new, and targeted for 1.5_RC

[gwt-contrib] code review requested, allow i18n class-level annotations to be inherited

The attached patch, relative to trunk r3808 (but destined for releases/1.6) adds the ability for class-based annotations to be inherited for i18n. For example, this would allow you to specify a project-wide set of defaults for these annotations and have each message interface get those defaults by

[gwt-contrib] Code Review: gwt-google-apis Maps Add version check

Hi Miguel, Could you please review this patch? It is very small! I am currently running into issues with maps regression tests failing due to some problems with the Maps JavaScript API. The Maps JavaScript API can be configured to return the "current" version, either stable or experimental. When

[gwt-contrib] Code Review: gwt-google-apis updated sample

Hi Bob, I'd like for you to review this patch that replaces the "Hello Gadgets" sample with a prettier/simpler "Hello World" based on the sample app that comes up when you create a new project with projectCreator. One unresolved issue is that the standard GWT themes don't work with gadgets, as th

[gwt-contrib] code review requested, i18n lookup for nested classes

Please review this patch, relative to trunk at r3808. Consider the following: public interface A extends Messages { public interface B extends Messages { @DefaultMessage("foo") String foo(); } } Currently, the translations for the foo method are looked up in files named A$B_locale.

[gwt-contrib] code review requested, TypeSerializerCreator bug introduced in cleaning up sharding changes

Please review the following patch, relative to trunk r3728, which fixes a bug that slipped through when I cleaned up the methodMap sharding in TypeSerializerCreator to commit to trunk. -- John A. Tamplin Software Engineer (GWT), Google --~--~-~--~~~---~--~~ http:/

[gwt-contrib] Code Review: visualization Adds launch scripts to the HelloVisualization demo

Hello Uwe, Attached is a patch that adds launch scripts to the HelloVisualization sample. You have to build the project with 'ant', then the launch scripts get bundled into the staging directory and build/dist/gwt-visualization-0.0.0.tar.gz. If you decompress the tar file, the launch scripts are

[gwt-contrib] Code Review: gwt-google-apis gears WorkerPoolDemo UI cleanups

This patch cleans up the UI a bit for the worker pool demo. I struggled a but getting the animation to look roughly centered in the vertical panel - in the end I punted and used an AbsolutePanel. M samples/workerpool/src/com/google/gwt/gears/sample/workerpool/client/WorkerPoolDemo.java M samples/

[gwt-contrib] Code Review: gwt-google-apis maps Formatting and comment cleanup

Hello Miguel, Would you mind reviewing the attached patch? It only changes comments and formatting. The API suffered through a long bout of build breakage. While debugging it, I ran across some comments that were not at all clear in the Maps Test. relative to releases/maps/1.0 branch in subver

[gwt-contrib] Code Review Request - disabled XMLTest.testParse() in the 1.5 branch

John - Please do a code review on this patch that disables XMLTest.testParse(). It fails on Safari in web mode in the 1.5 branch, but it passes on all other configs. The files in the xml package in the 1.5 branch are identical to the files in the trunk. Thanks, John LaBanca [EMAIL PROTECTED] -

[gwt-contrib] code review requested for 1.5, issues 2836, 2894, 2911 - various I18NSync issues

Please review this change for 1.5.3 which fixes a number of small issues. The patch is larger than you might expect because it includes parts copied from elsewhere (and then simplified) for choosing what characters to quote and how to quote them, but at this point I felt it was safer to copy them t

[gwt-contrib] Code Review: Visualization API, improved hello world example

Hi, I added a TabPanel to the hello world example, with a tab for each example. I added an example for the new DataView. Thanks, Uwe --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--

[gwt-contrib] Code Review: Visualization API, added DataView

Hi, I added the new DataView class that allows read only access to a DataTable for selected columns. Thanks, Uwe --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- Index: visu

[gwt-contrib] Code Review: gwt-google-apis gears Add support for message types other than String()

Hi Miguel, I would like for you to review the attached patch. We discussed them earlier as a part of the WorkerPool demo. It adds support for message types other than string. M gears/test/com/google/gwt/gears/client/workerpool/WorkerPoolTest.java M gears/src/com/google/gwt/gears/clien

[gwt-contrib] Code Review: gwt-google-apis Maps issue 156 - exception when closing infowindow - take 2

Hello Joel, I would like for you to review the attached patch that addresses gwt-google-apis issue 156 and 181 in the Maps API: http://code.google.com/p/gwt-google-apis/issues/detail?id=156 http://code.google.com/p/gwt-google-apis/issues/detail?id=181 I worked on this issue with you previously

[gwt-contrib] Code Review: gwt-google-apis gears Make DatabaseDemo even prettier

Hello Amit, Thanks for your observations and improvements of the DatabaseDemo to use an AUTOINCREMENT key. Could you please review the attached patch that revises the one you sent me earlier? This patch updates the DatabaseDemo with the following modifications: - Uses better SQL coding style -

[gwt-contrib] code review requested for 1.5 branch, FF3 getAbsoluteTop/Left

On FF3, these routines can return a non-integer, which can result in warnings in hosted mode (seen with OOPHM) and potential errors in web mode as the function is declared to return an int. The fix is to coerce the value to int in the FF3 code-path. This may also be related to issue 2891

[gwt-contrib] code review requested for 1.5 branch, RPC quoting, issues 1137, 1906, and more

The attached patch, relative to releases/1.5 r3731, fixes a number of RPC quoting issues and adds more robust tests. In addition to the listed issues, this fixes problems with RPC working at all in the Android WebKit browser, or for sending serialized responses via IE form post (which mangles the

[gwt-contrib] Code Review: gwt-google-apis gears

Hello Miguel, This patch pretties up the sample for ManagedResourceStore in a similar way to the previous patch for the ResourceStoreDemo. - Add a margin. - Add some spacing between the buttons. - Toggle the enabled state of the buttons. M samples/managedresourcestore/src/com/google/gwt/ge

[gwt-contrib] Code Review: gwt-google-apis gears Making ResouceStore demo a bit prettier

Hello Miguel, I'd like for you to review the attached patch (& screenshot) It changes the layout of the demo just a bit to put some margin around the outside. It also adds code to toggle the enable/disable state of the buttons to match the user's actions. M samples/resourcestore/src/com/go

[gwt-contrib] Code Review Request - Porting Tree fixes to GWT 1.5 branch

Emily - Can you review the attached patch that has two Tree fixes for the 1.5 branch? Please verify that this patch captures both of the fixes in, which have already been committed to trunk: http://code.google.com/p/google-web-toolkit/issues/detail?id=2853 http://code.google.com/p/google-web-tool

[gwt-contrib] Code Review: gwt-google-apis gears fix typo in method name.

Hi Miguel, This patch addresses issue 183, a typo in a method name: http://code.google.com/p/gwt-google-apis/issues/detail?id=183 I renamed the method in the library class and updated the test. M test/com/google/gwt/gears/client/localserver/LocalServerTest.java M src/com/google/gwt/gears/clien

[gwt-contrib] Code Review: gwt-google-apis maps Status Code not translated - issue 189

Hello Miguel, Here is another patch I'd like for you to review. It addresses issue 189 in the issue tracker: http://code.google.com/p/gwt-google-apis/issues/detail?id=189 The problem was very easy to solve, but I went ahead and added some more unit testing and eliminated some warnings from a

[gwt-contrib] code review requested, XPCOM FF plugin, Swing UI additions

The XPCOM plugin passes all the tests and seems stable, so I think it is ready to merge into the main OOPHM branch. There is one remaining issue, which is ant test fails on UISuite, which looks like somehow we are pulling in old classes as it is an IncompatibleClassChangeException, but when run fr

[gwt-contrib] [Code Review] Small Test Framework For JJS Optimizers

Hi! I created a small test framework for jjs optimizers. I've also attached a small test for MethodInliner to show how it looks like. Patch stats: .../com/google/gwt/dev/jjs/impl/MethodInliner.java | 11 +- .../gwt/dev/jjs/impl/JJSOptimizerTestCase.java | 195 .../gw

[gwt-contrib] Code Review: In JSIO, coerce null, undefined boolean values to false

(This issue was previously discussed in a thread with the subject: RR: Hosted mode accepts 'undefined' or 'null' for booleanprimitive type) Hello Bob, I would like for you to review the attached patch which addresses a problem in hosted mode that is kind of tricky to work around. gwt-google-apis i

[gwt-contrib] code review requested, shard TypeSerializerCreator createMethodMap

[fix bad GWTC address] Please review the attached patch for trunk, which fixes a hosted mode crash with a large set of serializable types. On Linux hosted mode, a very large list of serializable types can cause a crash inside Mozilla. This appears to be related to the size of the JSNI function b

[gwt-contrib] Code Review: correct Overlay.createPeer()

Hello Miguel, I would like for you to review the attached patch. I used the wrong constructor in a native method when implemening Overlay.createPeer(). I corrected the mistake and finished off the set of unit tests for Overlay.createPeer(). M maps/test/com/google/gwt/maps/client/overlay/Ov

[gwt-contrib] Code Review: remove 'final' modifier from MarkerOptions class

Hello Miguel, Could you please review the attached patch? I've already committed it as r857. This was brought to my attention from a gwt-maps developer that attended Google Developer Day in Madrid (Alberto Núñez) M maps/src/com/google/gwt/maps/client/overlay/MarkerOptions.java -- Eric Z.

[gwt-contrib] Code Review Request - Issue 2527 - Add TabBar.setTabEnabled() method

Emily - Another request... Description: = It would be nice to be able to programatically enable/disabled tabs in a TabBar, preventing user's from selecting the tab. Fix: === I added a TabBar.setTabEnabled(int index, boolean enabled) method and a TabBar.isTabEnabled(int index) method. I

[gwt-contrib] Code Review Request - Issue 32 - form.reset method

Alex - Issue 32! Why haven't we addressed this simple fix yet? Description: We need a FormPanel.reset() method to programatically reset a form. Fix: === Added it. All browsers support form.reset() natively, so this is a trivial addition. Testing: == Manually tested on all main br

[gwt-contrib] code review: svninfo task, to allow ant 1.6.5

It seems that getting ant 1.6.5 (which, although old, is still the basis of what's in our tools stuff) is known not to like my forms, so here's a rework of that as a custom AntTask. Scott will be glad to know that the build file stuff we thrashed through isn't changed, it's just a reimplementatio

[gwt-contrib] Code Review: gwt-google-apis Search LocalSearch.getCenterPoint() accepts Maps LatLng

Hello Miguel, This patch adds an overload to LocalSearch.setCenterPoint() to accept a JavaScriptObject parameter. It can be either a raw GLatLng or GMap2 object, or it can be a LatLng object from the gwt-maps API (which is just a Java overlay type for GLatLng). I tested this manually by creati

[gwt-contrib] Code Review Request - Issue 2667 - Style should assert that property names do not contain hyphens

Joel - Please do a code review for this Style enhancement. Description: When setting style properties programatically in GWT, it would be nice to assert that the styles do not contain hyphens so people don't accidently use names like "margin-left" instead of "marginLeft". Fix: === This

[gwt-contrib] Code Review: gwt-google-apis Maps release notes

Hello Miguel, Here are changes to the release notes for the Maps RC1 release. The only thing we might add that might be release note worthy is the retrieval of the Google Earth plugin object. M maps/distro-source/src/release_notes.html -- Eric Z. Ayers - GWT Team - Atlanta, GA USA http://

  1   2   >