Re: [gwt-contrib] Add Object.clone as throwing implementation

2014-06-17 Thread Rocco De Angelis
Some news regarding the your tests? Am Montag, 26. Mai 2014 17:10:09 UTC+2 schrieb Daniel Kurka: I rolled the patch because it broke internal apps and it seemed to hard and not worthwhile to clean this up. I just imported the change and running some tests internally I get back once I can

Re: [gwt-contrib] Add Object.clone as throwing implementation

2014-05-27 Thread Rocco De Angelis
Hi Roberto, okay I understand the problem. But is it really necessary to also add the clone method to JSO? Implementing a clone method for objects in javaScript can be very hard if it should work in all cases :) -- You received this message because you are subscribed to the Google Groups GWT

[gwt-contrib] Add Object.clone as throwing implementation

2014-05-26 Thread Rocco De Angelis
Hi all, I would like to added a clone method to the java.lang.Object class in the GWT SDK which simply throws a CloneNotSupportedException. This makes it possible to implement the clone method in subclasses. See: https://gwt-review.googlesource.com/#/c/6035/ Daniel Kurka has already done a

Re: [gwt-contrib] Add Object.clone as throwing implementation

2014-05-26 Thread 'Daniel Kurka' via GWT Contributors
I rolled the patch because it broke internal apps and it seemed to hard and not worthwhile to clean this up. I just imported the change and running some tests internally I get back once I can see what needs to be done. On Mon, May 26, 2014 at 11:37 AM, Rocco De Angelis

[gwt-contrib] Add Object.clone as throwing implementation

2014-05-26 Thread Patrick Tucker
I wish Java's Object didn't implement Cloneable, seems crazy to implement an interface that you don't actually implement. -- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send

Re: [gwt-contrib] Add Object.clone as throwing implementation

2014-05-26 Thread 'Roberto Lublinerman' via GWT Contributors
The problem with implementing clone() at object is that it is an breaking change because of the rules for JSOs. JSOs are required to implement (and declare final) all Object methods because there is no dynamic dispatch. So having clone() at Object implies either implementing it in JavaScriptObject