[gwt-contrib] Re: - Extended the a11y role API with methods that have UIObject parameter. (issue1828804)

2012-09-12 Thread t . broyer
I haven't looked at the changes (from the description, they should be simple and straightforward) but what bothers me is that it introduces a cyclic dependency: c.g.g.user depends on c.g.g.aria which now also depends on c.g.g.user. Also, that dependency isn't reflected in the .gwt.xml (so one

[gwt-contrib] Re: - Extended the a11y role API with methods that have UIObject parameter. (issue1828804)

2012-09-12 Thread skybrian
We've decided against this change for now (increases the size of the API too much). A HasElement interface sounds somewhat reasonable but we can add that later if needed. I suppose if Element implemented HasElement, returning itself, we could avoid doubling the number of methods, but this seems

[gwt-contrib] Re: - Extended the a11y role API with methods that have UIObject parameter. (issue1828804)

2012-09-12 Thread t . broyer
On 2012/09/12 19:18:12, skybrian wrote: We've decided against this change for now (increases the size of the API too much). A HasElement interface sounds somewhat reasonable but we can add that later if needed. I suppose if Element implemented HasElement, returning itself, we could avoid

[gwt-contrib] Re: - Extended the a11y role API with methods that have UIObject parameter. (issue1828804)

2012-09-12 Thread skybrian
Hmm. If it were named HasAriaElement, then it would make sense that not all widgets implement it. Only those that need to be customized for proper Aria support would have it. http://gwt-code-reviews.appspot.com/1828804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors