[gwt-contrib] Re: Add a warning in GWTTestCase to help users that accidentally run a GWT JUnit Test as a JUnit Test. (issue1224801)

2010-12-21 Thread pdr
http://gwt-code-reviews.appspot.com/1224801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a warning in GWTTestCase to help users that accidentally run a GWT JUnit Test as a JUnit Test. (issue1224801)

2010-12-21 Thread pdr
http://gwt-code-reviews.appspot.com/1224801/diff/1/2 File user/src/com/google/gwt/junit/client/GWTTestCase.java (right): http://gwt-code-reviews.appspot.com/1224801/diff/1/2#newcode445 user/src/com/google/gwt/junit/client/GWTTestCase.java:445: // Check to see if gwt.devjar is null. If so,

Re: [gwt-contrib] Re: Add a warning in GWTTestCase to help users that accidentally run a GWT JUnit Test as a JUnit Test. (issue1224801)

2010-12-21 Thread John Tamplin
On Tue, Dec 21, 2010 at 11:09 AM, p...@google.com wrote: On 2010/12/16 19:43:39, rdayal wrote: Is this system property required? This is a tough one, because I don't think it's strictly required, but the devjar has things such as the GWT devmode bridge and the GWT compiler. Can you think

[gwt-contrib] Re: Add a warning in GWTTestCase to help users that accidentally run a GWT JUnit Test as a JUnit Test. (issue1224801)

2010-12-16 Thread jlabanca
LGTM http://gwt-code-reviews.appspot.com/1224801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add a warning in GWTTestCase to help users that accidentally run a GWT JUnit Test as a JUnit Test. (issue1224801)

2010-12-16 Thread rdayal
Thanks for looking into this. A couple of questions/comments before I give the LGTM.. http://gwt-code-reviews.appspot.com/1224801/diff/1/2 File user/src/com/google/gwt/junit/client/GWTTestCase.java (right): http://gwt-code-reviews.appspot.com/1224801/diff/1/2#newcode445