[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-09-01 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-09-01 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-31 Thread bobv
The formatting in these files looks really off, looking at the indentation of the string concatenation code. Ray says not to hold this up on the DocumentFragment stuff. LGTM if you fix the formatter. http://gwt-code-reviews.appspot.com/794801/diff/32001/33001 File

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-27 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java (left): http://gwt-code-reviews.appspot.com/794801/diff/1/2#oldcode9 dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java:9: * On 2010/08/24 15:18:18, bobv

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-27 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-27 Thread rjrjr
http://gwt-code-reviews.appspot.com/794801/diff/14001/13004 File user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java (right): http://gwt-code-reviews.appspot.com/794801/diff/14001/13004#newcode79 user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java:79:

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-27 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-27 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-27 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-27 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/diff/14001/13004 File user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java (right): http://gwt-code-reviews.appspot.com/794801/diff/14001/13004#newcode79 user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java:79:

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-26 Thread rjrjr
http://gwt-code-reviews.appspot.com/794801/diff/14001/13003 File user/src/com/google/gwt/uibinder/client/UiChild.java (right): http://gwt-code-reviews.appspot.com/794801/diff/14001/13003#newcode29 user/src/com/google/gwt/uibinder/client/UiChild.java:29: * safely called. If no limit is

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-25 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-25 Thread bobv
http://gwt-code-reviews.appspot.com/794801/diff/8001/9001 File dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java (right): http://gwt-code-reviews.appspot.com/794801/diff/8001/9001#newcode43 dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java:43: DESC_FLOAT, 0.0);

[gwt-contrib] Re: Add ability to use @UiChild annotation to specify how GWT should add a child element. (issue794801)

2010-08-25 Thread sonnyf
http://gwt-code-reviews.appspot.com/794801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors