http://gwt-code-reviews.appspot.com/794801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/794801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
The formatting in these files looks really off, looking at the
indentation of the string concatenation code.
Ray says not to hold this up on the DocumentFragment stuff.
LGTM if you fix the formatter.
http://gwt-code-reviews.appspot.com/794801/diff/32001/33001
File
http://gwt-code-reviews.appspot.com/794801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java
(left):
http://gwt-code-reviews.appspot.com/794801/diff/1/2#oldcode9
dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java:9: *
On 2010/08/24 15:18:18, bobv
http://gwt-code-reviews.appspot.com/794801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/794801/diff/14001/13004
File user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
(right):
http://gwt-code-reviews.appspot.com/794801/diff/14001/13004#newcode79
user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java:79:
http://gwt-code-reviews.appspot.com/794801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/794801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/794801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/794801/diff/14001/13004
File user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java
(right):
http://gwt-code-reviews.appspot.com/794801/diff/14001/13004#newcode79
user/src/com/google/gwt/uibinder/elementparsers/UiChildParser.java:79:
http://gwt-code-reviews.appspot.com/794801/diff/14001/13003
File user/src/com/google/gwt/uibinder/client/UiChild.java (right):
http://gwt-code-reviews.appspot.com/794801/diff/14001/13003#newcode29
user/src/com/google/gwt/uibinder/client/UiChild.java:29: * safely
called. If no limit is
http://gwt-code-reviews.appspot.com/794801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/794801/diff/8001/9001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java
(right):
http://gwt-code-reviews.appspot.com/794801/diff/8001/9001#newcode43
dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java:43:
DESC_FLOAT, 0.0);
http://gwt-code-reviews.appspot.com/794801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
14 matches
Mail list logo