[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-25 Thread unnurg
http://gwt-code-reviews.appspot.com/1310801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-25 Thread unnurg
http://gwt-code-reviews.appspot.com/1310801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-25 Thread unnurg
http://gwt-code-reviews.appspot.com/1310801/diff/24001/25002 File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right): http://gwt-code-reviews.appspot.com/1310801/diff/24001/25002#newcode39 user/src/com/google/gwt/jsonp/client/JsonpRequest.java:39: On 2011/01/25 19:49:32, bobv wrote:

[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-25 Thread unnurg
http://gwt-code-reviews.appspot.com/1310801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-25 Thread bobv
LGTM, nits. Once the JSONP stuff is shown to work in production, can you swing back around and remove the XHR? http://gwt-code-reviews.appspot.com/1310801/diff/24001/25002 File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right): http://gwt-code-reviews.appspot.com/1310801/diff/240

[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-25 Thread unnurg
http://gwt-code-reviews.appspot.com/1310801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-25 Thread unnurg
http://gwt-code-reviews.appspot.com/1310801/diff/1/3 File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right): http://gwt-code-reviews.appspot.com/1310801/diff/1/3#newcode70 user/src/com/google/gwt/jsonp/client/JsonpRequest.java:70: } On 2011/01/24 14:31:26, bobv wrote: Extra whitesp

[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-24 Thread unnurg
http://gwt-code-reviews.appspot.com/1310801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-24 Thread unnurg
http://gwt-code-reviews.appspot.com/1310801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Add option to use JSONP in ExternalTextResource (issue1310801)

2011-01-24 Thread bobv
Why maintain both modes of operation? There's more code and more stuff to test when JSONP is a more general solution than XHR. http://gwt-code-reviews.appspot.com/1310801/diff/1/3 File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right): http://gwt-code-reviews.appspot.com/1310801/di