LGTM, just a couple of code style nits I saw re-reading the patch.
http://gwt-code-reviews.appspot.com/714801/diff/48001/6003
File user/src/com/google/gwt/resources/client/DataResource.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/48001/6003#newcode35
Thanks, Bob
http://gwt-code-reviews.appspot.com/714801/diff/48001/6003
File user/src/com/google/gwt/resources/client/DataResource.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/48001/6003#newcode35
user/src/com/google/gwt/resources/client/DataResource.java:35: *
Specifies the
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM with minor changes.
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001
File user/src/com/google/gwt/resources/client/DataResource.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001#newcode41
user/src/com/google/gwt/resources/client/DataResource.java:41:
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001
File user/src/com/google/gwt/resources/client/DataResource.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001#newcode41
user/src/com/google/gwt/resources/client/DataResource.java:41: public
@interface DoNotEmbed
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/714801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/714801/diff/3001/4001
File user/src/com/google/gwt/resources/client/ClientBundle.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/3001/4001#newcode2
user/src/com/google/gwt/resources/client/ClientBundle.java:2: *
Copyright 2010 Google Inc.
On
12 matches
Mail list logo