Thanks, Isaac. If only it allowed us to have separate newline rules for
annotations on fields vs. methods. Unfortunately, turning off newlines for
annotations on "members" would have this unfortunate side-effect:
@Whatever @SomethingBig("blah") void foo() {
}
I'm not sure, but I think the cure mig
Hey guys,
>> The autoformater will change this to
>
>>@UiField
>>Button closeButton;
>
>> which sucks. I want to fix that for annoations with no arguments, but
> have no
>> idea how to. You have any clue to share?
>
> Bugs the crap out of me too. I can't find any annotation-related
> sett
Committed at r6192.
http://gwt-code-reviews.appspot.com/68805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Still LGTM
I mean one rethrow nit below HERE
http://gwt-code-reviews.appspot.com/68805/diff/1/24
File user/src/com/google/gwt/uibinder/parsers/DockLayoutPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/68805/diff/1/24#newcode115
Line 115: writer.die("Unexpected: Unable to find %s t
LGTM, one rethrow nit below.
http://gwt-code-reviews.appspot.com/68805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Argh, off-rietveld comment!
Anyway, that's exactly what I meant. You can add any number of children, in
any order and direction, like so:
...
...
...
...
...
...
...
On Tue, Sep 22, 2009 at 5:10 PM, Ray Ryan wrote:
> You misunderstood my question:
>
>> Also, is it legal to have
You misunderstood my question:
> Also, is it legal to have more than one child of a particular direction?
It is indeed legal to have more than one widget in a direction, in
any order.
What I meant to ask was what happens in this case:
Feeling northern.
Me too.
--~--~
http://gwt-code-reviews.appspot.com/68805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
http://gwt-code-reviews.appspot.com/68805/diff/1/3
File samples/mail/src/com/google/gwt/sample/mail/client/AboutDialog.java
(right):
http://gwt-code-reviews.appspot.com/68805/diff/1/3#newcode38
Line 38: @UiField Button closeButton;
On 2009/09/22 20:12:42, Ray Ryan wrote:
> The autoformater will
Addressed individual comments. How about we leave off the
consumeAttribute() thing for a moment, as you suggest, and then I fix it
in a subsequent patch?
http://gwt-code-reviews.appspot.com/68805
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Tool
So excited to see this going in!
Are you going to do the XMLAttribute#consume fix in this patch? I'd be
okay with that happening in a follow on, this is already pretty beefy.
Please do make a pass across your die() calls, though, to make sure they
all do something like die("In %s, you screwed up
I was going to ask you. Yeah, I think it makes sense. Might as well keep the
JParam method as a convenience?
On Tue, Sep 22, 2009 at 12:38 PM, wrote:
> Assuming we make parsing attributes using AttributeParsers required
> (which makes perfect sense to me), I think we'll need to change
> writer.g
On Tue, Sep 22, 2009 at 12:23 PM, wrote:
> On 2009/09/22 18:59:16, Ray Ryan wrote:
>
>> I'm still reviewing, but I thought I should get this AttributeParser
>>
> issue in
>
>> front of you early.
>>
>
> http://gwt-code-reviews.appspot.com/68805/diff/1/24
>> File
>>
> user/src/com/google/gwt/uibi
Assuming we make parsing attributes using AttributeParsers required
(which makes perfect sense to me), I think we'll need to change
writer.getAttributeParser(JParam...) to take (JType...) instead. This
method only ever uses the types of the parameters, and many consumers of
attributes aren't actua
On 2009/09/22 18:59:16, Ray Ryan wrote:
> I'm still reviewing, but I thought I should get this AttributeParser
issue in
> front of you early.
> http://gwt-code-reviews.appspot.com/68805/diff/1/24
> File
user/src/com/google/gwt/uibinder/parsers/DockLayoutPanelParser.java
> (right):
> http://gwt-c
I'm still reviewing, but I thought I should get this AttributeParser
issue in front of you early.
http://gwt-code-reviews.appspot.com/68805/diff/1/24
File user/src/com/google/gwt/uibinder/parsers/DockLayoutPanelParser.java
(right):
http://gwt-code-reviews.appspot.com/68805/diff/1/24#newcode68
L
16 matches
Mail list logo
