BTW: you should create code reviews at
http://gwt-code-reviews.appspot.com/ instead.
There is a also a TODO to support SafeHtml here. I'm not entirely sure
what that means in this case (Doesn't TextBox already ensure the string
is uninterpreted? Does changing to a ValueBoxBase mean you might
On 2012/09/10 12:03:20, jtamplin wrote:
BTW: you should create code reviews at
http://gwt-code-reviews.appspot.com/
instead.
There is a also a TODO to support SafeHtml here. I'm not entirely
sure what
that means in this case (Doesn't TextBox already ensure the string is
uninterpreted?
LGTM
https://codereview.appspot.com/6492092/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java#newcode878
LGTM
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java
File user/src/com/google/gwt/user/client/ui/SuggestBox.java (right):
https://codereview.appspot.com/6492092/diff/5001/user/src/com/google/gwt/user/client/ui/SuggestBox.java#newcode878
LGTM. I'll commit this soon.
https://codereview.appspot.com/6492092/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
