http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
File
dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/Sour
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
File
dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/Sour
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
File
dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/1/dev/core/src/com/google/gwt/dev/javac/Sour
http://gwt-code-reviews.appspot.com/1461803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Found the reason it fixes it.
The machine I'm testing on is not tuned for lots of files:
[java] Caused by: java.io.FileNotFoundException:
/home/testing/gwt-orig/us\
er/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_eu.java
(Too\
many open files)
[java] at java.io.FileI
Now that's a good answer! So the real is is just to close the result of
sourceFile.openContents()?
I would update the doc on DiskCache.tranferTo/FromStream that they don't
close the stream, and then look at all the callers and make sure they do the
right thing.
On Fri, Jun 24, 2011 at 10:36 PM,
http://gwt-code-reviews.appspot.com/1461803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
(updated patch)
http://gwt-code-reviews.appspot.com/1461803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/1461803/diff/4003/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
File
dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/4003/dev/core/src/com/google/gwt/dev/java
I've seen NPEs in other scenarios, so it seemed worth it to go ahead and
have Resource.openContents let theIOException through so it could be
logged in the most appropriate way.
http://gwt-code-reviews.appspot.com/1461803/diff/4003/dev/core/src/com/google/gwt/dev/javac/SourceFileCompilationUnit.
http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
File dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/src/com/google/gwt/dev/javac/Comp
http://gwt-code-reviews.appspot.com/1461803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I took a stab at including allowing Util.readStreamAsString() to throw
IOException, but I got to a point where I was touching lots of code and
I chickened out on this patch.
The real point of this patch was to fix the bug in not closing the
InputStream, which I need for incremental compile. Maybe
LGTM
http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/test/com/google/gwt/dev/resource/impl/FileResourceTest.java
File
dev/core/test/com/google/gwt/dev/resource/impl/FileResourceTest.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/6002/dev/core/test/com/google/gwt/d
http://gwt-code-reviews.appspot.com/1461803/diff/5004/dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
File dev/core/src/com/google/gwt/dev/javac/CompilationUnitBuilder.java
(right):
http://gwt-code-reviews.appspot.com/1461803/diff/5004/dev/core/src/com/google/gwt/dev/javac/Comp
FHMP
http://gwt-code-reviews.appspot.com/1461803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
16 matches
Mail list logo
