[gwt-contrib] Re: Close MessageTransport socket on error

http://gwt-code-reviews.appspot.com/102803/diff/1/3 File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java (right): http://gwt-code-reviews.appspot.com/102803/diff/1/3#newcode134 Line 134: try { On 2009/11/12 02:27:11, mmendez wrote: > I'm fine to move it, but is there a reason that th

[gwt-contrib] Re: Close MessageTransport socket on error

Thanks Rajeev! Also included Scott's assertion message improvements. Committed as r6859. http://gwt-code-reviews.appspot.com/102803/diff/1/3 File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java (right): http://gwt-code-reviews.appspot.com/102803/diff/1/3#newcode129 Line 129: + e.

[gwt-contrib] Re: Close MessageTransport socket on error

One other thing that I just remembered - it was actually something that I forgot in my last patch. http://gwt-code-reviews.appspot.com/102803/diff/1/3 File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java (right): http://gwt-code-reviews.appspot.com/102803/diff/1/3#newcode129 Line 1

[gwt-contrib] Re: Close MessageTransport socket on error

LGTM. Please note the comment below. I guess after this lands, there will be a follow-up CL which updates the transport jar in the plugin. http://gwt-code-reviews.appspot.com/102803/diff/1/3 File dev/core/src/com/google/gwt/dev/shell/remoteui/RemoteUI.java (right): http://gwt-code-reviews.apps