[gwt-contrib] Re: Code Review Request: Implementation of the RemoteUI [Updated]

2009-10-20 Thread jat
http://gwt-code-reviews.appspot.com/83802/diff/1/2 File dev/core/src/com/google/gwt/dev/HostedModeBase.java (right): http://gwt-code-reviews.appspot.com/83802/diff/1/2#newcode382 Line 382: options.setRemoteUIArgs(remoteUIArgs); On 2009/10/20 21:57:53, rdayal wrote: > On 2009/10/20 21:22:52, jat

[gwt-contrib] Re: Code Review Request: Implementation of the RemoteUI [Updated]

2009-10-20 Thread rdayal
Thanks for the review of the arghandler code. Updated the patch set with the suggested changes. http://gwt-code-reviews.appspot.com/83802/diff/1/2 File dev/core/src/com/google/gwt/dev/HostedModeBase.java (right): http://gwt-code-reviews.appspot.com/83802/diff/1/2#newcode382 Line 382: options.se

[gwt-contrib] Re: Code Review Request: Implementation of the RemoteUI [Updated]

2009-10-20 Thread rdayal
Committed as r6426. http://gwt-code-reviews.appspot.com/83802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---

[gwt-contrib] Re: Code Review Request: Implementation of the RemoteUI [Updated]

2009-10-20 Thread jat
http://gwt-code-reviews.appspot.com/83802/diff/1/2 File dev/core/src/com/google/gwt/dev/HostedModeBase.java (right): http://gwt-code-reviews.appspot.com/83802/diff/1/2#newcode382 Line 382: options.setRemoteUIArgs(remoteUIArgs); On 2009/10/20 21:21:06, mmendez wrote: > This seemed more congruent

[gwt-contrib] Re: Code Review Request: Implementation of the RemoteUI [Updated]

2009-10-20 Thread mmendez
LGTM There are a couple of nits, but this does work end-to-end against the custom plugin build. http://gwt-code-reviews.appspot.com/83802/diff/1/2 File dev/core/src/com/google/gwt/dev/HostedModeBase.java (right): http://gwt-code-reviews.appspot.com/83802/diff/1/2#newcode382 Line 382: options.s

[gwt-contrib] Re: Code Review Request: Implementation of the RemoteUI [Updated]

2009-10-20 Thread jat
I didn't look at anything else. http://gwt-code-reviews.appspot.com/83802/diff/1/2 File dev/core/src/com/google/gwt/dev/HostedModeBase.java (right): http://gwt-code-reviews.appspot.com/83802/diff/1/2#newcode382 Line 382: options.setRemoteUIArgs(remoteUIArgs); Is there value in creating a Remote