Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-18 Thread 'Goktug Gokdogan' via GWT Contributors
It is true that GIN is kind of unmaintained. There has been some internal patches but nobody bothered moving the project out of Google code and export those due to initial overhead. Bu regardless, right now GIN uses reflection with a ClassLoader hack to access types. And at least some code

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-18 Thread 'Goktug Gokdogan' via GWT Contributors
That's fair. I wasn't expecting much need either but just wanted a simpler way out if it ended up being important for the community. On Wed, Feb 17, 2016 at 11:57 PM, Manuel Carrasco Moñino wrote: > I follow, but I have a couple of thoughts > > - Is it actually useful from

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-18 Thread Thomas Broyer
On Thursday, February 18, 2016 at 6:29:22 PM UTC+1, Jens wrote: > > > Isn't GIN unmaintained anyway? >> > (and what we're all waiting for is proper GWT support in Dagger 2 ;-) ) >> > > I don't know. GIN works well and a ton of apps use it. > Well, at least it's not actively developed: with

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-18 Thread Thomas Broyer
On Wednesday, February 17, 2016 at 9:13:43 PM UTC+1, Goktug Gokdogan wrote: > > I think you didn't understand what I said. Let me try to clarify: > > "For any reason, if community wants to run the GWT 2.8 SDK in Java 7 > source level *(i.e. gwtc sourcelevel 7)*, they can theoretically do it by

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-18 Thread Jens
> Isn't GIN unmaintained anyway? > (and what we're all waiting for is proper GWT support in Dagger 2 ;-) ) > I don't know. GIN works well and a ton of apps use it. A lot of these apps will probably not migrate to Dagger 2 anytime soon (especially not if it takes ages for a PR to be

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-18 Thread Thomas Broyer
Isn't GIN unmaintained anyway? (and what we're all waiting for is proper GWT support in Dagger 2 ;-) ) On Thursday, February 18, 2016 at 1:20:34 PM UTC+1, Jens wrote: > > Seems like GWT apps that use GIN will still require Java 8. I just tried > latest master from today using Guava 20-SNAPSHOT,

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-18 Thread Manuel Carrasco Moñino
Agree, there are some corner cases, but normally gwt developers have to deal with a bunch of differences between java and gwt. Anyway I think that it's better that SDK7 users assume some language issues than not be able to compile their projects at all. On Thu, Feb 18, 2016 at 10:17 AM, 'Daniel

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-18 Thread 'Daniel Kurka' via GWT Contributors
We have seen issues internally where some code would be a compile error in Java8 but not in Java7 (especially around type checking). This setup will leave users vulnerable to this since their code will compile in their IDE, but will fail GWT compile. On Thu, Feb 18, 2016 at 8:57 AM Manuel

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-17 Thread Manuel Carrasco Moñino
I follow, but I have a couple of thoughts - Is it actually useful from the user perspective to use a sourceLevel=1.7 if he has to manually provide a compatible gwt-jre-emulation? IMO, he might want that everything works out-of-the-boxy. Right now, gwt emul classes in the 2.8-snapshot make fail

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-17 Thread 'Goktug Gokdogan' via GWT Contributors
I think you didn't understand what I said. Let me try to clarify: "For any reason, if community wants to run the GWT 2.8 SDK in Java 7 source level *(i.e. gwtc sourcelevel 7)*, they can theoretically do it by supplying *a java7 compatible JRE emulation* without any compiler/SDK changes *(but just

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-16 Thread Manuel Carrasco Moñino
Removing the 1.7 flag does not make the compiler fail when using a java7 sdk. Now the compiler always thinks that source code is sourced-level 1.8 so it does not fail when looking at java8 emul classes. You can still have the java.source property set to 1.7 when compiling your project and javac

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-16 Thread 'Goktug Gokdogan' via GWT Contributors
To remind the backlog of this: GWT 2.8 decided to support only Java8 source level (see related threads from last year) as the emulation will include Java 8 APIs which cannot be compiled in Java7 mode. However, GWT compiler itself is intended to be runnable in a Java 7 JVM. This should enable

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-15 Thread Thomas Broyer
On Monday, February 15, 2016 at 11:39:02 AM UTC+1, Thomas Broyer wrote: > > > > On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco Moñino > wrote: >> >> Thomas, I want to experiment with this, pls, could you give me some >> advise what are the classes I have to look at? >> > >

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-15 Thread Thomas Broyer
On Monday, February 15, 2016 at 10:06:47 AM UTC+1, Manuel Carrasco Moñino wrote: > > Thomas, I want to experiment with this, pls, could you give me some advise > what are the classes I have to look at? > https://gwt-review.googlesource.com/14353 (currently running the testsuite locally) >

Re: [gwt-contrib] Re: Compiler failing with java 7

2016-02-15 Thread Manuel Carrasco Moñino
Thomas, I want to experiment with this, pls, could you give me some advise what are the classes I have to look at? On Sun, Feb 14, 2016 at 12:00 PM, Thomas Broyer wrote: > Just to make it clearer, my suggestion is: > > * force sourceLevel to 8 (either make the argument a

[gwt-contrib] Re: Compiler failing with java 7

2016-02-14 Thread Thomas Broyer
Just to make it clearer, my suggestion is: * force sourceLevel to 8 (either make the argument a no-op –using 8 even if arg says 7–, or fail on "-sourceLevel 7") * build GWT with JDK 7; particularly the release artifacts (snapshots matter less). Note that this means changing the CI builds to

[gwt-contrib] Re: Compiler failing with java 7

2016-02-13 Thread Manuel Carrasco Moñino
Hi all, in the behave of gwt-maintainers, I'm forwarding this discussion started in the maintainer list to the contributors one. Feel free to contribute with your opinions. Basically the matter is about the convenience of not breaking java7 compatibility in 2.8 Thanks -Manolo On Fri, Feb 12,

[gwt-contrib] Re: Compiler failing with java 7

2016-02-12 Thread Brandon Donnelson
I would choose Java 1.8 all the way if you have to choose. I would do this because this is going to be a long standing maintenance release. Just a note, the Eclipse neon out in June will require Java 1.8. I think it makes sense to upgrade. I think folks can go through the pain of upgrading

[gwt-contrib] Re: Compiler failing with java 7

2016-02-12 Thread Colin Alworth
Switching to gwt-contrib, we're losing voices who are involved in this discussion. Maybe I am missing something, but I had that that the discussion moved toward the fact that the compiler and dev mode will require Java8, but that gwt-servlet could still be compiled to Java7, allowing deployment