LGTM
On Mon, Feb 7, 2011 at 12:15 PM, Eric Ayers zun...@google.com wrote:
I don't have anything else.
On Mon, Feb 7, 2011 at 2:24 PM, sco...@google.com wrote:
Did you guys want to re-review, or having fixed the things you
mentioned, is this LGTM?
Update to patch; I fixed the SOYC issues. SOYC looks good now.
http://gwt-code-reviews.appspot.com/1342801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
One thing I'll mention out of band, is that the changes that switch from
singletons created by JsProgram to instances seem to remove all of the
addCorrelator stuff. Honestly, I don't know what that stuff is used
for (SOYC?) but I wonder what the impact of removing it is.
@zundel: if we did want flyweight literals, we could always manage them
at class level for the whole process rather than at the JsProgram level,
like Integer.valueOf() works.
@cromwellian: I'm not sure to what degree the source info correlations
are useful and important. I guess my plan was to
Updated patch based on feedback.
http://gwt-code-reviews.appspot.com/1342801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
