LGTM, the comments are mostly questions to make sure that I understand
what the code is intended to do.
http://gwt-code-reviews.appspot.com/755801/diff/5001/6002
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
(right):
http://gwt-code-reviews.appspot.com/755801/diff/5001/6006
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java
(right):
http://gwt-code-reviews.appspot.com/755801/diff/5001/6006#newcode24
Oops, missed some of your questions.
Applying the fixes and submitting.
http://gwt-code-reviews.appspot.com/755801/diff/5001/6002
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
(right):
Submitted r8526
On 2010/08/12 17:35:02, Ray Ryan wrote:
Oops, missed some of your questions.
Applying the fixes and submitting.
http://gwt-code-reviews.appspot.com/755801/diff/5001/6002
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
(right):
Amit, can you look at this? For some reason sync responses are coming
back from the server successful but empty, which means that the
PersonProxyChanged event is not being emitted. I'm stumped. Anything
jump out at you?
http://gwt-code-reviews.appspot.com/755801/show
--
Oh, problem is obvious pilot error, fix in a moment.
On Wed, Aug 11, 2010 at 11:31 AM, rj...@google.com wrote:
Amit, can you look at this? For some reason sync responses are coming
back from the server successful but empty, which means that the
PersonProxyChanged event is not being emitted.
http://gwt-code-reviews.appspot.com/755801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ready for review.
http://gwt-code-reviews.appspot.com/755801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
