Is there anything else left to do on this change? Alex's internship is
over, but we'd like to get the change in.
On 2010/08/10 08:44:14, zundel wrote:
Hi Andre, I'm waiting on Ray C or Lex to give the LGTM, but I noticed
this last patch you uploaded left out the editdistance library files.
Hi Andre, I'm waiting on Ray C or Lex to give the LGTM, but I noticed
this last patch you uploaded left out the editdistance library files.
On Mon, Aug 9, 2010 at 4:48 PM, avassalo...@google.com wrote:
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006
File
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006#newcode43
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:43:
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006#newcode43
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:43:
Looking forward to seeing this land!
http://gwt-code-reviews.appspot.com/669801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I updated the patch.
Lex, can I submit it?
http://gwt-code-reviews.appspot.com/669801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Ray, does the patch look good to you? -Lex
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006#newcode43
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:43:
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006#newcode43
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:43:
On 2010/08/05 23:02:48, Alexandre Vassalotti wrote:
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/33001/34006#newcode43
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006#newcode62
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:62: if
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006#newcode62
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:62: if
Oh, sorry. I made this comment somewhere else. The problem is the
endStatements() method doesn't use the regex to recognize the other
declaration style.
In addition, I believe the current regex don't match the declaration
emitted by the cross-linker. The dot in the name prevent a match.
On Wed, Jul 28, 2010 at 6:15 PM, avassalo...@google.com wrote:
Oh, sorry. I made this comment somewhere else. The problem is the
endStatements() method doesn't use the regex to recognize the other
declaration style.
Ah, yes! Well at the least this code should be moved to a subroutine. I
On 2010/07/28 22:25:06, Lex wrote:
I thought so at first, but it's using find(). So it should still
match. Perhaps it matches too many
The caret in the regex ^(function |[A-Za-z0-9_$]+=function) only
matches the beginning of a string. So I don't think using find() changes
anything.
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006#newcode39
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:39:
private static
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006
File dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java
(right):
http://gwt-code-reviews.appspot.com/669801/diff/20001/21006#newcode39
dev/core/src/com/google/gwt/dev/jjs/impl/JsFunctionClusterer.java:39:
private static
17 matches
Mail list logo
