[gwt-contrib] Re: Hello DialogBoxParser

2009-11-09 Thread rjrjr
Actually, re: building the mocks out of class literals: No. I had it working with literals originally and then I took them away. The test ran twice as fast (!), presumably because of all the class init code that didn't run. Note also that the mock resources are very low fidelity, not even matchin

[gwt-contrib] Re: Hello DialogBoxParser

2009-11-09 Thread rjrjr
http://gwt-code-reviews.appspot.com/97806/diff/1001/56 File user/src/com/google/gwt/uibinder/rebind/XMLElement.java (right): http://gwt-code-reviews.appspot.com/97806/diff/1001/56#newcode50 Line 50: @SuppressWarnings("deprecation") On 2009/11/09 18:33:27, bobv wrote: > This is a big class. Done

[gwt-contrib] Re: Hello DialogBoxParser

2009-11-09 Thread rjrjr
Reviewers: bobv, Message: Nits addressed, committed tr...@6774, 2.0 soon. Description: DialogBox is weird--it implements both HasHTML and HasWidgets. This confuses the bejeebers out of UiBinder and leads it to generate bad code, so a custom parser is required. I took this excuse to generalize th