LGTM other than removing the Safari2 support.
http://gwt-code-reviews.appspot.com/48806/diff/1/3
File user/test/com/google/gwt/user/client/rpc/UnicodeEscapingTest.java
(left):
http://gwt-code-reviews.appspot.com/48806/diff/1/3#oldcode66
Line 66: private static native boolean isSafari2() /*-{
Do
On 2009/07/02 20:58:49, jat wrote:
> LGTM other than removing the Safari2 support.
> http://gwt-code-reviews.appspot.com/48806/diff/1/3
> File user/test/com/google/gwt/user/client/rpc/UnicodeEscapingTest.java
(left):
> http://gwt-code-reviews.appspot.com/48806/diff/1/3#oldcode66
> Line 66: priva
On Thu, Jul 2, 2009 at 5:05 PM, wrote:
> We (and just about everyone else) officially dropped support for Safari
> 2 some time ago. It was uncontroversial when discussed on gwt-contrib.
Ok -- Eric misinformed me about still running the Safari2 tests.
In that case, we should remove its associat
http://gwt-code-reviews.appspot.com/48806
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
LGTM. We do need to verify that it passes on iPhone, Android, and
Chrome, but since you only added more characters to be escaped I can't
imagine it would have broken them.
http://gwt-code-reviews.appspot.com/48806
--~--~-~--~~~---~--~~
http://groups.google.com/gr
