Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Wednesday, October 11, 2017 at 9:02:26 PM UTC+2, Goktug Gokdogan wrote: > > There should be something around syncToServer + HtmlUnit causes the issue > (I guess RPC gets called back sooner than timeout(0) but didn't debug) but > I don't think this in practice will effect anything else. > >

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

I think waiting for a month to discuss issues in person is impractical when you can use the contributor list and usually get responses less than a day. Plus the discussion is documented automatically for future reference. For the cases of releases where more issues / discussions needed (not

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

> Alternatively, gitter.im/gwtproject/gwt is extremely active, and only > missing representation from google. LIkewise could schedule some time to > quickly discuss things. > There is also https://gitter.im/gwtproject itself which can only be joined by members of the Github GWT organization.

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Wed, Oct 11, 2017, at 02:01 PM, 'Goktug Gokdogan' via GWT Contributors wrote:> > PS: pls avoid the urge to discuss technical stuff in steering commitee > and try to keep it in the contributor list ;) If we could get the monthly (weekly?) contrib calls going again so we have someone to

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

There should be something around syncToServer + HtmlUnit causes the issue (I guess RPC gets called back sooner than timeout(0) but didn't debug) but I don't think this in practice will effect anything else. Enabling batch mode by default for everything potentially effects timeouts also sometimes

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

As discussed minutes ago in meeting: here's the patch to enable -batch module for all our HtmlUnit tests: https://gwt-review.googlesource.com/c/gwt/+/19740 Once that one and the HtmlUnit workaround are in, we can rebase Daniel's patch about trapping window.onerror by default. On Wednesday,

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Wednesday, October 11, 2017 at 4:52:06 AM UTC+2, Goktug Gokdogan wrote: > > tbroyer: Are you using batch mode while testing? We are using -batch > module internally and maybe you guys do not externally? (though you linked > the code that only runs in batch mode, IIRC). > That's right, we

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

tbroyer: Are you using batch mode while testing? We are using -batch module internally and maybe you guys do not externally? (though you linked the code that only runs in batch mode, IIRC). On Tue, Oct 10, 2017 at 1:04 PM, Thomas Broyer wrote: > I'll try with the manual

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

I'll try with the manual runstyle, i.e. with a real browser, and see how it goes. Thanks for the feedback. -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

I am not aware of anything specific we have done within Google, we never imported the jetty upgrade. I think you just go ahead for open source and make it work there. We do not care that much for htmlunit anymore within Google. On Tue, Oct 10, 2017 at 10:28 AM Thomas Broyer

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Tuesday, October 10, 2017 at 6:08:05 PM UTC+2, Colin Alworth wrote: > > Patch is accepted and merged into upstream HtmlUnit, see > https://sourceforge.net/p/htmlunit/bugs/1924/ for more detail. > > Daniel, when you can take a look at Thomas's question, we can get this > change made to open

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

Patch is accepted and merged into upstream HtmlUnit, see https://sourceforge.net/p/htmlunit/bugs/1924/ for more detail. Daniel, when you can take a look at Thomas's question, we can get this change made to open source GWT as you requested. -- You received this message because you are subscribed

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Saturday, October 7, 2017 at 9:37:38 PM UTC+2, Thomas Broyer wrote: > > > > On Saturday, October 7, 2017 at 5:20:15 PM UTC+2, Thomas Broyer wrote: >> >> >> >> On Saturday, October 7, 2017 at 4:54:28 PM UTC+2, Colin Alworth wrote: >>> >>> Like we do for >>>

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Saturday, October 7, 2017 at 5:20:15 PM UTC+2, Thomas Broyer wrote: > > > > On Saturday, October 7, 2017 at 4:54:28 PM UTC+2, Colin Alworth wrote: >> >> Like we do for >> com.google.gwt.junit.RunStyleHtmlUnit.HostedJavaScriptEngine so we can hook >> in the "plugin". Looks like that idea

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Saturday, October 7, 2017 at 4:54:28 PM UTC+2, Colin Alworth wrote: > > Like we do for > com.google.gwt.junit.RunStyleHtmlUnit.HostedJavaScriptEngine so we can hook > in the "plugin". Looks like that idea might be a winner! Just make sure to > swap it in both cases, don't want to kill

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

Like we do for com.google.gwt.junit.RunStyleHtmlUnit.HostedJavaScriptEngine so we can hook in the "plugin". Looks like that idea might be a winner! Just make sure to swap it in both cases, don't want to kill tests in old dev mode. -- You received this message because you are subscribed to the

[gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Saturday, October 7, 2017 at 3:01:52 PM UTC+2, Colin Alworth wrote: > > Exactly - I wasn't planning on adding the javaToJs(), but was going to > unwrap the exception before calling onerror (or have ScriptException > implement Scriptable). Have a short test that demonstrates the issue >

[gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

Exactly - I wasn't planning on adding the javaToJs(), but was going to unwrap the exception before calling onerror (or have ScriptException implement Scriptable). Have a short test that demonstrates the issue without gwt (but wow they have a lot of GWT in their source tree), and am was waiting

[gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Friday, October 6, 2017 at 7:55:15 PM UTC+2, Colin Alworth wrote: > > Okay, I'm about 80% sure that I understand and can remedy the problem > within HtmlUnit itself. Will update once I finish syncing the apparently > canonical SVN repo to git, so I can go over the history more carefully and

Re: [gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

It was not my intention to get this into 2.8.2, but to wait for 2.9. If we think it is important enough, I can look into it, but I figure we have to draw the line somewhere... -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe

[gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

On Friday, October 6, 2017 at 7:55:15 PM UTC+2, Colin Alworth wrote: > > Okay, I'm about 80% sure that I understand and can remedy the problem > within HtmlUnit itself. Will update once I finish syncing the apparently > canonical SVN repo to git, so I can go over the history more carefully and

[gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

Okay, I'm about 80% sure that I understand and can remedy the problem within HtmlUnit itself. Will update once I finish syncing the apparently canonical SVN repo to git, so I can go over the history more carefully and ensure that this break isn't deliberate. A question for my fellow GWT

[gwt-contrib] Re: Jetty upgrade broke HtmlUnit for window.onerror

Good news is that getting past the failed to start shell issue isn't that bad, mostly transitive dependency changes (man there are times I love maven, mostly when I'm not using it...), but also losing the ability to run tests in IE8, IE11. Not sure that is a great loss. Bad news is that it