[gwt-contrib] Re: Passing a ViewDataUpdater into Cell#onBrowserEvent so that cells can update view data after the ... (issue689801)

2010-07-16 Thread jlabanca
committed as r8383 http://gwt-code-reviews.appspot.com/689801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Passing a ViewDataUpdater into Cell#onBrowserEvent so that cells can update view data after the ... (issue689801)

2010-07-14 Thread rjrjr
LGTM http://gwt-code-reviews.appspot.com/689801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Passing a ViewDataUpdater into Cell#onBrowserEvent so that cells can update view data after the ... (issue689801)

2010-07-14 Thread jlabanca
Updated based on the conversation with rjrjr and the new design doc. Instead of passing viewData and a ViewDataUpdater into cells, we create AbstractEditableCell that provides an API to store view data. That means that Cell does not have a concept of ViewData, and the ViewData in AbstractEditable

[gwt-contrib] Re: Passing a ViewDataUpdater into Cell#onBrowserEvent so that cells can update view data after the ... (issue689801)

2010-07-14 Thread jlabanca
Reviewers: Ray Ryan, Description: Passing a ViewDataUpdater into Cell#onBrowserEvent so that cells can update view data after the event has passed. Some editable cells did not fully use view data, but now they use it to store their current state. Also adding view data support to all cell widget