[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

LGTM On 2010/11/15 20:20:20, Nick Chalko wrote: http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

LGTM except for a problematic comment in samples/build.xml http://gwt-code-reviews.appspot.com/1085801/diff/54001/55001 File samples/build.xml (right): http://gwt-code-reviews.appspot.com/1085801/diff/54001/55001#newcode59 samples/build.xml:59: ' http://gwt-code-reviews.appspot.com/1085801/sho

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

http://gwt-code-reviews.appspot.com/1085801/diff/40002/42001 File samples/build.xml (right): http://gwt-code-reviews.appspot.com/1085801/diff/40002/42001#newcode59 samples/build.xml:59: On 2010/11/11 22:05:51, rchandia wrote: Remove this to prevent validationtck from being built and copied int

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

I think it is better to take validationtck out of the general ant build. That way it will not get built into the distributable bits. A few modified files lack the "Modified by Google" notice. http://gwt-code-reviews.appspot.com/1085801/diff/40002/42001 File samples/build.xml (right): http://gw

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

ant clean ant works PTAL now http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

I have, but not from a clean dir (must have created that by hand at some time, my bad) Let me fix that. -- Generate your java flags for easier testing. go/java_flags -- http://groups.google.com/group/Google-Web-Toolki

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

Have you tried running ant? I am getting: BUILD FAILED /usr/local/google/users/rchandia/src/gwt-trunk/google3/third_party/java_src/gwt/svn/trunk/build.xml:102: The following error occurred while executing this line: /usr/local/google/users/rchandia/src/gwt-trunk/google3/third_party/java_src/gwt/s

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001 File samples/build.xml (right): http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001#newcode46 samples/build.xml:46: On 2010/11/09 22:11:55, rchandia wrote: This should be if we want the ValidationTck sample to appear in the g

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

On 2010/11/09 22:11:55, rchandia wrote: This probably needs a README file to help users run the tests. I am not sure where the right place to put all of this code is. This not really a sample but a HACK to run the Technology Compatibility Kit for JSR 303. See http://docs.jboss.org/hibernate/st

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

This probably needs a README file to help users run the tests. I was not able to generate a gwt-x.y.z.zip containing the validationtck sample is that intended? http://gwt-code-reviews.appspot.com/1085801/diff/3001/4001 File samples/build.xml (right): http://gwt-code-reviews.appspot.com/1085801

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

On 2010/11/08 17:52:00, bobv wrote: Rodrigo, do you have any cycles to take a look at this client-side validation patch? > http://gwt-code-reviews.appspot.com/1085801/show Sure. I'll review it. http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

Rodrigo, do you have any cycles to take a look at this client-side validation patch? > http://gwt-code-reviews.appspot.com/1085801/show -- Bob Vawter Google Web Toolkit Team -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Public: GWT version of the JSR 303 Bean Validation TCK (issue1085801)

http://gwt-code-reviews.appspot.com/1085801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors