[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
r8386 http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread bobv
LGTM I'm inclined to say that the multiple cancels case results in arbitrary output, since that's all we've offered internally for quite a while and no one has complained. Ok. Seems like following your GWT.create suggestion, and the existence of the delegate hook itself are enough prot

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/diff/8001/9002 File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java (right): http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode62 user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java:62: deltas = null; // si

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread bobv
Couple of questions. http://gwt-code-reviews.appspot.com/698801/diff/8001/9002 File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java (right): http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode73 user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java:73

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread t . broyer
LGTM (awesome! next step: integration with History ;-) ) http://gwt-code-reviews.appspot.com/698801/diff/8001/9002 File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java (right): http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode62 user/src/com/google/gwt/app/pla

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors

[gwt-contrib] Re: Puts PlaceController in the business of showing the user (issue698801)

2010-07-16 Thread rjrjr
http://gwt-code-reviews.appspot.com/698801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors