[gwt-contrib] Re: RR : First pass at implementing ValueProxy support. (issue1108802)

2010-11-17 Thread rchandia
LGTM. Only mostly cosmetic nits. This CL does not contain tests for violations in value proxies, right? http://gwt-code-reviews.appspot.com/1108802/diff/1/20 File user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java (right): http://gwt-code-reviews.appspot.com/11

[gwt-contrib] Re: RR : First pass at implementing ValueProxy support. (issue1108802)

2010-11-18 Thread bobv
Thanks for the review, will submit with ValueProxy validation strategy previously discussed. http://gwt-code-reviews.appspot.com/1108802/diff/1/20 File user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java (right): http://gwt-code-reviews.appspot.com/1108802/diff/1