[gwt-contrib] Re: Salvage useful bits from overrides work (issue1436801)

LGTM On Mon, May 16, 2011 at 9:47 PM, wrote: > There's no expected net change in behavior, it's just code cleanup. > > > http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java > File dev/core/src/com/google/gwt/dev/jjs/impl/Gener

[gwt-contrib] Re: Salvage useful bits from overrides work (issue1436801)

There's no expected net change in behavior, it's just code cleanup. http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews

[gwt-contrib] Re: Salvage useful bits from overrides work (issue1436801)

http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java File dev/core/src/com/google/gwt/dev/jjs/impl/GenerateJavaScriptAST.java (right): http://gwt-code-reviews.appspot.com/1436801/diff/2001/dev/core/src/com/google/gwt/dev/jjs/im

[gwt-contrib] Re: Salvage useful bits from overrides work (issue1436801)

I'm almost ready to sign off on this (things do look cleaner and more concise). But I'm not sure, is there a net effect here, other than code cleanup/refactoring? What's the expected change/improvement? Is tracking of overrides being removed from soyc? http://gwt-code-reviews.appspot.com/1436801