[gwt-contrib] Re: The scaffold app is now a master / detail app. And it even warns (issue452801)

2010-05-04 Thread Ray Ryan
Amit, after you left I did one more not-small change, introducing AbstractRecordEditActivity. I'm submitting this anyway, but could you take a look at that extra bit? On Tue, May 4, 2010 at 4:10 PM, wrote: > From a desk review with Amit: > > the generated code is only using getText(), but it's s

[gwt-contrib] Re: The scaffold app is now a master / detail app. And it even warns (issue452801)

2010-05-04 Thread rjrjr
From a desk review with Amit: the generated code is only using getText(), but it's supposed to prefer getValue() ScaffoldMasterActivities should be made reusable Need to verify that ScaffoldMobile hasn't been damaged. It still works, but does it work right? Seeing double-deregistration on onSt

[gwt-contrib] Re: The scaffold app is now a master / detail app. And it even warns (issue452801)

2010-05-03 Thread rjrjr
Ray, if you manage to review this tonight I'll submit it tonight. http://gwt-code-reviews.appspot.com/452801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors