[gwt-contrib] Re: UI cleanups

2009-11-24 Thread jat
The reason for the UI thread changes is to avoid glitches where the combo box might not have the right width, or sometimes might not have any contents, or the panel isn't created properly, etc. http://gwt-code-reviews.appspot.com/111809/diff/1/6 File dev/core/src/com/google/gwt/dev/SwingUI.java (

[gwt-contrib] Re: UI cleanups

2009-11-24 Thread rdayal
LGTM, with a few nits. Also, I didn't understand why you changed a bunch of things in SwingUI to run on the UI thread. What was the specific reason for this? http://gwt-code-reviews.appspot.com/111809/diff/1/6 File dev/core/src/com/google/gwt/dev/SwingUI.java (right): http://gwt-code-reviews.app